From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752311AbbE0GMf (ORCPT ); Wed, 27 May 2015 02:12:35 -0400 Received: from mail-bn1on0065.outbound.protection.outlook.com ([157.56.110.65]:59808 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752091AbbE0GMb (ORCPT ); Wed, 27 May 2015 02:12:31 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; ettus.com; dkim=none (message not signed) header.d=none; Message-ID: <55656044.7050702@xilinx.com> Date: Wed, 27 May 2015 08:12:20 +0200 From: Michal Simek User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Moritz Fischer , Jingoo Han CC: Michal Simek , , , , , , , , =?UTF-8?B?U8O2cmVuIEJyaW5rbWFubg==?= , , Greg KH , , , , , Subject: Re: [PATCHv1 0/2] Adding driver for Xilinx LogiCORE IP mailbox. References: <1432317791-26851-1-git-send-email-moritz.fischer@ettus.com> <5562BB92.60808@xilinx.com> <000101d096f2$97457cf0$c5d076d0$@com> In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21570.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD041;1:bBAUcIKh2TVR2tHHAKg8AORVVQaMhfa+1Q8GQ8cE//FUkICR8Ty9Bk5c9HMhRTTnftwSQBK9nEAVMT0Ji6PVubasQ+OWsmwoN2IonZezgJaNSvtrzerZoXpMltPDZmkR6JAcGWXyMaCigAJk6ysSw1R+uVQaNmzV5Sk9I8TdUoh58rd5b7gFXJKmSOJbfSG9f6mY4FP4eORwABIY2oIQw/xRzx/Z6Um7i9byl5yQBI3U7hFUwH6LE6EeymczxL1E5bDJWY5ngyhOOwbXJD1a0A== X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(438002)(24454002)(199003)(51914003)(189002)(377454003)(479174004)(164054003)(51704005)(87936001)(5001770100001)(36386004)(4001540100001)(65816999)(36756003)(99136001)(117636001)(46102003)(189998001)(93886004)(5001860100001)(92566002)(77156002)(4001350100001)(64126003)(86362001)(62966003)(81156007)(63266004)(77096005)(76176999)(5001830100001)(23676002)(5001960100002)(106466001)(50986999)(64706001)(6806004)(2950100001)(87266999)(19580405001)(59896002)(65806001)(47776003)(65956001)(83506001)(50466002)(54356999)(19580395003)(107986001)(62816006);DIR:OUT;SFP:1101;SCL:1;SRVR:BL2FFO11HUB060;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;PTR:unknown-60-83.xilinx.com;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11HUB060;2:A4d/NB2UHsjDNOMTewytwMTcYKHVLN/ZxWrODbfNOKGDrwQNxIHgF6nc31Tkpykj;2:lTKsMY/zIe+K80yR+BghIEbT90c+ieQSWBM7x0ssaE6W9uuOai4dqeh2h50Zay19yeIwwMsUgVDQ1cCT8XdTOCzTClYr5j+BuboitCFvwV2H+QhphleqXpGn9VqRBfXWgZKJE9fJt2Vb2pHCs8ac2MYrVyDy5JzooSSpryvQhGPwo+6ie5NWmFgFomGdSbrJSHZ23svbz1DtzTJL2xGe1oaceB0YpvJoYRl52Od28n8=;6:/Mn0xadZG5vKSd/RRS3btCos8vyhPpJxDtgko2v0pOlwUq300OkQGAnpeALoMDfkxsach3Dd9H/MooYY5zCj7Q+uCCvdsKt2Ht3oJ/sPLieDYwPKNgBiisT2YRLg35Bpk3G49yf8m5aExY20OkDdZIDP6KtuRnPGyWVoft/EbGtusNBCLv2Z7fuvsh1nGIXmoerR6LGmQnND1UHGFvjCv6UVUtocrItUSB9IV/5BacDQuSQiMjBFQPBqsbw21UYOOYmFMw5i5CaIvNrUyzTEZHZJbGu2f41aQ5vIZtsjWfyw3fsGVjrSQPGroSRdkpwhTE7sD45Vh6fb1IWsZOkwK/QVi/GV0RI2Q8FqqBieuXG6oBRDIOfU9eox2L6PM2Pajz+K+3/YdAqhqZ8SNaYxO1LPAMnKAFivlbPU3E9MZEEtsrrtBP9ztDdljSzwfoQXQ4Qg3huf6+kQoqd5vDVLk7l09XwJQ0/SE51gg+KVRgyeXYUrh7SnVOT2fs4s2uyG X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BL2FFO11HUB060;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BL2FFO11HUB028; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:BL2FFO11HUB060;BCL:0;PCL:0;RULEID:;SRVR:BL2FFO11HUB060; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11HUB060;3:NEXzlTruKP4b55q0jjFh968gc5WOkp4L/W6028Fr99hs+wojhWvfrHVoCTiLk4FIc4eL6Pw6CWwoNnZsPXvu+gCl+pY8pTqVXr5NtN51Zgc22qzRTU4KeDHDHz0QgLWMxfr4fW7mI8oarUtgqXmPflW/ysG4WCyWKq+CcW3VUkZs9hN1GBX+dvSeFbaLhWZylIPHwlSZDmKIU7zFB01awM+G7BKPy+3I4PlVjW/2SJWTB1wRM/gK4aDskgbbnHZ5SjVxtIyc4hxAtnQwowupjS2ZkTHlrTyTxOrSde+kkmf0KfUwtOCRHD6EvO7M+tVp X-Forefront-PRVS: 05891FB07F X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTDJGRk8xMUhVQjA2MDs5OkVNNXpYbUdwdVdHWTZ4SXJmSVlzVm5GN3lR?= =?utf-8?B?WUNsZUxZZlZWZTdldDg0QXdHTStMdERPWkNxMk9MMUg1UnBMcVBEaXBidHJV?= =?utf-8?B?V1B1ZUxRUXcrUll2blgrSlBVRDRzNy9qc21BdVlWSkNYQi91b2t4MVYzQzJo?= =?utf-8?B?SE83VGw3S1lMWnN4UXQrU1NWTmxmQjVnbTN6MnpxY0lGRU40MTRJZWI1WGpB?= =?utf-8?B?ZkloY3ZURUttVTNON1lrMVJ0VkR0c1JBTXEzelNycUttTnRkUVBMa0tSWlpI?= =?utf-8?B?bG9BUko5R0JSK1NZay8reTU1cUQ2WERJL1hRR1ZmWDdseDJZMHlqdWZYQ1NT?= =?utf-8?B?a3BYZ2ZtaG9DdDcxODFldlRUOTUyL2JVbEE3VVVCOUpzam8wczBVeFhuWUVw?= =?utf-8?B?L0FVZ0R1cFBLNHVBT21uaDQ1Qk0zM1lBVzQ3VzI4YkRUei9ZeUF6MUVMWXB2?= =?utf-8?B?OG91UHZ4VGx1cG8xczREeStTamxJd0VOVXJwSGYydlVqQmJRNytWOUFrdmhF?= =?utf-8?B?TFY5amtxUFFLdUNnbWJmNW96M1YxUkNlNUdDWitENmlGdzZ5cFJBZ0taaWFN?= =?utf-8?B?ZGlkcVpYZmo4TEJlK2xwSVAxZEVSdklvclN5SmkxTVJFSHVxMXlCUE02dG15?= =?utf-8?B?L0RabWlXY0pnTkRFQ3VhdENva2FvMFJIcG5ORDVsTnlpV2ljeUc5Mmdtc1hJ?= =?utf-8?B?cmRBdHFReEx1Tlc5K3pLcHNNaTJZcUJNOGgwNWxtVHhHallVRWp0dkQ1Nmsr?= =?utf-8?B?bXlNWVNra0NLdGFDVFFUWFdTaDVPZWxFOUFEVTdsZmxmWXRYTExESUx3V0NB?= =?utf-8?B?VFBFRDkwQW9EOEppc3VQSm56WmxiNUFrSVF1VmlzdFFjME9NR3VBUC9Wa1pw?= =?utf-8?B?d3JLcHl6TkI5U3NQWFlKWHBtWlIyWVg5WDRjTlBqY0FMcEZFY0VVK2xzd1o3?= =?utf-8?B?SXNMRHVjOUdsK3dNVjQ2aXF1QU9JUit3MTRpV0tkMnZBa2EwV2IxT2o0V2pq?= =?utf-8?B?R0JxZTd6ZlFGREJzU3hoSitLVGpROE5zY3gwWjhpSS9JQmpST2xlUWRxYkRY?= =?utf-8?B?K2VCcDZURWg5NDFsbjRKeDVNTzV5VFM0U0d0RVdDeCtEZUVwNnY3Unp1dzhr?= =?utf-8?B?U1JZWjZSVTNzQzBZTU1nSkt4RTI0QmdhSlM2NENaM2h0c25BdU1QWHFJSnR1?= =?utf-8?B?cVZwUGJHcXpQK3JSNTEwTDdacWwxWEozZ2hyVjBldlJkSi92UHBwUHNUQm1q?= =?utf-8?B?SThYUzdnSUZzaVZMTkNhVU12Z2VOcmtGNVl6dTkwaldLWFFYSGovU2ZhQ3JU?= =?utf-8?B?enJXN2ErR2E4NjdPY1ZlVzlRV2NlZGZhZGZNLzhjT1FQbnJBUEtkekhHazhs?= =?utf-8?B?NXd3Ull1MC9rNVZxSktvMEs5SWcrcDhHNGRHblV5NWFXTkJhS29GYjhoZXhZ?= =?utf-8?B?MEhaRGRMY054YjRvZlVEWjd0eS8zaDQ1Q2tVd0Npb0xwWWRYVEwxNGVzZjkz?= =?utf-8?B?OGF1bm4zcmFpS1FLd1p6N2xEaW5XRzUwUlpEVUFPVnJGaFRPTUJ6OUpoM2J3?= =?utf-8?B?RGRVTlN5d0NERW1JcFF1bFhNMUN0YVdKSENaZFdEa3lETFJzWmlMNEtVMFB6?= =?utf-8?B?MDhYRTVhdndrMUpNcjJYOUZyREFOZFVHeURVL3JaU00rb2pRKzdFdlBXTzha?= =?utf-8?B?aytqUHpZc0VXNEJlYzE3N3ptQVhYS0gyQXM2cmdMN2Z6b1phNkprZFZxKzNB?= =?utf-8?B?TmlJTWR3WTZ4Q0x4cmJqRHhPaFdVMW5uWngxUFZmUzg4K3VoWW5na0FrQ2Vw?= =?utf-8?Q?3q0mKCqlwSNmy?= X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11HUB060;3:2nw1dcPrCAgNUOfLMrLsHF3chJ4fHIOfKV1PNnGBp0xVdQ31xlsI+a+g/o6Qz1pIbo/o4O9qQy4SbdRqoSdAqW5IUICWPUaSOlrRpXCBZkRAXLDb9djO326QAhyBFNRxDEzGvedMtO0ImepZAM+ceA==;10:ghBIT0ixbFB+LNoDlMAd+ySs7DIRPvXpLmjrnzyyxlTYsu37kXSgnGEvY3RmQHFyW/Aa2ZiQROad0mLG6k400IZdbbz+NlwgJVunoKS5Mk0= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2015 06:12:28.5509 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2FFO11HUB060 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11HUB028;2:x/VExARUOQ+YQ3snAZ+DTHY8wMUZjg8S6/Ngpgr3HjIg9oeHSu0E5z8jKwM1ipg9;2:jPnoRdatYwglfjp5CN0xPQePnypAPetA2Ef6y5V0F4szNhtTU/prZXEGsPlMXHrVvegB5zVQqwzKJAhPHtn4soAt64nZ0ZYgxUfREn7BbHVyXkkrSpzdIPFMmjrwgYdF2VRMpspVAAepx955EWW/TtEh3hjgZcQYZu0r13JyUg+I0ivVVzYEZeog/PmFj0wldN6G56tSg6fPk6ElYImtgSF7aFn/MMPPyPCQaFPQoqw=;9:hBCoIdRKZIwrgZ12+uQ4uMDEwnQ0dpo1W4oOaFlA7VOnQUuA88q0znxlfbbtIwrVGGMEQs00JEM/sRSY61Jlly+pkM+pJO0+4KevX4N7EBUnwoti1OidzOSq8oSA3cTXvv5fOZPXJEMPzxEKaa+euw== X-OriginatorOrg: xilinx.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/26/2015 06:12 PM, Moritz Fischer wrote: > On Mon, May 25, 2015 at 6:56 AM, Jingoo Han wrote: >> On Monday, May 25, 2015 3:05 PM, Michal Simek wrote: >>> On 05/22/2015 08:03 PM, Moritz Fischer wrote: >>>> This patchset adds mailbox framework integration for the Xilinx LogiCORE IP >>>> mailbox. The Xilinx LogiCORE IP mailbox is a fpga softcore that allows >>>> interprocessor communication between AXI4 stream / memory mapped >>>> processors. >>>> >>>> Changes from v0: >>>> --------------------- >>>> >>>> - Several stylistic issues >>>> - Dropped superfluous intr_mode member >>>> - Really masking the IRQs on mailbox_shutdown >>>> - No longer using polling by accident in non-IRQ mode >>>> - Swapped doc and driver commits >>> >>> Changes update should be in every particular patch. >>> Also v1 is used to the first version that's why this one should be v2. > > > Thanks for the feedback. I guess making the next round v2 would be > less confusing, > than restarting the entire patchset from v1? yep. v2 make sense. Thanks, Michal