From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752197AbbE0HOK (ORCPT ); Wed, 27 May 2015 03:14:10 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:36834 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750977AbbE0HOH (ORCPT ); Wed, 27 May 2015 03:14:07 -0400 Message-ID: <55656EBC.4030200@suse.cz> Date: Wed, 27 May 2015 09:14:04 +0200 From: Jiri Slaby User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Nicholas Mc Guire CC: Nicholas Mc Guire , Josh Poimboeuf , Seth Jennings , Jiri Kosina , Vojtech Pavlik , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] livepatch: match return value to function signature References: <1431323549-27343-1-git-send-email-hofrat@osadl.org> <5550674A.4030203@suse.cz> <20150527065605.GA11782@opentech.at> In-Reply-To: <20150527065605.GA11782@opentech.at> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/27/2015, 08:56 AM, Nicholas Mc Guire wrote: > On Mon, 11 May 2015, Jiri Slaby wrote: > >> On 05/11/2015, 07:52 AM, Nicholas Mc Guire wrote: >>> klp_initialized() should return bool but is actually returning >>> struct kobject * - convert it to a boolean explicitly. >>> >>> Signed-off-by: Nicholas Mc Guire >> >> Reviewed-by: Jiri Slaby >> > sorry for the noise - discussions about a similar "cleanup" in RCU > resulted Joe Perches clarifying the matter - this > explicit conversion makes static code checkers happy but is not > needed for gcc (or C for that mater) - see > http://lkml.org/lkml/2015/5/24/47 > and ISO/IEC 9899:1999 (c99) 6.8.6.4 subclause 3) Oh yes and I seem to be inconsistent with replies: https://lkml.org/lkml/2015/5/26/90 > hofrat You? Nuremberg, 2010, Stanse? thanks, -- js suse labs