From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752071AbbE0L4L (ORCPT ); Wed, 27 May 2015 07:56:11 -0400 Received: from mail-pd0-f176.google.com ([209.85.192.176]:36861 "EHLO mail-pd0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751537AbbE0L4I (ORCPT ); Wed, 27 May 2015 07:56:08 -0400 Message-ID: <5565B0D1.80004@samsung.com> Date: Wed, 27 May 2015 20:56:01 +0900 From: Krzysztof Kozlowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Pankaj Dubey , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org CC: thomas.ab@samsung.com, kgene@kernel.org, linux@arm.linux.org.uk, heiko@sntech.de Subject: Re: [PATCH 2/5] ARM: EXYNOS: Remove SROM related register settings from mach-exynos References: <1430296712-10287-1-git-send-email-pankaj.dubey@samsung.com> <1430296712-10287-3-git-send-email-pankaj.dubey@samsung.com> In-Reply-To: <1430296712-10287-3-git-send-email-pankaj.dubey@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org W dniu 29.04.2015 o 17:38, Pankaj Dubey pisze: > As now we have dedicated driver for SROM controller, it will take care > of saving register banks during S2R so we can safely remove these > settings from mach-exynos. > > Signed-off-by: Pankaj Dubey > --- > arch/arm/mach-exynos/Kconfig | 2 + > arch/arm/mach-exynos/exynos.c | 10 ----- > arch/arm/mach-exynos/include/mach/map.h | 3 -- > arch/arm/mach-exynos/suspend.c | 20 +--------- > arch/arm/plat-samsung/include/plat/map-s5p.h | 1 - > arch/arm/plat-samsung/include/plat/regs-srom.h | 54 -------------------------- > 6 files changed, 4 insertions(+), 86 deletions(-) > delete mode 100644 arch/arm/plat-samsung/include/plat/regs-srom.h > > diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig > index 603820e..e842b23 100644 > --- a/arch/arm/mach-exynos/Kconfig > +++ b/arch/arm/mach-exynos/Kconfig > @@ -25,6 +25,8 @@ menuconfig ARCH_EXYNOS > select S5P_DEV_MFC > select SRAM > select MFD_SYSCON > + select SOC_SAMSUNG > + select EXYNOS_SROM What about the difference of execution time? The suspend/resume of device may not be called in the same time as previous syscore ops. Does this have any impact? Best regards, Krzysztof