From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Pankaj Dubey <pankaj.dubey@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
linux@arm.linux.org.uk, heiko@sntech.de,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Rob Herring <robh+dt@kernel.org>,
thomas.ab@samsung.com, kgene@kernel.org
Subject: Re: [PATCH 3/5] ARM: EXYNOS: DTS: add SROM device node for exynos4
Date: Wed, 27 May 2015 21:02:23 +0900 [thread overview]
Message-ID: <5565B24F.9060601@samsung.com> (raw)
In-Reply-To: <1430296712-10287-4-git-send-email-pankaj.dubey@samsung.com>
W dniu 29.04.2015 o 17:38, Pankaj Dubey pisze:
> Add SROM device node for exynos4.
Subject prefix: "ARM: dts:"
>
> CC: Rob Herring <robh+dt@kernel.org>
> CC: Mark Rutland <mark.rutland@arm.com>
> CC: Ian Campbell <ijc+devicetree@hellion.org.uk>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> ---
> arch/arm/boot/dts/exynos4.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index 77ea547..48490ea 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -76,6 +76,11 @@
> reg = <0x10000000 0x100>;
> };
>
> + sromc@12570000 {
> + compatible = "samsung,exynos-srom";
> + reg = <0x12570000 0x100>;
There are 5 registers, so size of 0x100 seems to be bigger than needed.
Maybe limit it to actual length?
Best regards,
Krzysztof
next prev parent reply other threads:[~2015-05-27 12:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-29 8:38 [PATCH 0/5] Add support for Exynos SROM Controller driver Pankaj Dubey
2015-04-29 8:38 ` [PATCH 1/5] drivers: soc: add support for exynos SROM driver Pankaj Dubey
2015-05-27 11:52 ` Krzysztof Kozlowski
2015-08-20 11:34 ` Pankaj Dubey
2015-08-21 1:27 ` Krzysztof Kozlowski
2015-04-29 8:38 ` [PATCH 2/5] ARM: EXYNOS: Remove SROM related register settings from mach-exynos Pankaj Dubey
2015-05-27 11:56 ` Krzysztof Kozlowski
2015-08-20 11:36 ` Pankaj Dubey
2015-04-29 8:38 ` [PATCH 3/5] ARM: EXYNOS: DTS: add SROM device node for exynos4 Pankaj Dubey
2015-05-27 12:02 ` Krzysztof Kozlowski [this message]
2015-08-20 11:37 ` Pankaj Dubey
2015-04-29 8:38 ` [PATCH 4/5] ARM: EXYNOS: DTS: add SROM device node for exynos5 Pankaj Dubey
2015-05-27 12:03 ` Krzysztof Kozlowski
2015-04-29 8:38 ` [PATCH 5/5] Documentation: dt-bindings: add exynos-srom binding information Pankaj Dubey
2015-05-27 11:21 ` Krzysztof Kozlowski
2015-08-20 11:39 ` Pankaj Dubey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5565B24F.9060601@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pankaj.dubey@samsung.com \
--cc=robh+dt@kernel.org \
--cc=thomas.ab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox