From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753111AbbE0MtB (ORCPT ); Wed, 27 May 2015 08:49:01 -0400 Received: from mail-bn1bn0100.outbound.protection.outlook.com ([157.56.110.100]:22992 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753056AbbE0Msy (ORCPT ); Wed, 27 May 2015 08:48:54 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; gmail.com; dkim=none (message not signed) header.d=none; Message-ID: <5565B9B7.8080506@xilinx.com> Date: Wed, 27 May 2015 14:33:59 +0200 From: Michal Simek User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Shailendra Verma , Michal Simek , =?windows-1252?Q?S=F6ren_Brinkmann?= , CC: , Greg Kroah-Hartman Subject: Re: [PATCH] char:xilinx_hwicap:buffer_icap - change 1/0 to true/false for bool type variable in function buffer_icap_set_configuration(). References: <1432582863-5012-1-git-send-email-shailendra.capricorn@gmail.com> In-Reply-To: <1432582863-5012-1-git-send-email-shailendra.capricorn@gmail.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21572.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD045;1:CxZ0cbfs7RtQRJd+dmcbpcxbt+U9hEudDxCmjlDTHFaYZAox7sMnGBkogBEz/mmqQE6RdM+se/Xp3Xf8DiPKj2PT3IY/6tWNmZSwdMKXNgQAlR6u2NM7/g2xVHr8F4fpELRpOAsLky8qqjSAL/ZU5nbJxT0pAXwozsRyeGa6GFwDZueLky1pXzEMo/NxQXJZ+drOcS+PCZ59AmrxCyMjN/oXv5gp6Eyzrz5ZfF0/clSVJSPqUUBqU7KxXw/3xbcV2vpEqUOqa3w0cj12Qh5fkg== X-Forefront-Antispam-Report: CIP:149.199.60.100;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(438002)(189002)(24454002)(164054003)(199003)(377454003)(51704005)(479174004)(6806004)(46102003)(36756003)(36386004)(92566002)(33656002)(81156007)(4001350100001)(4001540100001)(59896002)(87936001)(19580395003)(64706001)(77096005)(50466002)(77156002)(62966003)(2950100001)(63266004)(64126003)(50986999)(65816999)(23746002)(76176999)(65956001)(19580405001)(80316001)(83506001)(54356999)(5001830100001)(5001860100001)(189998001)(65806001)(5001770100001)(47776003)(106466001)(5001960100002)(87266999)(86362001)(107986001)(5001870100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1AFFO11HUB005;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;PTR:unknown-60-100.xilinx.com,xapps1.xilinx.com;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11HUB005;2:aejBZEpels1D0JHPgaTVXPGWTz7ZbxAF8xqcxShV3Om8KyaL7QoHTmZs90a6FxUZ;2:Vm2VL2ji2LpZvUZEnMHJ7k3CNmme+JFsZ8b8fmcPr+FQre6msAA5XztxlHGTffBLQacKw+LUZHyIXqyVTiQy4b+KF/voS1gx0ru2NV3XbwFFH5dyOg4z+I4IEgFwyY06jA+ZWcgNmDmulLse+olnWTC2tUsH40WPSOvmhRDkcoTGmaxEq4PR/b5poMs6a0cKFKesTW1LgvOV0MHjYHx7rLsdektfgYLX9nnMhHqsILjDlXwO6UJCcA8/6DAyOWvy;6:2696cZsQSv9ulRbd4HMQAw8tSdVZG7T+04zcy5JtM+4/TnO8gyU5vilTFSSswrOPHLnIP4QJEmCkbstuv9uI4H1cBDQ9/aQCVthnDyKuGaDDDGUshmQsmuDx8WKzBqI7efSw/Zd8K1sfQvP8AmggWIoV4uaekL701MJZ31EZK7o6PI5gv9x5lr+A6V+PicMpo9Pe3q5bf6VRo3KQhF2VSx1uJa2Oa/IETSqoma95ej3u7+vkjFzWshb85L+Wp6c6tzsq8Tt77RlNR0VLFF/fYRHm9GFTgEuotJmXznjvnHHiDsGB5WJOG2h7itDLXmoD9m81BRfg/RNt1ry86RGiZ2xeBeQAC6c0WoyUUwsHG76irJlOAA99+PxG8b82e4462/8yKcxBFyJ7J2AZv+XBgUw9Ql8dVp3j2R4qbC/tw6VLNyWRdLV0evfI2iyn1cI8tWGI3Zrm0C+AQn0tPLxU+oVyC3t3ub0e2KS/Q1Xu6kNFYMqRz4S8O4iWGF8gLV81 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN1AFFO11HUB005; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:BN1AFFO11HUB005;BCL:0;PCL:0;RULEID:;SRVR:BN1AFFO11HUB005; X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11HUB005;3:ZCT4NVYdruP47mHx9bGwGJF8a7fZoiQKycKLgfic5bA/1G+/tBopXtaYtFuu7pgbMV1z4CcruqzCNY2oU/QR8hO+GK1PDMGyEl6gXFdieDLjuwUtXrVLij8I/Vaggvf2GlR9KRFkWFKYwqVPe35I114TxlhTMb74eOXMhbTrRuVZQ0baMRPgJopR00wH0NZ616XpH9hk537L/BLCxoYO5lAzyAlBoqZydizl3kM9CaTz8kJXHsCurxioKHGr3d3wKH/btMCZ45TqJG5enD7JXvTiJxOwFhcJvuyIvVUOoSX4L8lZYSZkhSJSvA9AXW60 X-Forefront-PRVS: 05891FB07F X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN1AFFO11HUB005;9:IsOAQH694iPvMA+oeQuCI3XUA3QFvzEDucfU?= =?Windows-1252?Q?D6eHeaTFHqomzc12NVUnwGlyjZ3Fv7eoFZANfNpsYOF6i2fR4586CLMg?= =?Windows-1252?Q?e2xikbmzff8nN8mUAJjY0v7GX2Ssnpm2Odag/PyujmJY/S1fPhYGcwla?= =?Windows-1252?Q?Jcs5jVnrdcbln58J09biciOGBg35sfh9o9YQVBPPxyoHO0l2Y+avNxkC?= =?Windows-1252?Q?1sD685WyeR/UMKtgLo/+FZxx1w2++zF17a8cV7Ew3Gy1Bs0NhbL3VAiA?= =?Windows-1252?Q?RbBPNdqhdUzyPt49pD+5+rCsKy+fiA4AEM1BuMUfxrtOc1zM9zZRj1do?= =?Windows-1252?Q?egGLGkBN9ILzD0degZzqdk/JdRw7T+9jS+KhIpoq5Ep68OQyll5NkR2/?= =?Windows-1252?Q?DKEULXtw7EAtlDXOdt9EgT+4t2WazErSjacea4LggbYbavbw07yvBOAE?= =?Windows-1252?Q?YodSEBcoKgAs5zVh50GD7YRqARHccp/GcDkd/yX7lLPxiD40F+/1PJys?= =?Windows-1252?Q?aQ4jN+VwGwici3XvfiQQrkbVNYrePoNjxdYpNEqgUxJr1Fr5CuEllbhj?= =?Windows-1252?Q?k/akMTANN1pxooS7FbOhCCntHXzFErFFyE67C18Me39plTVmSKnfgE6R?= =?Windows-1252?Q?KK7IhBpzb3/m+oWZw+NHl1FGVSDQ0Yl4P2V3rrRvDf1OhD7y4AzCy57p?= =?Windows-1252?Q?1sTr+QneuDLU7Ge6FtkoBsstal93ftGW4w0K9SUypkd+QXIEkAxAQ3/C?= =?Windows-1252?Q?WQ4jEZbQuZOu/GOHSU6bmZZarKPPyyxnbS907ZEg0ps9GNo10t8G7gDg?= =?Windows-1252?Q?hMLxxM7SgI1N2UfE0I623/MC5G9FON58dPKsTRAKGDtVE0L5C5xun925?= =?Windows-1252?Q?ykUBfwPdHTjWyrrDtFIl3oeeY23YkuR7t80Rv9rYrGwjpFvWEzYShXG2?= =?Windows-1252?Q?yGRQAkPBW6Iii64xo79l2ZRigpA9nRJZekTeNRrAmv1/pcXQrXRvwMMK?= =?Windows-1252?Q?JTN2dAFtlPnFHborrWa/kyYi0Qf8/n3whdg51xnnXv5S5pvrSaYndPJt?= =?Windows-1252?Q?kVVARpx7/3RnNTqmGjTSo4Pja8Lt1ZldJ5H/+mQw2Obez7fQCvQagMT3?= =?Windows-1252?Q?G0XPtPJBSoEdSflVAxi2ebcUFtKthit5LP7vHcnkSGYoBrG1SrAMbpn1?= =?Windows-1252?Q?oyXOyrBJswDZbda9hPbdMjdINwNGzKtRcgC/iyxb/v175C9E0hAOKTxI?= =?Windows-1252?Q?5MyrpROsxAH3Bk+78fMAEyvwVVjnOsMu9FPd+tyJO4BiAle0CP1ceNC7?= =?Windows-1252?Q?1G3RvTMdml91hkY4qXLm60WzsJASvscPc+F3dJK1YQLk4x5f2y0UNk04?= =?Windows-1252?Q?ih/Ka6it5di5D75jppcdLvnw36yyjRm5T6YMCjk2cxQLqvcAHLsVKKs?= =?Windows-1252?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11HUB005;3:gXRHVBVnjPVEJg9imkvtmXbMq+TBKqeC5u9wUGsA46LzNjaXm8HJ62tn0vHKSGXbrIn88j45AGzZ7SNmwnxcsjzJiQkfH/Y/vsKAepe6CU6EZq6UD33B3tw3hQDvJbBx8IX6OHA8XHvnXasE70AHVQ==;10:Ig1e1ZR7ROwKOfYPt8nOVT1XjMgF8hJFG7XDHco59ejKfe6uFdsLAYF4aeeTrg3xJPfn7uo1R8d6mIBz9qRN+euEu4ZEOXbizunS0zV7xMU= X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2015 12:34:07.2683 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1AFFO11HUB005 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +Greg On 05/25/2015 09:41 PM, Shailendra Verma wrote: > The variable dirty is bool type. Hence assign the variable with > bool value true/false instead of 1/0. > > Signed-off-by: Shailendra Verma > --- > drivers/char/xilinx_hwicap/buffer_icap.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/char/xilinx_hwicap/buffer_icap.c b/drivers/char/xilinx_hwicap/buffer_icap.c > index 05d8977..53c3882 100644 > --- a/drivers/char/xilinx_hwicap/buffer_icap.c > +++ b/drivers/char/xilinx_hwicap/buffer_icap.c > @@ -270,7 +270,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data, > int status; > s32 buffer_count = 0; > s32 num_writes = 0; > - bool dirty = 0; > + bool dirty = false; > u32 i; > void __iomem *base_address = drvdata->base_address; > > @@ -279,7 +279,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data, > > /* Copy data to bram */ > buffer_icap_set_bram(base_address, buffer_count, data[i]); > - dirty = 1; > + dirty = true; > > if (buffer_count < XHI_MAX_BUFFER_INTS - 1) { > buffer_count++; > @@ -299,7 +299,7 @@ int buffer_icap_set_configuration(struct hwicap_drvdata *drvdata, u32 *data, > > buffer_count = 0; > num_writes++; > - dirty = 0; > + dirty = false; > } > > /* Write unwritten data to ICAP */ > Tested-by: Michal Simek Thanks, Michal