From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752488AbbE0Mnv (ORCPT ); Wed, 27 May 2015 08:43:51 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:36595 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752214AbbE0Mnr (ORCPT ); Wed, 27 May 2015 08:43:47 -0400 Message-ID: <5565BC02.7010101@linaro.org> Date: Wed, 27 May 2015 14:43:46 +0200 From: Daniel Lezcano User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: d.eppel@samsung.com CC: tglx@linutronix.de, kgene@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, kyungmin.park@samsung.com, k.kozlowski@samsung.com, m.jabrzyk@samsung.com, stable@vger.kernel.org Subject: Re: [PATCH v2] clocksource: exynos_mct: fix for sleeping in atomic ctx handling cpu hotplug notif. References: <1426151496-5509-1-git-send-email-d.eppel@samsung.com> <55509013.3040901@linaro.org> <1432567470.13951.2.camel@AMDC1552.digital.local> In-Reply-To: <1432567470.13951.2.camel@AMDC1552.digital.local> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/25/2015 05:24 PM, Damian Eppel wrote: > On Mon, 2015-05-11 at 13:18 +0200, Daniel Lezcano wrote: [ ... ] >> The code sounds very complex for what it is supposed to do. >> >> Perhaps I am missing something but you have more or less the same >> functionality than the smp_twd timers and these ones don't look so complex. >> >> Could you please look at the smp_twd.c implementation ? > > Hi Daniel, > > exynos_mct.c driver looks more complex as it supports two types of timer > interrupts - private and shared peripheral interrupts (for exynos4412 > and exynos4210 accordingly). In smp_twd.c driver I can see only PPI type > of irqs supported. SPI and PPI irqs differs slightly in setup - thus two > different code paths appears in the driver in initialization and > handling of CPU notifications. The fix is addressing issue that appears > only for hardware using SPI irqs so it is hard to compare it to > smp_twd.c. > BTW, If we remove support for SPI irqs in exynos_mct.c it would look > almost the same as smp_twd.c. Ok, thanks. I will have a deeper look this afternoon. -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog