From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752082AbbE0R2x (ORCPT ); Wed, 27 May 2015 13:28:53 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34901 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751488AbbE0R2v (ORCPT ); Wed, 27 May 2015 13:28:51 -0400 Message-ID: <5565FECE.3000104@suse.de> Date: Wed, 27 May 2015 19:28:46 +0200 From: =?windows-1252?Q?Andreas_F=E4rber?= Organization: SUSE Linux GmbH User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: maitysanchayan@gmail.com, Paul Bolle CC: devicetree@vger.kernel.org, arnd@arndb.de, linux-kernel@vger.kernel.org, stefan@agner.ch, kernel@pengutronix.de, shawn.guo@linaro.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 2/2] soc: Add driver for Freescale Vybrid Platform References: <7df753efff77a96da285f0571f1316512787e83c.1432637313.git.maitysanchayan@gmail.com> <1432711910.27695.223.camel@x220> <20150527130727.GA3374@Sanchayan-Arch.toradex.int> In-Reply-To: <20150527130727.GA3374@Sanchayan-Arch.toradex.int> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Am 27.05.2015 um 15:07 schrieb maitysanchayan@gmail.com: > On 15-05-27 09:31:50, Paul Bolle wrote: >> On Tue, 2015-05-26 at 17:06 +0530, Sanchayan Maity wrote: >>> --- /dev/null >>> +++ b/drivers/soc/fsl/Kconfig >> >>> +config SOC_VF610 >>> + bool "SoC bus device for the Freescale Vybrid platform" >>> + select SOC_BUS >>> + help >>> + Include support for the SoC bus on the Freescale Vybrid platform >>> + providing some sysfs information about the module variant. >>> \ No newline at end of file [...] >>> --- /dev/null >>> +++ b/drivers/soc/fsl/Makefile >> >>> +obj-$(CONFIG_SOC_VF610) += soc-vf610.o >> >>> --- /dev/null >>> +++ b/drivers/soc/fsl/soc-vf610.c >> >>> +MODULE_DEVICE_TABLE(of, vf610_soc_bus_match); >> >>> +module_platform_driver(vf610_soc_driver); >> >> (The series starting at https://lkml.org/lkml/2015/5/10/131 would allow >> to use builtin_platform_driver() for built-in only code.) [...] >>> +MODULE_DESCRIPTION("Freescale VF610 SoC bus driver"); >>> +MODULE_LICENSE("GPL v2"); >> >> I think soc-vf610.o can only be built-in. But its code contains a few >> module specific macros. Was it perhaps intended for SOC_VF610 to be >> tristate? > > I too think that should be built-in. Why? For a generic distro kernel it'd be unfortunate to not allow putting such a driver into an initrd, if needed early, or into the rootfs otherwise. Regards, Andreas > Did not have an intention of making > it tristate, however while using other drivers as references, the perhaps > unneccessary stuff crept in. > > The MODULE_* references can be removed along with the corresponding header > file. However that series has not been merged yet, so I can't use builtin_* > yet? [snip] -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg)