From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752495AbbE1BgY (ORCPT <rfc822;w@1wt.eu>);
	Wed, 27 May 2015 21:36:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53946 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750812AbbE1BgN (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 27 May 2015 21:36:13 -0400
Message-ID: <55667106.9000000@redhat.com>
Date: Wed, 27 May 2015 21:36:06 -0400
From: Rik van Riel <riel@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Julia Lawall <julia.lawall@lip6.fr>, Christoph Hellwig <hch@lst.de>
CC: Jens Axboe <axboe@kernel.dk>, Jeff Moyer <jmoyer@redhat.com>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: fix returnvar.cocci warnings
References: <alpine.DEB.2.02.1505262157340.2027@localhost6.localdomain6>
In-Reply-To: <alpine.DEB.2.02.1505262157340.2027@localhost6.localdomain6>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/26/2015 03:59 PM, Julia Lawall wrote:
> Remove unneeded variable used to store return value.
> 
> Generated by: scripts/coccinelle/misc/returnvar.cocci
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> 
> One could check whether the ret variable was intended to be used for 
> anything.

Which tree is this against?

Linus's latest tree still has this in _submit_bh
(unless git didn't pull the latest updates right):

        if (buffer_meta(bh))
                rw |= REQ_META;
        if (buffer_prio(bh))
                rw |= REQ_PRIO;

        bio_get(bio);
        submit_bio(rw, bio);

        if (bio_flagged(bio, BIO_EOPNOTSUPP))
                ret = -EOPNOTSUPP;

        bio_put(bio);
        return ret;
}

-- 
All rights reversed