From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752060AbbE1CD5 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 27 May 2015 22:03:57 -0400
Received: from szxga01-in.huawei.com ([58.251.152.64]:15784 "EHLO
	szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751395AbbE1CDt (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 27 May 2015 22:03:49 -0400
Message-ID: <55667758.1070206@huawei.com>
Date: Thu, 28 May 2015 10:03:04 +0800
From: "Wangnan (F)" <wangnan0@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
CC: <paulus@samba.org>, <a.p.zijlstra@chello.nl>, <mingo@redhat.com>,
        <acme@kernel.org>, <namhyung@kernel.org>, <jolsa@kernel.org>,
        <dsahern@gmail.com>, <daniel@iogearbox.net>,
        <brendan.d.gregg@gmail.com>, <masami.hiramatsu.pt@hitachi.com>,
        <lizefan@huawei.com>, <linux-kernel@vger.kernel.org>,
        <pi3orama@163.com>
Subject: Re: [RFC PATCH v4 10/29] bpf tools: Collect map definitions from
 'maps' section
References: <1432704004-171454-1-git-send-email-wangnan0@huawei.com> <1432704004-171454-11-git-send-email-wangnan0@huawei.com> <20150528015307.GE20764@Alexeis-MacBook-Pro.local>
In-Reply-To: <20150528015307.GE20764@Alexeis-MacBook-Pro.local>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.111.66.109]
X-CFilter-Loop: Reflected
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 2015/5/28 9:53, Alexei Starovoitov wrote:
> On Wed, May 27, 2015 at 05:19:45AM +0000, Wang Nan wrote:
>> If maps are used by eBPF programs, corresponding object file(s) should
>> contain a section named 'map'. Which contains map definitions. This
>> patch copies the data of the whole section. Map data parsing should be
>> acted just before map loading.
>>
>> Signed-off-by: Wang Nan <wangnan0@huawei.com>
>> ---
> ...
>> +static int
>> +bpf_object__init_maps(struct bpf_object *obj, void *data,
>> +		      size_t size)
>> +{
>> +	if (size == 0) {
>> +		pr_debug("%s doesn't need map definition\n",
>> +			 obj->path);
>> +		return 0;
>> +	}
>> +
>> +	obj->maps_buf = malloc(size);
>> +	if (!obj->maps_buf) {
>> +		pr_warning("malloc maps failed: %s\n", obj->path);
>> +		return -ENOMEM;
>> +	}
>> +
>> +	obj->maps_buf_sz = size;
>> +	memcpy(obj->maps_buf, data, size);
> why copy it? To create maps and apply fixups to instructions
> relo sections are needed anyway, so elf has to be open while
> this section is being processed. So why copy?
>

When creating maps, ELF file has been closed.

I divide libelf info two phases: opening and loading. ELF file is closed
at the end of opening phase. I think some caller need 'opening' phase only.
For example, checking metadata in an eBPF object file. In this case, we 
don't
need create map file descriptors.

Sorry for not cc you.