From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752505AbbE1FTP (ORCPT ); Thu, 28 May 2015 01:19:15 -0400 Received: from cantor2.suse.de ([195.135.220.15]:41920 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751109AbbE1FTK (ORCPT ); Thu, 28 May 2015 01:19:10 -0400 Message-ID: <5566A53C.6020309@suse.cz> Date: Thu, 28 May 2015 13:18:52 +0800 From: Michal Marek User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: David Howells CC: torvalds@linux-foundation.org, aricart@memnix.com, linux-kernel@vger.kernel.org, sedat.dilek@gmail.com, keyrings@linux-nfs.org, rusty@rustcorp.com.au, linux-security-module@vger.kernel.org, james.l.morris@oracle.com, dwmw2@infradead.org Subject: Re: [PATCH 1/3] X.509: Fix certificate gathering again References: <1432084120-7918-1-git-send-email-mmarek@suse.cz> <18832.1432044859.1@warthog.procyon.org.uk> <19779.1432656938@warthog.procyon.org.uk> In-Reply-To: <19779.1432656938@warthog.procyon.org.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dne 27.5.2015 v 00:15 David Howells napsal(a): > Hi Michal, > > Could you have a look at the patch at the end of my branch: > > http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=modsign-pkcs7 > > It changes things from picking up arbitrary *.x509 files dropped in the kernel > source and/or build directory to taking a single named PEM file with all the > additional certs as a string config option. The PEM file can contain multiple > certs simply cat'd together. > > If you're okay with that, it obsoletes these patches of yours. I'm fine with the concept as it indeed solves the problem with the wildcard matching for good. So please drop the patches that I posted. The only issue is that the makefile expressions are a bit hairy. For starters, we already have definitions for $(quote) and $(space) in kbuild. I'll have a closer look at the config_filename macro and try to simplify it somehow. But it's just cosmetics, the patch can be merged as is for now. Michal