From: Jan Kardell <jan.kardell@telliq.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
Vincent Donnefort <vdonnefort@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
oen@telliq.com
Subject: Re: [PATCH v2] rtc: pcf8563 fix: return -EINVAL if we read an invalid time.
Date: Thu, 28 May 2015 08:40:47 +0200 [thread overview]
Message-ID: <5566B86F.7030209@telliq.com> (raw)
In-Reply-To: <20150527185352.GJ2185@piout.net>
Alexandre Belloni skrev:
> Hi,
>
> On 27/05/2015 at 14:48:16 +0200, Jan Kardell wrote :
>> @@ -204,6 +204,7 @@ static int pcf8563_get_datetime(struct i2c_client *client, struct rtc_time *tm)
>> pcf8563->voltage_low = 1;
>> dev_info(&client->dev,
> Aren't dev_err or dev_warn more appropriate? You used dev_err in your
> first patch, what made you change your mind?
Your comment to the first patch. But I interpreted it to broadly.
I'll change it back to dev_err.
>
>> "low voltage detected, date/time is not reliable.\n");
>> + return -EINVAL;
>> }
>>
>> dev_dbg(&client->dev,
next prev parent reply other threads:[~2015-05-28 6:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 12:48 [PATCH v2] rtc: pcf8563 fix: return -EINVAL if we read an invalid time Jan Kardell
2015-05-27 18:53 ` Alexandre Belloni
2015-05-28 6:40 ` Jan Kardell [this message]
2015-05-30 22:16 ` Richard Weinberger
2015-05-30 22:21 ` [rtc-linux] " Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5566B86F.7030209@telliq.com \
--to=jan.kardell@telliq.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oen@telliq.com \
--cc=rtc-linux@googlegroups.com \
--cc=vdonnefort@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox