[PATCH v2] clockevents: timer-stm32: Fix build warning spotted by kbuild test robot

[PATCH v2] clockevents: timer-stm32: Fix build warning spotted by kbuild test robot

[Maxime Coquelin]

This patch fixes below warning spotted by kbuild test robot when building
with ARCH=powerpc:

   drivers/clocksource/timer-stm32.c: In function 'stm32_clockevent_init':
>> drivers/clocksource/timer-stm32.c:140:9: warning: large integer implicitly truncated to unsigned type [-Woverflow]
     writel_relaxed(~0UL, data->base + TIM_ARR);

The fix consists in using 0U instead of 0UL.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com>
---
v2: Use 0U instead of casting to u32.
---
 drivers/clocksource/timer-stm32.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clocksource/timer-stm32.c b/drivers/clocksource/timer-stm32.c
index fad2e2e..a97e8b5 100644
--- a/drivers/clocksource/timer-stm32.c
+++ b/drivers/clocksource/timer-stm32.c
@@ -137,9 +137,9 @@ static void __init stm32_clockevent_init(struct device_node *np)
 	}
 
 	/* Detect whether the timer is 16 or 32 bits */
-	writel_relaxed(~0UL, data->base + TIM_ARR);
+	writel_relaxed(~0U, data->base + TIM_ARR);
 	max_delta = readl_relaxed(data->base + TIM_ARR);
-	if (max_delta == ~0UL) {
+	if (max_delta == ~0U) {
 		prescaler = 1;
 		bits = 32;
 	} else {
-- 
1.9.1

Re: [PATCH v2] clockevents: timer-stm32: Fix build warning spotted by kbuild test robot

[Daniel Lezcano]

On 05/28/2015 07:05 AM, Maxime Coquelin wrote:
> This patch fixes below warning spotted by kbuild test robot when building
> with ARCH=powerpc:
>
>     drivers/clocksource/timer-stm32.c: In function 'stm32_clockevent_init':
>>> drivers/clocksource/timer-stm32.c:140:9: warning: large integer implicitly truncated to unsigned type [-Woverflow]
>       writel_relaxed(~0UL, data->base + TIM_ARR);
>
> The fix consists in using 0U instead of 0UL.
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> ---
> v2: Use 0U instead of casting to u32.
> ---

Applied, thanks !

   -- Daniel

-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog