From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932127AbbE1IfY (ORCPT ); Thu, 28 May 2015 04:35:24 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:29598 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751525AbbE1IfV (ORCPT ); Thu, 28 May 2015 04:35:21 -0400 Message-ID: <5566D320.50009@huawei.com> Date: Thu, 28 May 2015 16:34:40 +0800 From: "Ouyang Zhaowei (Charles)" User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: David Vrabel , Boris Ostrovsky , Konrad Rzeszutek Wilk CC: , Dingweiping , Yanqiangjun , Subject: Re: [RESEND PATCH] xen: vcpu_info would be reset to wrong place on canceled suspend on PVOPS VM which has multi-cpu References: <55497298.4070307@huawei.com> In-Reply-To: <55497298.4070307@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.30.65] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, It's been a long time, I don't know whether this patch is OK or not. Or does it somewhere need to be improved a little bit? thanks On 2015.5.6 9:47, Ouyang Zhaowei (Charles) wrote: > vcpu_info would be reset to wrong place on canceled suspend on PVOPS VM which has multi-cpu > > The hypervisor continues assuming that vcpu_info is stored in per-cpu data which was set up by xen_vcpu_setup(), > while on canceled suspend, the call to xen_hvm_init_shared_info() will make the guest think that vcpu_info > is in the shared page. This will cause non-boot cpus keep checking a wrong vcpu_info address and can not handle > irqs any more after suspend canceled, for example after we do "xl save -c/restore", PVOPS VM can not be resumed > as the cpus can not finish their irqs. > > > Signed-off-by: Charles Ouyang > Reviewed-by: Boris Ostrovsky > Reviewed-by: David Vrabel > --- > arch/x86/xen/suspend.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/xen/suspend.c b/arch/x86/xen/suspend.c > index d949769..b2bed45 100644 > --- a/arch/x86/xen/suspend.c > +++ b/arch/x86/xen/suspend.c > @@ -32,7 +32,8 @@ static void xen_hvm_post_suspend(int suspend_cancelled) > { > #ifdef CONFIG_XEN_PVHVM > int cpu; > - xen_hvm_init_shared_info(); > + if (!suspend_cancelled) > + xen_hvm_init_shared_info(); > xen_callback_vector(); > xen_unplug_emulated_devices(); > if (xen_feature(XENFEAT_hvm_safe_pvclock)) { > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > > . >