From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753272AbbE1JTn (ORCPT ); Thu, 28 May 2015 05:19:43 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:61068 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751529AbbE1JTk (ORCPT ); Thu, 28 May 2015 05:19:40 -0400 X-AuditID: cbfec7f5-f794b6d000001495-ec-5566dda92a5f Message-id: <5566DDA6.1080508@samsung.com> Date: Thu, 28 May 2015 18:19:34 +0900 From: Krzysztof Kozlowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-version: 1.0 To: Anand Moon , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Kukjin Kim Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dts: odroidxu3: Enable USB3 regulators References: <1432803494-3516-1-git-send-email-linux.amoon@gmail.com> In-reply-to: <1432803494-3516-1-git-send-email-linux.amoon@gmail.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupkkeLIzCtJLcpLzFFi42I5/e/4Zd2Vd9NCDTatULOYf+Qcq0X/m4Ws FuderWS0eP3C0KL/8Wtmi02Pr7FaXN41h81ixvl9TBbrNt5it7h9mddi6fWLTBYTpq9lsWjd e4Tdgddjzbw1jB4tzT1sHpf7epk8ds66y+6xcvkXNo9NqzrZPDYvqffo27KK0ePzJrkAzigu m5TUnMyy1CJ9uwSujKNfv7AWzBaouPvlAmsD4zzeLkZODgkBE4lVr3ayQ9hiEhfurWfrYuTi EBJYyijx++o5dgjnKaPEzwOzmLoYOTh4BbQkdl7KA2lgEVCVODHtDxOIzSZgLLF5+RI2EFtU IELi7eWTYHFeAUGJH5PvsYDMERFYyyQxde1qMIdZoJ1R4s7b2WAdwgIOEq++XwQ7Q0jAReLI kgksIMs4BVwlHj3WATGZBfQk7l/UAqlgFpCX2LzmLfMERoFZSFbMQqiahaRqASPzKkbR1NLk guKk9FwjveLE3OLSvHS95PzcTYyQCPq6g3HpMatDjAIcjEo8vApz0kKFWBPLiitzDzFKcDAr ifCGbgIK8aYkVlalFuXHF5XmpBYfYpTmYFES5525632IkEB6YklqdmpqQWoRTJaJg1OqgfGy xsVDVVNvbrovsCbwirFmh2OMxOO+rWcnm2lcizzawLb9RKfEGvVdK5xO6FQWTC3aX2J53mof d2jL+T/Wsh38Mgtcljev/hHbN7d6i2StfGOs9xv9o7nXs//rvVjT7Hc+cKlc5W+uw1U8b+9q N4bOmflf/0Uur1LcmeSkLy7+1y+6b+uZqKzEUpyRaKjFXFScCADxdajCnAIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28.05.2015 17:58, Anand Moon wrote: > Enable regulator for usbdrd3_0 and usbdrd3_1 >>>From the schematic pin diagram USB3_0 and USB3_1 > is regulated by LDO9 and LD011. Please reformat statement above to proper sentence(s) without ">" before "From". > > Fix the boot message of failed. > [ 3.503539] exynos-dwc3 usb@12000000: Looking up vdd33-supply from device tree > [ 3.503556] exynos-dwc3 usb@12000000: Looking up vdd33-supply property in node /usb@12000000 failed > [ 3.503568] usb@12000000 supply vdd33 not found, using dummy regulator > [ 3.509154] exynos-dwc3 usb@12000000: Looking up vdd10-supply from device tree > [ 3.509170] exynos-dwc3 usb@12000000: Looking up vdd10-supply property in node /usb@12000000 failed > [ 3.509181] usb@12000000 supply vdd10 not found, using dummy regulator > [ 3.917548] exynos-dwc3 usb@12400000: Looking up vdd33-supply from device tree > [ 3.917565] exynos-dwc3 usb@12400000: Looking up vdd33-supply property in node /usb@12400000 failed > [ 3.917578] usb@12400000 supply vdd33 not found, using dummy regulator > [ 3.922731] exynos-dwc3 usb@12400000: Looking up vdd10-supply from device tree > [ 3.922747] exynos-dwc3 usb@12400000: Looking up vdd10-supply property in node /usb@12400000 failed > > --- > This patch is based on Krzysztof github branch work-next/odroid-xu3-s2mps11-irq > --- I mentioned this already on previous postings. Let's make an exercise. Please: 1. Save your email as mbox format (from mailer). 2. Go to a GIT repo with kernel and checkout base branch. 3. git am 0001-the-name-of-file.mbox 4. git show Do you see the signed-off-by in commit? The patch itself looks good, thanks for fixing this. Just please fix the issues with commit message. By the way: 1. The always-on from LDO9 could be probably removed if the ehci-exynos driver had regulator consumer implemented. 2. The Documentation/devicetree/bindings/usb/exynos-usb.txt (or dwc.txt) should proably mention the vdd-supply property. Best regards, Krzysztof