* [PATCH] xenbus: avoid uninitialized variable warning
@ 2015-05-28 8:26 Jan Beulich
2015-05-28 10:37 ` David Vrabel
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2015-05-28 8:26 UTC (permalink / raw)
To: David Vrabel, Boris Ostrovsky, Konrad Rzeszutek Wilk; +Cc: linux-kernel
Older compilers don't recognize that "v" can't be used uninitialized;
other code using hvm_get_parameter() zeros the value too, so follow
suit here.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
drivers/xen/xenbus/xenbus_probe.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
--- 4.1-rc5/drivers/xen/xenbus/xenbus_probe.c
+++ 4.1-rc5-xen-unint-warnings/drivers/xen/xenbus/xenbus_probe.c
@@ -742,7 +742,7 @@ static int xenbus_resume_cb(struct notif
int err = 0;
if (xen_hvm_domain()) {
- uint64_t v;
+ uint64_t v = 0;
err = hvm_get_parameter(HVM_PARAM_STORE_EVTCHN, &v);
if (!err && v)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] xenbus: avoid uninitialized variable warning
2015-05-28 8:26 [PATCH] xenbus: avoid uninitialized variable warning Jan Beulich
@ 2015-05-28 10:37 ` David Vrabel
0 siblings, 0 replies; 2+ messages in thread
From: David Vrabel @ 2015-05-28 10:37 UTC (permalink / raw)
To: Jan Beulich, Boris Ostrovsky, Konrad Rzeszutek Wilk; +Cc: linux-kernel
On 28/05/15 09:26, Jan Beulich wrote:
> Older compilers don't recognize that "v" can't be used uninitialized;
> other code using hvm_get_parameter() zeros the value too, so follow
> suit here.
Applied to for-linus-4.2, thanks.
David
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-28 10:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-28 8:26 [PATCH] xenbus: avoid uninitialized variable warning Jan Beulich
2015-05-28 10:37 ` David Vrabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox