From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753876AbbE1LIP (ORCPT <rfc822;w@1wt.eu>);
	Thu, 28 May 2015 07:08:15 -0400
Received: from smtp.citrix.com ([66.165.176.89]:2294 "EHLO SMTP.CITRIX.COM"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753419AbbE1LIH (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 28 May 2015 07:08:07 -0400
X-IronPort-AV: E=Sophos;i="5.13,512,1427760000"; 
   d="scan'208";a="266722208"
Message-ID: <5566F6FE.30607@citrix.com>
Date: Thu, 28 May 2015 12:07:42 +0100
From: David Vrabel <david.vrabel@citrix.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0
MIME-Version: 1.0
To: "Ouyang Zhaowei (Charles)" <ouyangzhaowei@huawei.com>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
CC: <linux-kernel@vger.kernel.org>, Dingweiping <weiping.ding@huawei.com>,
        Yanqiangjun <yanqiangjun@huawei.com>, <jinjian@huawei.com>
Subject: Re: [RESEND PATCH] xen: vcpu_info would be reset to wrong place on
 canceled suspend on PVOPS VM which has multi-cpu
References: <55497298.4070307@huawei.com>
In-Reply-To: <55497298.4070307@huawei.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-DLP: MIA1
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/05/15 02:47, Ouyang Zhaowei (Charles) wrote:
> vcpu_info would be reset to wrong place on canceled suspend on PVOPS VM which has multi-cpu
> 
> The hypervisor continues assuming that vcpu_info is stored in per-cpu data which was set up by xen_vcpu_setup(),
> while on canceled suspend, the call to xen_hvm_init_shared_info() will make the guest think that vcpu_info
> is in the shared page. This will cause non-boot cpus keep checking a wrong vcpu_info address and can not handle
> irqs any more after suspend canceled, for example after we do "xl save -c/restore", PVOPS VM can not be resumed
> as the cpus can not finish their irqs.
> 
> 
> Signed-off-by: Charles Ouyang <ouyangzhaowei@huawei.com>
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Reviewed-by: David Vrabel <david.vrabel@citrix.com>

1. I don't think I offered a reviewed-by tag for this patch
2. You did not Cc the xen-devel mailing list on this patch.
3. The patch is white-space damaged.
4. The commit message has lines longer than ~72 chars.

But I've applied this to for-linus-4.1b anyway, thanks.

David