From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753847AbbE1Ndj (ORCPT ); Thu, 28 May 2015 09:33:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32783 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751466AbbE1Ndc (ORCPT ); Thu, 28 May 2015 09:33:32 -0400 Message-ID: <55671925.8080305@redhat.com> Date: Thu, 28 May 2015 09:33:25 -0400 From: Rik van Riel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Srikar Dronamraju CC: linux-kernel@vger.kernel.org, mgorman@suse.de, jhladky@redhat.com, peterz@infradead.org, mingo@kernel.org, dedekind1@gmail.com Subject: Re: [PATCH 2/2] numa,sched: only consider less busy nodes as numa balancing destination References: <1432753468-7785-1-git-send-email-riel@redhat.com> <1432753468-7785-3-git-send-email-riel@redhat.com> <20150528110741.GA3370@linux.vnet.ibm.com> In-Reply-To: <20150528110741.GA3370@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/28/2015 07:07 AM, Srikar Dronamraju wrote: > * riel@redhat.com [2015-05-27 15:04:28]: > >> >> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c >> index c47bf0dffb34..f655f2ad155d 100644 >> --- a/kernel/sched/fair.c >> +++ b/kernel/sched/fair.c >> @@ -1398,6 +1398,30 @@ static void task_numa_find_cpu(struct task_numa_env *env, >> } >> } >> >> +/* Only move tasks to a NUMA node less busy than the current node. */ >> +static bool numa_has_capacity(struct task_numa_env *env) >> +{ >> + struct numa_stats *src = &env->src_stats; >> + struct numa_stats *dst = &env->dst_stats; >> + >> + if (src->has_free_capacity && !dst->has_free_capacity) >> + return false; >> + >> + /* >> + * Only consider a task move if the source has a higher destination >> + * than the destination, corrected for CPU capacity on each node. > > In the above comment, did you mean source has higher load than the > destination? Uh yes, indeed. Thanks for spotting that. Peter, do you want me to send a v2 with the typo fixed, or is it easier for you to fix up the typo before committing? -- All rights reversed