From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754128AbbE1OAO (ORCPT ); Thu, 28 May 2015 10:00:14 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:36796 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753922AbbE1N76 (ORCPT ); Thu, 28 May 2015 09:59:58 -0400 Message-ID: <55671F5D.6060807@gmail.com> Date: Thu, 28 May 2015 15:59:57 +0200 From: Quentin Lambert User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Takashi Iwai CC: Johannes Berg , Jaroslav Kysela , linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups References: <1432817307-28380-1-git-send-email-lambert.quentin@gmail.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/05/2015 15:52, Takashi Iwai wrote: > At Thu, 28 May 2015 14:48:27 +0200, > Quentin Lambert wrote: >> You should use dev_groups instead of the dev_attrs field of struct >> bus_type. This converts the MDIO bus code to use the correct field. >> >> These modifications were made using Coccinelle. >> >> Signed-off-by: Quentin Lambert > What's wrong with dev_attrs? > (Not offending, I'm just curious where the preference for dev_groups > is referred...) This patch is based on commit 4192c74940e23da727eb02b7b4ee779dde2f670, its message indicates that dev_attrs is going away. Quentin