From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753922AbbE1OII (ORCPT ); Thu, 28 May 2015 10:08:08 -0400 Received: from mail-la0-f46.google.com ([209.85.215.46]:34200 "EHLO mail-la0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753455AbbE1OH6 (ORCPT ); Thu, 28 May 2015 10:07:58 -0400 Message-ID: <55672139.1050306@cogentembedded.com> Date: Thu, 28 May 2015 17:07:53 +0300 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Wang Long , davem@davemloft.net, netdev@vger.kernel.org CC: linux-kernel@vger.kernel.org, peifeiyue@huawei.com, wanglong@laoqinren.net Subject: Re: [PATCH] netevent: remove automatic variable in register_netevent_notifier() References: <1432807250-223365-1-git-send-email-long.wanglong@huawei.com> In-Reply-To: <1432807250-223365-1-git-send-email-long.wanglong@huawei.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 5/28/2015 1:00 PM, Wang Long wrote: > Remove automatic variable 'err' in register_netevent_notifier() and > return the return value of atomic_notifier_chain_register() directly. s/return value/result/, in order to avoid tautology. > Signed-off-by: Wang Long [...] WBR, Sergei