From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751387AbbE1POr (ORCPT ); Thu, 28 May 2015 11:14:47 -0400 Received: from mail-bn1on0059.outbound.protection.outlook.com ([157.56.110.59]:46976 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751556AbbE1POi (ORCPT ); Thu, 28 May 2015 11:14:38 -0400 Authentication-Results: spf=fail (sender IP is 66.35.236.236) smtp.mailfrom=opensource.altera.com; gmail.com; dkim=none (message not signed) header.d=none; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=dinguyen@opensource.altera.com; Message-ID: <55672F32.3050506@opensource.altera.com> Date: Thu, 28 May 2015 10:07:30 -0500 From: Dinh Nguyen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: atull CC: Rob Herring , Pavel Machek , "Arnd Bergmann" , Steffen Trumtrar , Pawel Moll , Mark Rutland , "Ian Campbell" , Kumar Gala , , , Russell King , , "Delicious Quinoq" Subject: Re: [PATCH v4 1/2] ARM: socfpga: support suspend to ram References: <1432317735-29413-1-git-send-email-atull@opensource.altera.com> <1432317735-29413-2-git-send-email-atull@opensource.altera.com> <556479C9.5070208@opensource.altera.com> In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: BN1PR02CA0011.namprd02.prod.outlook.com (10.141.56.11) To BLUPR03MB1362.namprd03.prod.outlook.com (25.163.80.28) X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1362;2:Ah2v3AR72BJookTvcLz3SwBG5dIrL8CZuVRmU2iq6lfH66Cb/1fbfaD/aDzYOSDF;2:sbsbYOp1c7NGL4sF28vdOsD3IEtsg++xKHAzktiWY1Es59zjSEQtcMg/NbP9E+qVQUIlIyA32xBqTjzWtFY7Oy2TrUtt/Ncc95wJabuys94us8/DhYdJjpVPt84NQe811ZUDK8CpmFdNGw2UXByi9g==;6:o5kVl46ADuoEokZUIafl53BSL2tbN7w8Gle0H4EB5I9ecZPcQ3QqCpfJHyfDKuXKP4X4UnqjwvhEdZKGyPuR5DRWk8WRw5Ixqj9aeQm5N4QBZqD7zc2MNnRzQ6rq+0H8sCAKA0fJXG2iLw/w1h6xYg==;3:qRRCmKqwLk1XckKpbkHCKjMEFvFZYEkdq/7at7TZp+hB3iVDSDiZIKq8wiH74yE2rsbmf+02Ui/dPaKk8xF39JUgj2Gr/pvMHlFNjZ5Rw6Z4zDTxYoksNAGeint/v9Ve2URSpCmyegjcvtjNMSwDC232dXLiZxn9xolE7YeBskN2qmqdHs7krm+5MpiC4rC2n/I/m977f6bPzvfIJaP4txbvQW07gLhFhLJ7NwYAv+5jbzBVJHio+fCxKA4J+0Tcl+EcMGHisMq9INCIiATJqyU1lc4fivCJZwgBcDXbKSAs4VxIJdIC3RVG7r1YBC+r X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1362;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1495;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1381; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:;UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:BLUPR03MB1362;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1362;BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:BN3PR03MB1495;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1495; X-Forefront-PRVS: 0590BBCCBC X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(189002)(479174004)(24454002)(51704005)(199003)(377454003)(64706001)(2950100001)(50986999)(189998001)(106356001)(81156007)(33656002)(4001540100001)(68736005)(5001860100001)(77096005)(76176999)(5001830100001)(83506001)(93886004)(47776003)(101416001)(4001350100001)(40100003)(97736004)(86362001)(80316001)(77156002)(59896002)(23746002)(66066001)(87976001)(62966003)(50466002)(105586002)(122386002)(19580395003)(5001920100001)(64126003)(65816999)(65956001)(65806001)(5001960100002)(110136002)(54356999)(87266999)(42186005)(19580405001)(92566002)(46102003)(99136001)(4001450100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR03MB1362;H:[137.57.160.210];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:0;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?Windows-1252?Q?1;BLUPR03MB1362;9:YDJQwOF/pwER0eWonrbuK8pN8eQn/cS7FQN47c?= =?Windows-1252?Q?ngvPghk8vbWzj1//9zeAsFIzlA/+8fva0COx/vmxxUSVy+LzCKbD0Vjj?= =?Windows-1252?Q?0z09T/MnY2JlizlRZodvbY/bDSsf0iiN/zKzVM500B3o/BmgcaTHt25x?= =?Windows-1252?Q?Tqcufhgr4H7qXZg/+6ecTYrBfpf13l5PNDNdjzGLu1Mk5qs2iSCKjKdn?= =?Windows-1252?Q?XUV+5u38LZLUtTzL0nZ2nPdS+vF8IYc0vmdcdhEenQwVKQRmWBFl+1TW?= =?Windows-1252?Q?P3TSLFWt0jPxWakhCH+3RjmYWSGVbFX3PwyUbp24QilPazeORRDuEU8E?= =?Windows-1252?Q?zFoep/r2V14n1sDxpfHVSCFoPCHCN6AQ5OUbDThLtXJTOoTzgl3KUGS9?= =?Windows-1252?Q?4zkrxTvT/ISz0Aft423ol4FoHQQIbYy0eJOb6FUl3spTkbbSoCYToMr8?= =?Windows-1252?Q?pPvYDWRfXZsLpNxyf4ir9TiaJzOQNeVNT2uvRHYYNrob2hqbgXcJzjqP?= =?Windows-1252?Q?4ELvTk8miUdHj+RfkxEry5hymRKOBb+/Tlsxb7tadKHQBWLfLuyMxu/u?= =?Windows-1252?Q?8WsVvFrik4AuKPRIcdu28wU7HTL/5IAeyOPl8b0gkxxmt3GnfluP2c2G?= =?Windows-1252?Q?N8vL9frIjbdkvWPdfR/33wexYK4nnV5pP6fiqnUr385281Iqt/s4gqBn?= =?Windows-1252?Q?lHx7hgz/MCOueUAXxvUKX6RCMcw/OGXi1tMe8gCCwNfD8wHVsvrIacnS?= =?Windows-1252?Q?2BHrGDH1O3lnc/w1ZULe3rNs/b++XzeiGCVRTAbI1+TAY2u6KlRxCq3U?= =?Windows-1252?Q?n+rPb6I0qbZW3D0z9bkPOWBONLHa2XExrDh8cu3Ck+r+MCBF7Z74Qx6A?= =?Windows-1252?Q?HsocQvrZG4EG2d1xLde48rEiCsZmwoHBoOh8seOdpWMUv/jGPIHzcOBd?= =?Windows-1252?Q?s3xDQcMkkUns9U47HBjgJE4Ctt7Ct2NpQMEmloW02G4vOiSJPcjyv3iR?= =?Windows-1252?Q?5q9LUBIOFwrF/pBeIUCmWAY3Vn2IrVn8wVo+vH+aX41sKDAf8HZaJc5G?= =?Windows-1252?Q?vY32+wD3D62xO7QtdQYvsSq9A6t1emGC3QeAKVzag5p+ffbaDpghIlSq?= =?Windows-1252?Q?Z/e3hFuSqz+UmYQ4BcHRuea8KcHbbjV9qmWyN2yl3sd+LNtDb+9SHg00?= =?Windows-1252?Q?rL7utcBU/i4Z3YFNs56BmOj6W7xBGpzvQjclVlEPlFYbjC427FAwyC22?= =?Windows-1252?Q?CZNeCxy5zDz45B9dKXgWWn0IS4L+YUJZ0fp9vIBx8jb60dPR5Pphp16W?= =?Windows-1252?Q?20ODWAufn6YPY42eEmhTBZaaP+8Djl2F7R8b9JCCcgwe7cI6GhUv30i9?= =?Windows-1252?Q?TmypuNWqE/KJ1Viks0TCgHnbryVSJ2xtW2pUG/jTlUrk8bSF6LkJLut6?= =?Windows-1252?Q?P1hXIH3sud/KYw2HtU9ZYXOROUMTChvQK6lOpKrzfppP5Yesel7jMQAv?= =?Windows-1252?Q?0T1LnesRKm+QidjLx3HFgUvkVs1bmi3Ug4y62kpHobFdBiiQ=3D=3D?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;BLUPR03MB1362;3:66pUXkz0xqYwNNZBALiBA90mwTg1+o6orzvCSHuKwfu90WQN+Rct8+LP18yIadBeuyQPOFo8C9bw69s6qOd/dunkJMLupEB7wQQCzPCi0pfTwCUDvFhfdow8qRiyuBd5SWvoHw8BVW/TaUfNCce6zw==;10:10VMt942uxPKoC7Iu2waxtfVOHcWed1GWoDcTqerH1nLmAbq8iOez9n04NDWfyJE3AU1mRP8dVNnCIJaOVyH0q9bP/eGSnhljRybKfeYRMw=;6:Ozk3a724DXVpwvEmLLdAMAfjidQzxXWBi/54tzMBp7kalaOLkJYRxL4YQ1u/DcKTUH44APSl+oN0qZvnUu8QtZoWFMX47ni0rTfUvZ/ktQslzkEo0QYALMOlRw19Wal4lqEDGBy3zq74bK8ItqGDUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1362 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BY2FFO11FD027.protection.gbl X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD027;1:sQWjxAUzBpopmayzC2/D0o+l7PyroM50mqhH27XxqVW29f76zZ+xQiaea2LdQKmMEXfGNPuj2FKQhAfpnLfGKK8UTzu/qo+m/Ih7THNibcUldK0w43DN4x68zn5C1GTkvbMo69EkZnyWFFayXTGBUXJ9DK3pKnZXvnSFdatz9pH4XKaQgyoxpSRLk6ufKPrtWCqIG8Z4hGW0Po7gH1LESLnRsxNQtqT3wf6Tjr/WNynxIBboZkFGI2i7hf7z16lTmOcTnKvp95DFw4joyfhdebdiZVyqY7QfNBGp+zGANDLSMzkMeD5pPQsPLSx4q/xH X-Forefront-Antispam-Report: CIP:66.35.236.236;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(339900001)(51704005)(479174004)(24454002)(199003)(377454003)(189002)(4001350100001)(65806001)(65956001)(66066001)(6070500001)(97736004)(81156007)(4001540100001)(40100003)(122386002)(68736005)(62966003)(77156002)(50466002)(110136002)(5001960100002)(189998001)(16796002)(93886004)(46102003)(64126003)(90366008)(64706001)(83506001)(2950100001)(106466001)(77096005)(47776003)(23746002)(5001860100001)(19580405001)(19580395003)(87936001)(80316001)(33656002)(6806004)(50986999)(99136001)(87266999)(92566002)(5001830100001)(5001920100001)(85426001)(54356999)(76176999)(65816999)(86362001)(59896002)(7099028)(4001450100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR03MB1495;H:sj-itexedge04.altera.priv.altera.com;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1495;2:qD0pBgdoM/QQuVD+VQJ/fS7uwVYKC7pGAK7LqPtfsVjf+UZP27cnLRmjAtv9jRkC;2:h7A0P5HJAbRBlNxOA4kPA1ne/8sGoh1CGT/bz2UgCEiZV1qCN8QvsRaxIAS+31DZRRys80d4wzod8KyOknhq4+AbzJbmtKvU9RF+idn7gkYl66me/DqtsBh9SKDafn9AWwNisxqaWOp1HlvrjbAUKPg6ZJ46qxHYiLasMtUmGjkruS3992pjRE1myqAUr2v64WiMkRMXa2BCjiBcxQuyGcRAtDrW0Pef/1xfkRDnxOA=;6:L6ly2ISyR/ytIZHb7ieqJn3f9uz7eSpaMANM6uvIHTGbeYDR8atptiQ/5Q8xztcRcHst3GLax+7/5wcMiKjWkkmnZYvMqD17+VtlTAi7vlDSgYmaNhvx1HS8x82kucGYEgwSrXTwgAvlDF6wWZqWiA==;3:s3msSPhcvTjylIV825rhsfrjsjvWyhqNb30+FS6Jg5zqP2IlyzOpUEYpzYN7t5F8PrfnSi4nMjOnMLtybJj8bpBFkJtVjk+Ts/rPPi18oMzUKA9vpEaW4PLp6RTL3+2EIoPP0Uf1xvFl0iARfj1sgYkwQmPYUKrOi4nrMCUKxvbeJfSHm43Gk9x8XiTrG6N/UEVCEo0SkKbBF2cQZFRlFBx3b/LNer9ZFvjcq4B6z27NvmmryHTL/SewYJr5/MIRHrTgRQtZjydg23/EYjS4Z3PwIRI7zj1LQVDdVVeDnqSIvvmSARCDEVeRWUkaXRl1 X-Forefront-PRVS: 0590BBCCBC X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN3PR03MB1495;9:gNl3Vk3ddYsuIZMwqogy4Bii+Snjlxnig6JlrZ?= =?Windows-1252?Q?bzN+Dz58ANdTtFHiff545TkCRNAcP3B4RTsccxQ6usbxJV91yfnBrwMs?= =?Windows-1252?Q?6v0PhsnavZqk/PMHnbSHnnMC/FTmNNXHClndXk1qglKjro3IAznMjEfp?= =?Windows-1252?Q?Y5txaJtXZR4X0mF1iif8Aw2aueoyom6VV+sWNJ035cIuJvL340fB4tLt?= =?Windows-1252?Q?aaQlhO+8bhk2S9gLrPBcczUlz9p3Y3y0CMnYZ3r56CE0meEbEn4Q80Hl?= =?Windows-1252?Q?I6C4kTal1aI7nMqseLt9LxYdLBcuaDd2JB4AvW/osT7aeoNQT0SFTmx+?= =?Windows-1252?Q?d1yGrr7SjDuFU1VpLnZmSJGfcqKFIhaPKvX/7rrOuHO6108IF+0ROnyD?= =?Windows-1252?Q?nQFnKlpUNL8zYh7HFS++MQ9TrCEFd5N9TiE4CPwp2QM/+UOoT/iBtIEA?= =?Windows-1252?Q?QUVILsfEMckc1DuEukhNvzsNHr/DypnjyNeEvJdtSEmk5oBn4Orh5q5s?= =?Windows-1252?Q?BfSzzp3tnCr65ANTX14dbmFgvjp6FetlizCf/XmqofxGJVbyaLKUFvi3?= =?Windows-1252?Q?gAkeL188VJG8qK/KiG4xHsAEVj3GIS3xrC41lfZmjdaIX74muRgLw+06?= =?Windows-1252?Q?veo42NjRTujG/vMjWzXu//UA6251n7WLezzj4yYCz3PuV+CwGpyZzbYn?= =?Windows-1252?Q?uagYak7TVTLlczpgR3kSjkgNPFpgFLcn+v2hsMDk1OiL5C/4PMr/kTZP?= =?Windows-1252?Q?3H/C7HnYCWKSIrwoyWT5qFDUlo1HvSxCY/96NYszftjRxfNk/66BnZk/?= =?Windows-1252?Q?C+7riamTcGPg683uDhWYukIuGz8MJVdkzgvumIug2gLjSiq5D+3Xc3we?= =?Windows-1252?Q?hGcrvl9w2hBIrx3ThKiy7bjCnvnmoHiZxhhpsluvhMIdaiuOdete3+6a?= =?Windows-1252?Q?N0nJ07RmwWlYn3AEKGmDlVG8MYbhaYL13U6BtR6Cc0/3skAGT9alYXVa?= =?Windows-1252?Q?caV+u7JUid0pZMFxPOFK9DE/J06nQ1zFABUxqivn/KfxP8LLDZ32F4B4?= =?Windows-1252?Q?SKHTUwmfvwPwaVfJ+oX/dwZC0GKVEcDHP5Duq6SIeSZUcqzl7rlvsDbA?= =?Windows-1252?Q?TzrxPH7QeLEJNAZXVn43fFIZgI5o4hb+3PDuwoF76PfNWnoI93Iw+kNH?= =?Windows-1252?Q?EV5jFDbPCMUrzC2JDSerE+1YtBrvX2Kfrs41DCLz7NOgFj3h1A/SVGIq?= =?Windows-1252?Q?Q62iaePhoexB5paLIMyW5sqH4aPNN1pkbMWnap5J6e+KHYLUtE3XrJnh?= =?Windows-1252?Q?zspbppxXSw1u6yIjVdcQxy7Z02swPVZipOibis1pZvyyIl43PZnCeNdE?= =?Windows-1252?Q?gxJgZwiP/thPmS7wor3DmlrfRb37PzwEuAzm9Ko0FADnOUOtBoamYpMj?= =?Windows-1252?Q?XgIw/y58R98NPLEd7RPkdSsgTe+cGdMAusJKeq+dkMrzlo/IotjrKd1Z?= =?Windows-1252?Q?dX5iFSriomlwDqhUmXpNQDE4gF+PKGex1lG0DOwQ1lhNV0fgghqKGLTy?= =?Windows-1252?Q?JDaR+FBcGnXzSYLv8J3YaauTHKe7LlX4bXXlMJEU/66ROV8+beyjAkPQ?= =?Windows-1252?Q?=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1495;3:IV47seBOPJVQd1f1VrGTErkySSWz3Oj2jNl7GLkIJzc08PPs8INyVGeXh8+Gmk0LYKMf6qz8SPYZ3FT7kL6N792o2PKKlkG9oOlLUi+uwkWbciwAt400lDBvF40BhxrPSicioYwSo3sG1stVtsvp5A==;10:Ct9FvH3jYSWyNV3Juv51reblspyfs/EEcLSXVsnMa5bfgj5Elee4NTMfzOaEIgsAe/mgTqq9oOuHyG/NNEABGK3tJC8YgC//UcmsmN8RSpY=;6:hPdqJQLF85T4lfVFUG1U+/Q4tqBbmKFQEXYygu+Z5rxsSBgnY51TmivsgDYilH4OWQpqPstwYw+lvL1uwIXkA+e4UeelqWsYg7KUyX7RsQsOS03WMzBn2RAPlY0WGc66GdZaCP5e5Z6AyXMTYzBw9g== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2015 15:14:27.0818 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.236];Helo=[sj-itexedge04.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1495 X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1381;2:Nx9BIe36PwiFTtb0yS69ByFpLPTLUpVYLf0QF3v8i48PZ9p3sIdiW8qxcfjFIfI1;2:T/CLjMZt+cWRRkLUKuyDL1YVrvgTdcbLM0CUhgYy+YLit04tCuM92zfM9HLbzbN1M3Pd8uZysmfDr9aej+Z4tztbVD46nRHEbMFf0oMvELyzXe2i7iFKCKUa9WB0QDGwiV5UGzX/MBDmt9FEqO1bBkcRM4hDEBXk7GB2ClxxIRm6U0Vuu8A5W3YjfZhtfyJZgMKr50iuKi/muVgX3XD0xpXkoDSiU7E35cQTtBqlRSo=;9:im8ILozTgK/yEg0tssgl7U2NozXU1Ny52CMzvbRFkaDw0Wom4YnwDuT19B0SQYyqVWIWBuboH012EPoprAnnVOKmv4K7NB7UvPvMHcv8RD+0Ncn4a0wxcaUBOM/LYV4JAVwytvRw+SlhI+OoqFvpxw== X-OriginatorOrg: opensource.altera.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/27/2015 03:25 PM, atull wrote: > On Tue, 26 May 2015, Dinh Nguyen wrote: > >> Hi Alan, >> >> On 5/22/15 1:02 PM, Alan Tull wrote: >>> Add code that requests that the sdr controller go into >>> self-refresh mode. This code is run from ocram. >>> >>> This patch assumes that u-boot has already configured sdr: >>> sdr.ctrlcfg.lowpwreq.selfrfshmask = 3 >>> sdr.ctrlcfg.lowpwrtiming.clkdisablecycles = 8 >>> sdr.ctrlcfg.dramtiming4.selfrfshexit = 512 >>> >>> Suspend-to-RAM and EDAC support are mutually exclusive on SOCFPGA >>> platforms. CONFIG_SOCFPGA_SUSPEND enables suspend-to-RAM and >>> prevents selecting CONFIG_EDAC_ALTERA_MC. >>> >>> How to suspend to ram: >>> $ echo enabled > \ >>> /sys/devices/soc/ffc02000.serial0/tty/ttyS0/power/wakeup >>> >>> $ echo -n mem > /sys/power/state >>> >>> Signed-off-by: Alan Tull >>> Cc: Pavel Machek >>> Cc: Arnd Bergmann >>> Cc: Dinh Nguyen >>> Cc: Steffen Trumtrar >>> --- >>> v2: use Generic on-chip SRAM driver to allocate ocram >>> rm fncpy_align since generic allocator handles alignment >>> check __arm_ioremap_exec return code >>> check for NULL pointers >>> add a comment regarding sdram controller configuration >>> v3: fix renamed #define >>> propagate socfpga_setup_ocram_self_refresh error code >>> v4: Kconfig: don't need to select GENERIC_ALLOCATER >>> add CONFIG_SOCFPGA_SUSPEND >>> make s2r and EDAC support mutually exclusive >>> socfpga.c: add sdr_ctl_base_addr >>> return error if ocram not available in device tree >>> update copyright years >>> --- >> >> >> >>> + >>> +static int socfpga_pm_suspend(unsigned long arg) >>> +{ >>> + u32 ret; >>> + >>> + if (!sdr_ctl_base_addr || !socfpga_scu_base_addr) >>> + return -EFAULT; >>> + >>> + ret = socfpga_sdram_self_refresh_in_ocram( >>> + (u32)sdr_ctl_base_addr, (u32)socfpga_scu_base_addr); >>> + >> >> I had a patch that removed socfpga_scu_base_addr from being a global and >> just a local variable in: >> >> f6e14376fb20 ARM: socfpga: use of_iomap to map the SCU >> >> This patch will be in v4.2 and is currently in arm-soc/next or >> at my fork: kernel/git/dinguyen/linux.git socfpga_for_next_arria10 >> >> So you will either need to make socfpga_scu_base_addr global again, or >> you can use the asm instruction to get the SCU base addr. >> >> Sorry about that.. >> >> Dinh >> > > I can't make socfpga_scu_base_addr a global from platsmp.c since that file > may or may not be compiled in. Ah, okay.. > > That leaves me with the option of adding the code that was removed from > socfpga.c back where it was or taking that same code moving it to pm.c > I think you only need the scu base address in socfpga_sdram_self_refresh(), so you can probably just use the single line assembly code to get it there. Dinh