From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Anand Moon <linux.amoon@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
Kukjin Kim <kgene@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: odroidxu3: Enable USB3 regulators
Date: Fri, 29 May 2015 08:57:24 +0900 [thread overview]
Message-ID: <5567AB64.3060502@samsung.com> (raw)
In-Reply-To: <CANAwSgRpXxq2Y72crPd3U8f-DB=nsQ021e5MY0B7GdJrqwv=wA@mail.gmail.com>
On 28.05.2015 19:28, Anand Moon wrote:
> Hi Krzysztof,
>
> I will take care of these issue in the future.
Thanks. I just found that prefix ">" was added by my email client so
never mind about that but still please write proper sentences (ending
with full stop). :)
Best regards,
Krzysztof
>
> -Anand Moon
>
> On 28 May 2015 at 14:49, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
>> On 28.05.2015 17:58, Anand Moon wrote:
>>> Enable regulator for usbdrd3_0 and usbdrd3_1
>>> >From the schematic pin diagram USB3_0 and USB3_1
>>> is regulated by LDO9 and LD011.
>>
>> Please reformat statement above to proper sentence(s) without ">" before
>> "From".
>>
>>>
>>> Fix the boot message of failed.
>>> [ 3.503539] exynos-dwc3 usb@12000000: Looking up vdd33-supply from device tree
>>> [ 3.503556] exynos-dwc3 usb@12000000: Looking up vdd33-supply property in node /usb@12000000 failed
>>> [ 3.503568] usb@12000000 supply vdd33 not found, using dummy regulator
>>> [ 3.509154] exynos-dwc3 usb@12000000: Looking up vdd10-supply from device tree
>>> [ 3.509170] exynos-dwc3 usb@12000000: Looking up vdd10-supply property in node /usb@12000000 failed
>>> [ 3.509181] usb@12000000 supply vdd10 not found, using dummy regulator
>>> [ 3.917548] exynos-dwc3 usb@12400000: Looking up vdd33-supply from device tree
>>> [ 3.917565] exynos-dwc3 usb@12400000: Looking up vdd33-supply property in node /usb@12400000 failed
>>> [ 3.917578] usb@12400000 supply vdd33 not found, using dummy regulator
>>> [ 3.922731] exynos-dwc3 usb@12400000: Looking up vdd10-supply from device tree
>>> [ 3.922747] exynos-dwc3 usb@12400000: Looking up vdd10-supply property in node /usb@12400000 failed
>>>
>>> ---
>>> This patch is based on Krzysztof github branch work-next/odroid-xu3-s2mps11-irq
>>> ---
>>
>> I mentioned this already on previous postings. Let's make an exercise.
>> Please:
>> 1. Save your email as mbox format (from mailer).
>> 2. Go to a GIT repo with kernel and checkout base branch.
>> 3. git am 0001-the-name-of-file.mbox
>> 4. git show
>>
>> Do you see the signed-off-by in commit?
>>
>> The patch itself looks good, thanks for fixing this. Just please fix the
>> issues with commit message.
>>
>> By the way:
>> 1. The always-on from LDO9 could be probably removed if the ehci-exynos
>> driver had regulator consumer implemented.
>> 2. The Documentation/devicetree/bindings/usb/exynos-usb.txt (or dwc.txt)
>> should proably mention the vdd-supply property.
>>
>> Best regards,
>> Krzysztof
>>
>>
>
next prev parent reply other threads:[~2015-05-28 23:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 8:58 [PATCH] ARM: dts: odroidxu3: Enable USB3 regulators Anand Moon
2015-05-28 9:19 ` Krzysztof Kozlowski
2015-05-28 10:28 ` Anand Moon
2015-05-28 23:57 ` Krzysztof Kozlowski [this message]
2015-05-29 13:17 ` Anand Moon
2015-05-30 13:53 ` Anand Moon
2015-05-31 6:24 ` Krzysztof Kozlowski
2015-06-07 2:50 ` Anand Moon
2015-06-07 3:51 ` Krzysztof Kozlowski
2015-05-29 10:37 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5567AB64.3060502@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox