[PATCH] kernel:user_namespace - Fix for typos in comments.

[PATCH] kernel:user_namespace - Fix for typos in comments.

[Shailendra Verma]

Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
---
 kernel/user_namespace.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/kernel/user_namespace.c b/kernel/user_namespace.c
index 4109f83..02a1197 100644
--- a/kernel/user_namespace.c
+++ b/kernel/user_namespace.c
@@ -69,7 +69,7 @@ int create_user_ns(struct cred *new)
 	/*
 	 * Verify that we can not violate the policy of which files
 	 * may be accessed that is specified by the root directory,
-	 * by verifing that the root directory is at the root of the
+	 * by verifying that the root directory is at the root of the
 	 * mount namespace which allows all files to be accessed.
 	 */
 	if (current_chrooted())
@@ -617,7 +617,7 @@ static ssize_t map_write(struct file *file, const char __user *buf,
 	 *
 	 * There is a one time data dependency between reading the
 	 * count of the extents and the values of the extents.  The
-	 * desired behavior is to see the values of the extents that
+	 * desired behaviour is to see the values of the extents that
 	 * were written before the count of the extents.
 	 *
 	 * To achieve this smp_wmb() is used on guarantee the write
@@ -716,7 +716,7 @@ static ssize_t map_write(struct file *file, const char __user *buf,
 		    (next_line != NULL))
 			goto out;
 	}
-	/* Be very certaint the new map actually exists */
+	/* Be very certain the new map actually exists */
 	if (new_map.nr_extents == 0)
 		goto out;
 
@@ -841,7 +841,7 @@ static bool new_idmap_permitted(const struct file *file,
 
 	/* Allow the specified ids if we have the appropriate capability
 	 * (CAP_SETUID or CAP_SETGID) over the parent user namespace.
-	 * And the opener of the id file also had the approprpiate capability.
+	 * And the opener of the id file also had the appropriate capability.
 	 */
 	if (ns_capable(ns->parent, cap_setid) &&
 	    file_ns_capable(file, ns->parent, cap_setid))
-- 
1.7.9.5

Re: [PATCH] kernel:user_namespace - Fix for typos in comments.

[Eric W. Biederman]

Shailendra Verma <shailendra.capricorn@gmail.com> writes:

> Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
> ---
>  kernel/user_namespace.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/user_namespace.c b/kernel/user_namespace.c
> index 4109f83..02a1197 100644
> --- a/kernel/user_namespace.c
> +++ b/kernel/user_namespace.c
> @@ -69,7 +69,7 @@ int create_user_ns(struct cred *new)
>  	/*
>  	 * Verify that we can not violate the policy of which files
>  	 * may be accessed that is specified by the root directory,
> -	 * by verifing that the root directory is at the root of the
> +	 * by verifying that the root directory is at the root of the
>  	 * mount namespace which allows all files to be accessed.
>  	 */
>  	if (current_chrooted())
> @@ -617,7 +617,7 @@ static ssize_t map_write(struct file *file, const char __user *buf,
>  	 *
>  	 * There is a one time data dependency between reading the
>  	 * count of the extents and the values of the extents.  The
> -	 * desired behavior is to see the values of the extents that
                   ^^^^^^^^ In american englic behavior is a correct spelling.
                            I don't know why the brits throw in extraneous letters.
> +	 * desired behaviour is to see the values of the extents that
>  	 * were written before the count of the extents.
>  	 *
>  	 * To achieve this smp_wmb() is used on guarantee the write
> @@ -716,7 +716,7 @@ static ssize_t map_write(struct file *file, const char __user *buf,
>  		    (next_line != NULL))
>  			goto out;
>  	}
> -	/* Be very certaint the new map actually exists */
> +	/* Be very certain the new map actually exists */
>  	if (new_map.nr_extents == 0)
>  		goto out;
>  
> @@ -841,7 +841,7 @@ static bool new_idmap_permitted(const struct file *file,
>  
>  	/* Allow the specified ids if we have the appropriate capability
>  	 * (CAP_SETUID or CAP_SETGID) over the parent user namespace.
> -	 * And the opener of the id file also had the approprpiate capability.
> +	 * And the opener of the id file also had the appropriate capability.
>  	 */
>  	if (ns_capable(ns->parent, cap_setid) &&
>  	    file_ns_capable(file, ns->parent, cap_setid))

Re: [PATCH] kernel:user_namespace - Fix for typos in comments.

[Randy Dunlap]

On 05/23/15 11:02, Eric W. Biederman wrote:
> Shailendra Verma <shailendra.capricorn@gmail.com> writes:
> 
>> Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
>> ---
>>  kernel/user_namespace.c |    8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/kernel/user_namespace.c b/kernel/user_namespace.c
>> index 4109f83..02a1197 100644
>> --- a/kernel/user_namespace.c
>> +++ b/kernel/user_namespace.c
>> @@ -69,7 +69,7 @@ int create_user_ns(struct cred *new)
>>  	/*
>>  	 * Verify that we can not violate the policy of which files
>>  	 * may be accessed that is specified by the root directory,
>> -	 * by verifing that the root directory is at the root of the
>> +	 * by verifying that the root directory is at the root of the
>>  	 * mount namespace which allows all files to be accessed.
>>  	 */
>>  	if (current_chrooted())
>> @@ -617,7 +617,7 @@ static ssize_t map_write(struct file *file, const char __user *buf,
>>  	 *
>>  	 * There is a one time data dependency between reading the
>>  	 * count of the extents and the values of the extents.  The
>> -	 * desired behavior is to see the values of the extents that
>                    ^^^^^^^^ In american englic behavior is a correct spelling.
>                             I don't know why the brits throw in extraneous letters.

and kernel documentation accepts either form of spelling.

>> +	 * desired behaviour is to see the values of the extents that
>>  	 * were written before the count of the extents.
>>  	 *
>>  	 * To achieve this smp_wmb() is used on guarantee the write
>> @@ -716,7 +716,7 @@ static ssize_t map_write(struct file *file, const char __user *buf,
>>  		    (next_line != NULL))
>>  			goto out;
>>  	}
>> -	/* Be very certaint the new map actually exists */
>> +	/* Be very certain the new map actually exists */
>>  	if (new_map.nr_extents == 0)
>>  		goto out;
>>  
>> @@ -841,7 +841,7 @@ static bool new_idmap_permitted(const struct file *file,
>>  
>>  	/* Allow the specified ids if we have the appropriate capability
>>  	 * (CAP_SETUID or CAP_SETGID) over the parent user namespace.
>> -	 * And the opener of the id file also had the approprpiate capability.
>> +	 * And the opener of the id file also had the appropriate capability.
>>  	 */
>>  	if (ns_capable(ns->parent, cap_setid) &&
>>  	    file_ns_capable(file, ns->parent, cap_setid))
> --


-- 
~Randy