From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755169AbbE2A4h (ORCPT ); Thu, 28 May 2015 20:56:37 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:36101 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755155AbbE2A43 (ORCPT ); Thu, 28 May 2015 20:56:29 -0400 Message-ID: <5567B923.9000608@huawei.com> Date: Fri, 29 May 2015 08:56:03 +0800 From: "long.wanglong" User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:16.0) Gecko/20121010 Thunderbird/16.0.1 MIME-Version: 1.0 To: Sergei Shtylyov CC: , , , , Subject: Re: [PATCH] netevent: remove automatic variable in register_netevent_notifier() References: <1432807250-223365-1-git-send-email-long.wanglong@huawei.com> <55672139.1050306@cogentembedded.com> In-Reply-To: <55672139.1050306@cogentembedded.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.88.174] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/5/28 22:07, Sergei Shtylyov wrote: > Hello. > > On 5/28/2015 1:00 PM, Wang Long wrote: > >> Remove automatic variable 'err' in register_netevent_notifier() and >> return the return value of atomic_notifier_chain_register() directly. > > s/return value/result/, in order to avoid tautology. > >> Signed-off-by: Wang Long > [...] > > WBR, Sergei > > > Thanks, I will fix that. Best Regards Wang Long