From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754755AbbE2DPo (ORCPT ); Thu, 28 May 2015 23:15:44 -0400 Received: from mail-bl2on0067.outbound.protection.outlook.com ([65.55.169.67]:40768 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752016AbbE2DPf (ORCPT ); Thu, 28 May 2015 23:15:35 -0400 Authentication-Results: spf=fail (sender IP is 66.35.236.236) smtp.mailfrom=opensource.altera.com; gmail.com; dkim=none (message not signed) header.d=none; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=dinguyen@opensource.altera.com; Message-ID: <5567D9C4.7090903@opensource.altera.com> Date: Thu, 28 May 2015 22:15:16 -0500 From: Dinh Nguyen User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Alan Tull , Rob Herring CC: Pavel Machek , Arnd Bergmann , "Steffen Trumtrar" , Pawel Moll , "Mark Rutland" , Ian Campbell , Kumar Gala , , , Russell King , , Delicious Quinoq Subject: Re: [PATCHv5 1/2] ARM: socfpga: support suspend to ram References: <1432847977-18880-1-git-send-email-atull@opensource.altera.com> <1432847977-18880-2-git-send-email-atull@opensource.altera.com> In-Reply-To: <1432847977-18880-2-git-send-email-atull@opensource.altera.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [99.103.66.154] X-ClientProxiedBy: BLUPR11CA0007.namprd11.prod.outlook.com (10.141.240.17) To CY1PR03MB1374.namprd03.prod.outlook.com (25.163.16.28) X-Microsoft-Exchange-Diagnostics-untrusted: 1;CY1PR03MB1374;2:/uBw1/RkzTp6Z5fE5PLQ8DiyMaJMRVQl6ASnnd7hnZKp/xabKVi+9e29MuUW8RVO;2:TnwqHUv0MlsI8SLB5ciZycrLsohIDWrHE8U9qQRM/y/Z/1CBuFGM8zsrLB9ah3gBOZQ/d8c/EuwIdn8jgX5vjqHMy4r1zpMBZOk9X3KAmFL2EtOCXJaZbtdVHORiO50JnJI7wekE3IOZINUeNsZH0A==;6:loE/aPJf0JBY1HSvZHqd0ip+ZYApC9TPpsVDED+2l5PKvWHeDtGMqBp5jGV5BRWSC7/MK1wjJesZlSvEEAAStnGUluoDl1K/8v5D8uSv11SuynCmPx8S/u3AA0BJmXIJFhRIaCSS5H01SFkFd9wXgA==;3:w+R6wmiEyJOYp3Yu7kzUrfuu4v8u3XEzCaRVqHljYWP5ytssRDtv6dk4CG7kJpG30BgsspslnziRjdLXOvQUh6nSrbp6DpdtMKye64TK3cxUT2NOhubjBPWSBbLuapZdvxqcfN4wgWlFol05IIVopZEiEhLDuLJkB11hD5gzpx4yAc93ApidooE7pvo1k8oo+UjhHHCj7a5upGyywJEh8ggYyrQDjQil0b6QafT+x79uv+m8PSxZjSd0i+80mpzeNrc+yCeWSMF6Wzh+gglnxq8RqzXMCK8tAEE6NA4saobEFYRhm7nSKpDVXhlHIV47 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1374;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR03MB043; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:;UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(520003)(3002001);SRVR:CY1PR03MB1374;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1374;BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:BY2PR03MB043;BCL:0;PCL:0;RULEID:;SRVR:BY2PR03MB043; X-Forefront-PRVS: 059185FE08 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(6009001)(199003)(479174004)(51704005)(24454002)(377454003)(189002)(5001860100001)(42186005)(2950100001)(77096005)(86362001)(65806001)(64706001)(68736005)(77156002)(65816999)(189998001)(50466002)(87266999)(5001960100002)(54356999)(50986999)(76176999)(66066001)(47776003)(46102003)(87976001)(5001830100001)(64126003)(65956001)(62966003)(105586002)(83506001)(106356001)(101416001)(40100003)(59896002)(23746002)(19580405001)(33656002)(4001540100001)(5001770100001)(80316001)(81156007)(97736004)(122386002)(19580395003)(92566002)(4001350100001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR03MB1374;H:Dinhs-MacBook-Pro.local;FPR:;SPF:None;PTR:InfoNoRecords;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?Windows-1252?Q?1;CY1PR03MB1374;9:33EZ655d8U31HH8dsGw2dL0umk3BKf30rAuIG2?= =?Windows-1252?Q?oMG0T+KuHs7x0YSVuc6nG0Q6hUMgCkckfxp/wLeQvPmUbrPzdo3fuIIw?= =?Windows-1252?Q?sGaBA+u6Ikm/rMR5ZWirbs0Q3gMMz9KyMA9e1wWbtNY6mOwsAkXb2F+W?= =?Windows-1252?Q?Q8jtH18sp0X8kj61wrWrOIdRPCPwhpk8pIgxK2BKWWX7d/vTOgxSD1e2?= =?Windows-1252?Q?9htLz3x3bS+FYkqKbjtqd/mUDCK6EZWqGzyPdt4xx530hdsEE8oVT/q/?= =?Windows-1252?Q?uiBXFr68nzvYjjd/lWAgPUMr2MLgP2fJlAymXjUFF4zkM2wIUTwosW4q?= =?Windows-1252?Q?7/2Uglm9YfrtYeQ81s32fB5Gm7PXbLiYTLSa24Ekqux4qLY06wwcXqTk?= =?Windows-1252?Q?ORyPUgawfzk3peae1lhcyrqv2SQWZx57BWZtQ2BBLWYdozoreasJeeix?= =?Windows-1252?Q?zIzL4XZjiqwrliOhruFVOq51J3nG6M3hr6+XsFvqZpgrPIvEnkkHaa6j?= =?Windows-1252?Q?tWFeZr5nlaZrPQNPq4uzisPATr6HcdFr+vWoL8WGKXK7KNXxr+1xCIV8?= =?Windows-1252?Q?dM13NLl3DmRGiByjq6BElYHwbq/aj6ffsk46MUCFkyFhvNx2EDUYVCEo?= =?Windows-1252?Q?HPSDuB25Cu2i3rSd9O6ATgJDnWDU3OXdOLSBFFaMldXMobmvNZPtY0x/?= =?Windows-1252?Q?AtM4hcxHmVW1/DSs20AlMeVjEn4hiVR4gp04kpmw4WF9S/V+MYcE1x8L?= =?Windows-1252?Q?Id4QmCKXAn3Y6fHC5AD4v3Yp8F4byyTvKS9MBCAKKAuhAegdmU3YiOhd?= =?Windows-1252?Q?9oCjwEiL+j8RvuLI9fkcTz7aCjfhbOYIyUMp/CrNLT/lHbFk/Y2PK9ym?= =?Windows-1252?Q?rfqq7buP8DeZCesmL7uJz7SabXk1JLJHBpqX5AdvRrdx/2hMF54TMio9?= =?Windows-1252?Q?6+3p7uQuxOCrZex6FUNZahfpDDIEvLgUf6GV7eB/pX0uT+J1EYkanVFh?= =?Windows-1252?Q?nIRaje6ufBIFjKFf2xwKpE03V7CdcG+55OuDJuGtuKiYakuxur4BOr6P?= =?Windows-1252?Q?9dD2QGe0CpX40EY1Oorz7ptp1dnLBgBpDua2WwoGnl5LXuo944l/sBt8?= =?Windows-1252?Q?HE3DDRa5E735/9fZcIj6TFcu8nesbgfvXHz0Z+IgvEKiiq4Ovzqi5rXH?= =?Windows-1252?Q?TZ20NW6gS/d1PUtr984YR73jmNc1AMuIkGFqz3+9IEpzu1+CcIP8sULp?= =?Windows-1252?Q?RHfOMz/SZJ41CrmRIVrU5BIq5GDWxeApJksMX0fcmZNMvvUa/GhlkVbj?= =?Windows-1252?Q?4mlIAuG51ocuT13hq3o5W38YjCX6zmd0vvUYubQIvkOmMpEGiaDBGn5W?= =?Windows-1252?Q?zv+wFSTomiHMAz7zHj4zSgTVR3RYlzv/0DUmMSLX1CqqdW7eqOF14=3D?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;CY1PR03MB1374;3:/ZfJ5YDhGSaXnA9ReM9f3cUYRbX9SzK/XZp/4bTrCoo7ZkMwTgOfh7noT5dDpyyeT1dFLNZq90AUMGKD8wtaZjEXLlT/WzyDdp8YxMsFSw6Z93r19p5xuRmC/7nJKqSaRXtppqbBCvksKCesUTCtsg==;10:ulnCXUK0z5LD0DAuZ9tRskYZQZkWjt4Kynj6InnlrhatzrtB6m9+80pU4u8KFW65a8Zx636u7Fe8cBpyuJFNtWSg7tf/AGpI7X+cx1sSUZk=;6:zeKAijmXQLZUl9a1T6cACE7HR4drabnoua2PzYjEwh41jqTf+zO13dcQBrkmM1oKxU1MonXWtGb9ccH/Kji9worbfDYxOfcd/caSnBbnCvy/8hg9g5dxTRoVFonjGH7rBl/QFWqEhPijsSsyCChHIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB1374 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BY2FFO11FD050.protection.gbl X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD050;1:X2EWchpgN0AlXIJm4lS49NGwsSZzXs3aB94BmaLz1oH9VJz3t0e6RaP7AaQqx98RwrAbYFZuqL+jA4kBNgmYiLuXsWz0nQcA/qykYi3FsU6mGZmG4i2H+GknP9BReZ0nou+vzLiCeb3aBavfOga/wOk0DX06MmDa6pSPIeIbDYy/hWONWc+3hFbkAq3kXnJ6AeFUFPO2enPwSWdgqRLpRF8jRRF+TMRYKHEy+dRO81eezSw/1cMAkWN1jaKFTjuz4h/6pZ6+B6/qf88QOvThAnZIXIXlndtK41/2CqDCj+BAwDuANpa8JlN+wD4dGloT X-Forefront-Antispam-Report: CIP:66.35.236.236;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(339900001)(479174004)(24454002)(51704005)(199003)(189002)(377454003)(46102003)(5001830100001)(81156007)(68736005)(77096005)(92566002)(5001860100001)(106466001)(4001540100001)(6070500001)(97736004)(5001770100001)(4001350100001)(189998001)(5001960100002)(2950100001)(23746002)(54356999)(65816999)(85426001)(87266999)(40100003)(76176999)(33656002)(77156002)(50986999)(122386002)(47776003)(64706001)(16796002)(86362001)(83506001)(65956001)(59896002)(66066001)(65806001)(105606002)(62966003)(19580395003)(19580405001)(64126003)(6806004)(50466002)(87936001)(80316001)(7099028);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR03MB043;H:sj-itexedge04.altera.priv.altera.com;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB043;2:wANptQw/o6l/2QW/WcpuWEdBj3EFDS1PYPp53JCKfinQUPUoMFQpCvPGIELiOBh0;2:2lF7a0TjSlBwg3oTzUr2p94FEfmBcuEOjkQrODXPwa8gmCyMIcX3E4jVZP44y/sT4lVQz/+ZuzIoU2sQv4AOmViBNqiEx/VqDyNsMiw/lRwHwvq19qZk5g7UHwxuTwnV0yBdEEy3yALR3w7AaRbPv1IQDc2BSDL0Ku2K4yEcrmS4oWkrFKU22WDGVg9m7HFFASDh4HYifkvoUFsJTKzMaky3XKFvtopEWFD6XDfGs7Y=;6:2htb0k269QRspgrKudBRcthb4PBVPmpJJZEAgEHNIeSKy90J42fMO07B/W8M0P1uVBF0rgvIiX4744CeE+dQHy7A9X3pQIYU5u1GbWCzYtqFwEvtwpdKe9LRN2gSr+OVITn6ozT9eT7AwGUoaOFf+g==;3:bXkYlCc6ahUnKJ7aIfeJpSVmrKPxS4ofV2fKtjPyw1rGQOioMbLYhKjyJV0b/R4Q7Ql2AnpLNtP+JWBiBDiprAURelml1+CuAWKi4acB3wOPu9WClfIpjMQlfTcZ0GApG2o1Ak/HUSsPJ+W9fUj04qbsnhyLORmJ54aXgqGmTYKe1gZC+MEDq5hlWuw3V7BWjTKcirlJvR5r9wyoiXhwW/t7xphNNr9J5cKzBakYt3uaCs7LCp/45D652lLNKIWpdRFFssGB3V7MnjqwbXBCBNOZHnN9vGTz0KYakMuldDR3FJiEpYcNtmr78FwRsJ20 X-Forefront-PRVS: 059185FE08 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BY2PR03MB043;9:7RBOoEiPyen9rVH9i67ZtcdPpBn1Nr6tnQLZjYH?= =?Windows-1252?Q?W3S7dVmoM5mybIo+o526YQKT7y+B4BSKoZ+Sm8sO0GUY/4GmM3isqtxk?= =?Windows-1252?Q?i7fQzpgwajyJCVXYjhz+df5ztBQTFnQkGW9lr4flhtat1I/lwUrJaYSk?= =?Windows-1252?Q?1P8pph+S/8D4Y4M+aYIeGlZa25Wlxw1SNrMNoDbdBVH6eoXFknaEN4pn?= =?Windows-1252?Q?fWPVx+Nx7pEap2Dd/3fX+auiSwKxpArnSsABgR64/qifxGjw+zMqWkIP?= =?Windows-1252?Q?97YeiaXKUo2kXwl2zl02bWYSbw4P7CtlNQlGTLFqB2RRIXocbiftyysa?= =?Windows-1252?Q?fYEvDpQThc2PLXu8CMfUYLDGFAAShwZ5ken1p4i6Jw1eqZaUglu6KmQx?= =?Windows-1252?Q?WOpJmSHH1ve2nYRwwPDzjZFk6sxGSYytxil444qEjRWdSQAJMFfLQjUr?= =?Windows-1252?Q?eW9zwxeiyr3sATRi4DqsiK9K52NoxPbMlzxhFHRUzYOyDqOC7gdJdy1E?= =?Windows-1252?Q?/SKy2CEcLrGqQq+lEB0CZSt3N4Lje6oqS7DohyxVmZF/+Qu1bfdyLXbc?= =?Windows-1252?Q?Ny6c0gLKUcEWYuFeyE36qLA/SXDqq/X/tt5gb4eVbC6qPWwqqSlSO6rm?= =?Windows-1252?Q?UaB3Ck9RQbk2SmNqqTI/7iPKPwl0mTenqj+of3tUoBBkSgojmk2BUXOE?= =?Windows-1252?Q?7vAmGGVLZOPzWUN23UK+3XKcWde9EuELSl4pFGbXrlvvzV+Wxqf00Jb0?= =?Windows-1252?Q?bahXPNisQZe10MRX31RZtTjjkgHMJ8YX+/Vo5zBlecKLSUUBQZ4VEziw?= =?Windows-1252?Q?7pIkWKMm8BgVpRKfDN7L7sQOeOkWaxcykfc3pl4c4bkr5MpobJjTj7lv?= =?Windows-1252?Q?bia3steSX5c70jfrTtx0tp9SNwLj+MOGf68P48DHa5BWvXHVlamp5tWm?= =?Windows-1252?Q?dWMsGiznZ3WwKRyoGW22Dy7QR70Q0hSIzNPfnq58Ll9CCN4ybe6a9qpe?= =?Windows-1252?Q?/zhSTL/o0z92Kl9VHXx35EKvefv4tG0eaZdEpTg6NsV5WfmisLfbz5Ct?= =?Windows-1252?Q?LCSVY/MpZIphRI9Y62kQ6tBGeqi3L9cZ3co2gEfhUcTqoYuMuDIDKGI0?= =?Windows-1252?Q?XT2hS00YeZu9WPme78XJO0S1KKTFrjueiFHRFzoA1jNyeLsrQFidS8g6?= =?Windows-1252?Q?MRKAGqmD6p7sKMZXWgYghTrr/UfA8Xz7KRtfleotn9k3gEAutfUqpvxM?= =?Windows-1252?Q?SRnrNQEDLE+CUExerCPev8qO83SP9+auWqw7zo750OOcppgJ0PvYdBmI?= =?Windows-1252?Q?liBNGTZM3xRuvAlF3CPorWYG95fvibZ9X3h6MUN6kAg9I3GbvMBtaHSl?= =?Windows-1252?Q?bMweEQnRiO7bQtoAAALqZVPRCDEx4ISJWDnhx9jDaWkytT356KXR3Swj?= =?Windows-1252?Q?aRo87xmAb9f08P47Bw2Rg8f/ljsG4ezWOnnrdAW8H6En0Xpsqf7S/ZpX?= =?Windows-1252?Q?QmJZduXhrd0o1eA/FAuFp45Vn?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB043;3:ZboYUOL8h3Rg0JTc9njyD7DtRKE9Z5q9yhRiFI6ZSH+eSozfwoi/yBT2geucNBPc/nclK3ZCezMj2o7ld0ZEf4WeUcVnZ/ojpRwhCYPXP0bJUuWztE/TRuBiG3wqWnv0K65nvYbChPL+754EGl5eJQ==;10:8rnTll4cd9p+QWGsms5Pxtm8la3v/ktbJFJDzWb5XUPt/Vxr5hhdGZuAXIAmH0pc6frJ3LLEZtph0VWaIF3QI8EbXNYhoSahQ0CdbPTZbt4=;6:P6IjMQ6cnw8qW8IKfu2edP/Vu2Rbe5dFsVRt7GEAe9JWJx9mRJg9+1czpgq/b9cFtUbX7BlngL8/RzDTZH1VgfgW0oE/NB6r2qu5N5d7n0b2/qm3ZW0BbYm2dg80BGOJM3OSNfaff/JD5doywshJRw== X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2015 03:15:25.3913 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.236];Helo=[sj-itexedge04.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR03MB043 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/28/15 4:19 PM, Alan Tull wrote: > Add code that requests that the sdr controller go into > self-refresh mode. This code is run from ocram. > > Suspend-to-RAM and EDAC support are mutually exclusive on > SOCFPGA. If the EDAC is enabled, it will prevent the > platform from going into suspend. > > Example of how to request to suspend to ram: > $ echo enabled > \ > /sys/devices/soc/ffc02000.serial0/tty/ttyS0/power/wakeup > > $ echo -n mem > /sys/power/state > > Signed-off-by: Alan Tull > Cc: Pavel Machek > Cc: Arnd Bergmann > Cc: Dinh Nguyen > Cc: Steffen Trumtrar > --- > v2: use Generic on-chip SRAM driver to allocate ocram > rm fncpy_align since generic allocator handles alignment > check __arm_ioremap_exec return code > check for NULL pointers > add a comment regarding sdram controller configuration > v3: fix renamed #define > propagate socfpga_setup_ocram_self_refresh error code > v4: Kconfig: don't need to select GENERIC_ALLOCATER > add CONFIG_SOCFPGA_SUSPEND > make s2r and EDAC support mutually exclusive > socfpga.c: add sdr_ctl_base_addr > return error if ocram not available in device tree > update copyright years > v5: remove compile time dependency > edac driver will prevent suspend > don't configure scu standby mode; done in enable_scu(). > fix comments about required sdram controller configuration > --- > arch/arm/mach-socfpga/Kconfig | 10 ++- > arch/arm/mach-socfpga/Makefile | 1 + > arch/arm/mach-socfpga/core.h | 6 +- > arch/arm/mach-socfpga/pm.c | 149 ++++++++++++++++++++++++++++++++++ > arch/arm/mach-socfpga/self-refresh.S | 136 +++++++++++++++++++++++++++++++ > arch/arm/mach-socfpga/socfpga.c | 6 +- > drivers/edac/altera_edac.c | 20 +++++ > 7 files changed, 325 insertions(+), 3 deletions(-) > create mode 100644 arch/arm/mach-socfpga/pm.c > create mode 100644 arch/arm/mach-socfpga/self-refresh.S > Which branch are you basing this patch on? I got a trivial patch conflict in Kconfig when I applied to arm-soc/for-next and v4.1-rc5. Also, I'm getting these sparse warnings: arch/arm/mach-socfpga/pm.c:86:25: warning: incorrect type in argument 1 (different address spaces) arch/arm/mach-socfpga/pm.c:86:25: expected void * arch/arm/mach-socfpga/pm.c:86:25: got void [noderef] *[assigned] suspend_ocram_base arch/arm/mach-socfpga/pm.c:108:52: warning: cast removes address space of expression Dinh