From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755381AbbE2F4O (ORCPT ); Fri, 29 May 2015 01:56:14 -0400 Received: from mail-bn1on0071.outbound.protection.outlook.com ([157.56.110.71]:36096 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751693AbbE2F4E (ORCPT ); Fri, 29 May 2015 01:56:04 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; ettus.com; dkim=none (message not signed) header.d=none; Message-ID: <5567FF65.5040208@xilinx.com> Date: Fri, 29 May 2015 07:55:49 +0200 From: Michal Simek User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Moritz Fischer , CC: , , , , , , , , , , , , , , , Subject: Re: [PATCHv3 1/2] dts: Adding docs for Xilinx LogiCORE IP mailbox driver. References: <1432849928-25457-1-git-send-email-moritz.fischer@ettus.com> <1432849928-25457-2-git-send-email-moritz.fischer@ettus.com> In-Reply-To: <1432849928-25457-2-git-send-email-moritz.fischer@ettus.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21574.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD044;1:3z60X3UjPrKiaYk7wKKIBLCjkYZ2Dd3GcKO5AUa6PY8MJ6zm9qq+9C/ln425OTk1eWR1g996b2kJu2EVflmguplWlkDOpnTev27F1gQxKqugMLq8bUyvbdrhIx/uErZfC2T24aH9AmjiAEAwcvz2fYlr25iLXqJy2a69m9it0MJJkTaG0FLcP2Na8WphDbdbKdth3EoDpsg7S5nBvkPmdmrGH+G0ih14e4UzJltHVCnHAkLDGzrn5qURa15PBgiypbenGJGM2+ZmMmumxKwrPA== X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(438002)(189002)(377454003)(164054003)(479174004)(24454002)(51704005)(199003)(86362001)(5001860100001)(87936001)(5001960100002)(2950100001)(80316001)(33656002)(54356999)(50986999)(87266999)(76176999)(65816999)(50466002)(36756003)(59896002)(63266004)(189998001)(46102003)(65956001)(65806001)(64706001)(47776003)(83506001)(6806004)(19580405001)(23746002)(19580395003)(92566002)(77156002)(36386004)(62966003)(5001830100001)(5001770100001)(81156007)(4001540100001)(77096005)(106466001)(64126003)(4001350100001)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1AFFO11HUB014;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;PTR:unknown-60-83.xilinx.com;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11HUB014;2:Q9E1XlFwgpibZY2bQrj3iJUwVl5HhFLzr6fewso4mxynXEmbkulGngkC5tJougps;2:u+Av64ciYQaR5rws4tZ0eIkboXDnD6UnY2lNk9pU3uWPJsbOb1dblXtfHmu1QNq6WX8M2kfREmGsjMPuOX3dYsx+Q1JLJ7S0+o9JZhXYRllz9+ygi18nNMvKxI7N6JFc6KfJWHXuvo9Q/aJIVszz9quZ8n19nsz/K4vTCoj65BXNOqFL1gBSrFAS3EuR7q2LdYceCYhIwwiyeywOaF45vbjMbkvHxlLgeG6InUAWOa8=;6:6tV9ddbpyI0GKyxRoDRw849ps3yX8UFQYxyWZKtYRUC94IahEEUJdFmJMNIGOvtlTKRmkYTqMK5vOifANJdiyadAAu1EjWTJIdqbk0m4ywZXu+/hYHdupST/nu2A1as7+XEa/etl6W3UGQ1Q0rtXO2lFpW6XgcpywktI5q+PDPgAgBmaBUe4Ulusyyezo8a4CJ/2SPUtgpuH/KW35npNNY4UQnKFHo2uD3618BApgmKKqqpE9ewVUlmY+0tE3sOWgntFsaXc0Q3DBhNMYUF6s8mml+ERNs+UX2P1x+2DHsDyOiyyEXF9AS3pBTZkhniXUJ60ryv6ymSVl8g3hyAcr4Ogce0uSnP+kaerbZ8ygjdq08NY41NgoWdfDJXREyHexDXYnYcJMcrrkxdI9vr2ly1ED89BSZ/uBVzPeLUpealNcSJ6ObFoN28EYT1jCxeJFyMr+v7o9FSy5Xqyhe4MImpx7sMl00Xz+ziwzUo53zi7AGVu4dtB0tqGwWbunz0P X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN1AFFO11HUB014; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(520003)(3002001);SRVR:BN1AFFO11HUB014;BCL:0;PCL:0;RULEID:;SRVR:BN1AFFO11HUB014; X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11HUB014;3:bZG7l3lkZ8GGnxNDJm0Lugh6eU4DZlo57Nn//I3cgYu3CMoIS5tCa3uYQlV/zGNWNZAvSust23LZ2ZeKOIaA/FP3JYPj8z2y2WkBURatEuMIpVw8HonM0ejSu9+/ykfXjzfDPAGrC3WTSgXhOMMc8bg8jcrizytpyr90s4hPKC2UdlDU/33C6ls7OySbCWA5+spFPwf1Ik7FUbJVyI+0k90MQBXBO5kUtQ7O8zqviXGqIGkZCi2sbDt/y2x+JrEK8EFSSQBNnSXwR2TJCnWHcr0SQnVGn3+532egDf6/lps54kyB8sMp0TPt0pPQot3a X-Forefront-PRVS: 059185FE08 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN1AFFO11HUB014;9:a5dF2Eu+YSyPoL6PrwC/Fw5LsH33CzDI1UmA?= =?Windows-1252?Q?aacjhcb+qgLW6M9dwX5gYgD5PrmlPLPOoaXmcqv8k92Kgd/+MMqysSZ/?= =?Windows-1252?Q?fwdUY5jNbauosV6mRzqHnvIKikaTkGreqYgjjZK5AmDnZLd6D/Gr0cT9?= =?Windows-1252?Q?YHsowdM6vw/OJu8Rp0/cIy5E4N2cLGna8eylg7rG79vKI28zbd2ulpjV?= =?Windows-1252?Q?D5P/X07Gs+W9VepaYWdqIfyu3lLb9jAv0x6AdKmspZKdJssnu3YghGVC?= =?Windows-1252?Q?7rH37Aw01zViTVmH2c+MmGGBQjXWdda5POUErvh5xB3acQtQvzjVxfHn?= =?Windows-1252?Q?1kncMIHxrPoOM4tghpCqmfIz2aOwkR9qk5Q02FRbq+wrJpztcL6f8NVl?= =?Windows-1252?Q?3VpifFLuBPzP7PaxjYLoVyYlySLudjBjiep66Qpux84GnIuTSE+4k7kt?= =?Windows-1252?Q?LAHM1ZEfZGIYHyylMY5dGArhou3H0gHvMRv2RF6v/sIeI2KO+NLf1rMi?= =?Windows-1252?Q?NSciZvRNiJtNoJ2B+fSWh0hy1AAIOdmokAJUwThgrIy3lQYT+UGVGa4/?= =?Windows-1252?Q?pLSTaWMvG5jWObRUAvuMvM+YxVuGJWtRQkcoxjiXXIWS2cejqyv6NsSk?= =?Windows-1252?Q?Pj0ZQ9N8az79oFD+OujU6/lUZsOrOy2lgWD0SCTzMzNrJ1KFPPCu0MUk?= =?Windows-1252?Q?NJBodS7ivbLsRtrr/r0AE76OzMxUT/bxQMBjaVVU9HrGIzWn4tCOM8Fg?= =?Windows-1252?Q?xdPbVqZYkF7iB63+4m1XQyjO9LGQ0n0SVt+8ap8lw+LRpfcLkdCuPpOm?= =?Windows-1252?Q?RvxXRlzbofkR365XPd0Okjy+sj/WVV1IMm1sWF9R888HWjefnoJxmfmS?= =?Windows-1252?Q?od0duttAnLDq5K4wT5yVKvVXaf1dgl9y8iH8PiguQgApsa5PKV8WcPJJ?= =?Windows-1252?Q?78fEzAr2arjFJoJDcuyrJGicNiXR5yNRrahspuXpAEIFnPeyoVSwQUaF?= =?Windows-1252?Q?+37WUnN5w01kLfDrLE1KC4cwYySTWJGJvIekZPcs+9E5lh2778gDMbl5?= =?Windows-1252?Q?xGt1ocuOI/+0CpYgdsx2T4JDVYudzGUYvt6PTUXPdwOE95Rl2BGdNxJ1?= =?Windows-1252?Q?YSWXfjVGH/QxAlB+1rVJ6m0XYOz69bJ7QCoVK1+o3mSYyooAPrtsVq5W?= =?Windows-1252?Q?M/pfPZSr0jj2HN+VWiGqDxuyKplS8Wd2Rx5cS7FBuhz2YWyIA9GvbGZ4?= =?Windows-1252?Q?JpSsG1K+eoozZcB/pnsLhmu8MLyiNhNMlZQEju0kG9uhPfn3Wax9m28Q?= =?Windows-1252?Q?eCCXugmTdzKEIFa5zRxDcNhY/8lUrfsrvK2q/W4x6WJ9oDpKvBuAudJK?= =?Windows-1252?Q?PHDbz3jicuRH?= X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11HUB014;3:Sl4pHyy/9vBHelnG3Poyfkar6SnS393AsJ7ppyOj0p4H3qnbdRC43hRrR2T7r+mR+Y4gjIASkg+O6KYqD6/SriVcxgrbnO3CeqZIkyt39ONlBJdV8d6iem/OdhwdI+4emqFWNfwji5Oz4Nmgf0CTIA==;10:HH6O5yL7MmP801Ij2qmSX/WLCdHif5K4BcudpAzzAA5qoejctyIImkYZVdANATakXsUDN0DF2RIdj2uRUIrLGiOuRkBYc7k59m1xRbkzXRY= X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2015 05:56:02.0882 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1AFFO11HUB014 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/28/2015 11:52 PM, Moritz Fischer wrote: > Changes from v2: > - Addressed Michal's stylistic comments > - Fixed typo in compatible string > > Changes from v1: > - Added common clock framework support > > Changes from v0: > - Fixed example bindings > > Signed-off-by: Moritz Fischer > --- > .../bindings/mailbox/xilinx-mailbox.txt | 44 ++++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mailbox/xilinx-mailbox.txt b/Documentation/devicetree/bindings/mailbox/xilinx-mailbox.txt > new file mode 100644 > index 0000000..ca76efd > --- /dev/null > +++ b/Documentation/devicetree/bindings/mailbox/xilinx-mailbox.txt > @@ -0,0 +1,44 @@ > +Xilinx Mailbox Driver > +===================== > + > +Required properties: > +- compatible : "xlnx,mailbox-2.1". > +- reg : physical base address of the mailbox and length of > + memory mapped region. > +- #mbox-cells : common mailbox binding property to identify the number > + of cells required for the mailbox specifier, should be 1 > +- clocks : phandle to clock provider > +- clock-names : must be 'mbox' > + > +Optional properties: > +- interrupt-parent : interrupt source phandle > +- interrupts : interrupt number, The interrupt specifier format > + depends on the interrupt controller parent. > + > +Example: > + mbox: mailbox@40400000 { > + compatible = "xlnx,mailbox-2.1"; > + reg = <0x40400000 0x3c>; > + interrupt-parent = <&intc>; > + interrupts = <5>; > + #mbox-cells = <1>; > + clocks = <&clkc 15>; > + clock-names = "mbox"; > + }; > + > +Mailbox client > +=============== > +"mboxes" and the optional "mbox-names" (please see > +Documentation/devicetree/bindings/mailbox/mailbox.txt for details). Each value > +of the mboxes property should contain a phandle to the mailbox controller > +device node and second argument is the channel index. It must be 0 (hardware > +support only one channel). The equivalent "mbox-names" property value can be > +used to give a name to the communication channel to be used by the client user. > + > +Example: > + mclient0: mclient0@400 { > + compatible = "client-1.0"; > + reg = <0x400 0x10>; > + mbox-names = "mbox"; > + mboxes = <&mbox 0>; > + }; > I see you still keep there 0x3c but that's minor detail. Acked-by: Michal Simek Thanks, Michal