From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755458AbbE2ICe (ORCPT <rfc822;w@1wt.eu>);
	Fri, 29 May 2015 04:02:34 -0400
Received: from szxga02-in.huawei.com ([119.145.14.65]:8168 "EHLO
	szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752712AbbE2ICW (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 29 May 2015 04:02:22 -0400
Message-ID: <55681CDD.9050404@huawei.com>
Date: Fri, 29 May 2015 16:01:33 +0800
From: Li Bin <huawei.libin@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1
MIME-Version: 1.0
To: Paul Bolle <pebolle@tiscali.nl>
CC: <rostedt@goodmis.org>, <mingo@kernel.org>, <jpoimboe@redhat.com>,
        <sjenning@redhat.com>, <jkosina@suse.cz>, <vojtech@suse.cz>,
        <catalin.marinas@arm.com>, <will.deacon@arm.com>,
        <masami.hiramatsu.pt@hitachi.com>, <live-patching@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        <lizefan@huawei.com>, <felix.yang@huawei.com>, <guohanjun@huawei.com>,
        <xiexiuqi@huawei.com>
Subject: Re: [RFC PATCH 1/5] livepatch: ftrace: arm64: Add support for DYNAMIC_FTRACE_WITH_REGS
References: <1432792265-24076-1-git-send-email-huawei.libin@huawei.com>	 <1432792265-24076-2-git-send-email-huawei.libin@huawei.com> <1432883689.3551.3.camel@x220>
In-Reply-To: <1432883689.3551.3.camel@x220>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.177.25.181]
X-CFilter-Loop: Reflected
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2015/5/29 15:14, Paul Bolle wrote:
> On Thu, 2015-05-28 at 13:51 +0800, Li Bin wrote:
>> --- a/arch/arm64/Kconfig
>> +++ b/arch/arm64/Kconfig
> 
>>  	select HAVE_DYNAMIC_FTRACE
>> +	select HAVE_DYNAMIC_FTRACE_WITH_REGS if HAVE_DYNAMIC_FTRACE
> 
> What's the point of "if HAVE_DYNAMIC_FTRACE" here? That test should
> always evaluate to true, because HAVE_DYNAMIC_FTRACE is also selected.
> 

Ah, I'll modify it.
Thanks!
	Li Bin

> 
> Paul Bolle
> 
> 
> 
> 
> .
>