From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755679AbbE2KLM (ORCPT ); Fri, 29 May 2015 06:11:12 -0400 Received: from mail-db3on0134.outbound.protection.outlook.com ([157.55.234.134]:40523 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755467AbbE2KLF (ORCPT ); Fri, 29 May 2015 06:11:05 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=bhuvanchandra.dv@toradex.com; Message-ID: <55683B17.1010706@toradex.com> Date: Fri, 29 May 2015 15:40:31 +0530 From: Bhuvanchandra DV User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: =?UTF-8?B?SmFrdWIgS2ljacWEc2tp?= CC: , , , , , , , , , Subject: Re: [PATCH 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl References: <1432886754-30115-1-git-send-email-bhuvanchandra.dv@toradex.com> <1432886754-30115-3-git-send-email-bhuvanchandra.dv@toradex.com> <20150529120421.754fd6ab@north> In-Reply-To: <20150529120421.754fd6ab@north> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [115.115.225.206] X-ClientProxiedBy: HKXPR03CA0069.apcprd03.prod.outlook.com (25.163.104.27) To AMSPR05MB263.eurprd05.prod.outlook.com (10.242.95.26) X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AMSPR05MB263; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(520003)(3002001);SRVR:AMSPR05MB263;BCL:0;PCL:0;RULEID:;SRVR:AMSPR05MB263; X-Forefront-PRVS: 059185FE08 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(979002)(6009001)(6049001)(24454002)(199003)(479174004)(51704005)(189002)(377454003)(19580405001)(92566002)(99136001)(189998001)(97736004)(64126003)(36756003)(101416001)(87266999)(54356999)(76176999)(4001350100001)(50986999)(68736005)(42186005)(59896002)(80316001)(83506001)(19580395003)(65956001)(23676002)(86362001)(77096005)(2950100001)(46102003)(87976001)(5001960100002)(110136002)(77156002)(105586002)(47776003)(40100003)(4001540100001)(65806001)(64706001)(65816999)(81156007)(66066001)(62966003)(106356001)(122386002)(5001860100001)(33656002)(50466002)(5001920100001)(5001830100001)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1102;SCL:1;SRVR:AMSPR05MB263;H:[10.18.0.154];FPR:;SPF:None;PTR:InfoNoRecords;A:3;MX:1;LANG:en; X-OriginatorOrg: toradex.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2015 10:10:55.4024 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR05MB263 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Jakub, On 05/29/2015 03:34 PM, Jakub Kiciński wrote: > On Fri, 29 May 2015 13:35:53 +0530, Bhuvanchandra DV wrote: >> The LPUART does not provide manual control of RTS/CTS signals, >> those can only be controlled by the hardware directly. Therefore >> manual control of those signals through mctrl can not be provided. >> The current implementation enables/disables the automatic control, >> which is not what mctrl should do, hence remove the incorrect >> implementation. >> >> Signed-off-by: Bhuvanchandra DV > > Now that the functions do nothing there is probably no point in keeping > separate lpuart/lpuart32 variants. Agreed, will update it accordingly. Thanks! for pointing this. > Best regards, Bhuvan