* [PATCH] x86/xen: use schedule_timeout_interruptible()
@ 2015-05-29 13:49 Nicholas Mc Guire
2015-05-29 14:44 ` Boris Ostrovsky
0 siblings, 1 reply; 2+ messages in thread
From: Nicholas Mc Guire @ 2015-05-29 13:49 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk
Cc: Boris Ostrovsky, David Vrabel, Thomas Gleixner, Ingo Molnar,
H. Peter Anvin, x86, xen-devel, linux-kernel, Nicholas Mc Guire
API consolidation with coccinelle found:
./arch/x86/xen/smp.c:499:2-18:
consolidation with schedule_timeout_*() recommended
This is a 1:1 conversion of the current calls to an available helper
only - so only an API consolidation to improve readability.
Patch was compile tested with x86_64_defconfig +
CONFIG_HYPERVISOR_GUEST=y,CONFIG_PARAVIRT=y,CONFIG_XEN=y:
Patch is against 4.1-rc5 (localversion-next is -next-20150529)
Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
---
arch/x86/xen/smp.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/x86/xen/smp.c b/arch/x86/xen/smp.c
index 8648438..6cbbfc8 100644
--- a/arch/x86/xen/smp.c
+++ b/arch/x86/xen/smp.c
@@ -494,10 +494,8 @@ static int xen_cpu_disable(void)
static void xen_cpu_die(unsigned int cpu)
{
- while (xen_pv_domain() && HYPERVISOR_vcpu_op(VCPUOP_is_up, cpu, NULL)) {
- __set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout(HZ/10);
- }
+ while (xen_pv_domain() && HYPERVISOR_vcpu_op(VCPUOP_is_up, cpu, NULL))
+ schedule_timeout_uninterruptible(msecs_to_jiffies(100));
if (common_cpu_die(cpu) == 0) {
xen_smp_intr_free(cpu);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] x86/xen: use schedule_timeout_interruptible()
2015-05-29 13:49 [PATCH] x86/xen: use schedule_timeout_interruptible() Nicholas Mc Guire
@ 2015-05-29 14:44 ` Boris Ostrovsky
0 siblings, 0 replies; 2+ messages in thread
From: Boris Ostrovsky @ 2015-05-29 14:44 UTC (permalink / raw)
To: Nicholas Mc Guire, Konrad Rzeszutek Wilk
Cc: David Vrabel, Thomas Gleixner, Ingo Molnar, H. Peter Anvin, x86,
xen-devel, linux-kernel
On 05/29/2015 09:49 AM, Nicholas Mc Guire wrote:
> API consolidation with coccinelle found:
> ./arch/x86/xen/smp.c:499:2-18:
> consolidation with schedule_timeout_*() recommended
>
> This is a 1:1 conversion of the current calls to an available helper
> only - so only an API consolidation to improve readability.
>
> Patch was compile tested with x86_64_defconfig +
> CONFIG_HYPERVISOR_GUEST=y,CONFIG_PARAVIRT=y,CONFIG_XEN=y:
>
> Patch is against 4.1-rc5 (localversion-next is -next-20150529)
>
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Reviewed-by: Boris Ostrovsky < boris.ostrovsky@oracle.com>
> ---
> arch/x86/xen/smp.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/xen/smp.c b/arch/x86/xen/smp.c
> index 8648438..6cbbfc8 100644
> --- a/arch/x86/xen/smp.c
> +++ b/arch/x86/xen/smp.c
> @@ -494,10 +494,8 @@ static int xen_cpu_disable(void)
>
> static void xen_cpu_die(unsigned int cpu)
> {
> - while (xen_pv_domain() && HYPERVISOR_vcpu_op(VCPUOP_is_up, cpu, NULL)) {
> - __set_current_state(TASK_UNINTERRUPTIBLE);
> - schedule_timeout(HZ/10);
> - }
> + while (xen_pv_domain() && HYPERVISOR_vcpu_op(VCPUOP_is_up, cpu, NULL))
> + schedule_timeout_uninterruptible(msecs_to_jiffies(100));
>
> if (common_cpu_die(cpu) == 0) {
> xen_smp_intr_free(cpu);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-29 14:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-29 13:49 [PATCH] x86/xen: use schedule_timeout_interruptible() Nicholas Mc Guire
2015-05-29 14:44 ` Boris Ostrovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox