From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756667AbbE2Qgc (ORCPT ); Fri, 29 May 2015 12:36:32 -0400 Received: from smtp97.iad3a.emailsrvr.com ([173.203.187.97]:35552 "EHLO smtp97.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756191AbbE2QgW (ORCPT ); Fri, 29 May 2015 12:36:22 -0400 X-Sender-Id: abbotti@mev.co.uk Message-ID: <55689582.1000700@mev.co.uk> Date: Fri, 29 May 2015 17:36:18 +0100 From: Ian Abbott User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Nicholas Mc Guire CC: H Hartley Sweeten , Greg Kroah-Hartman , Davidlohr Bueso , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: me_daq: use schedule_timeout_interruptible() References: <1432915098-27097-1-git-send-email-hofrat@osadl.org> In-Reply-To: <1432915098-27097-1-git-send-email-hofrat@osadl.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/05/15 16:58, Nicholas Mc Guire wrote: > API consolidation with coccinelle found: > ./drivers/staging/comedi/drivers/me_daq.c:177:1-17: > consolidation with schedule_timeout_*() recommended > > This is a 1:1 conversion of the current calls to an available helper > only - so only an API consolidation to improve readability. > > Patch was compile tested with x86_64_defconfig + CONFIG_STAGING=y, > CONFIG_COMEDI=y, CONFIG_COMEDI_PCI_DRIVERS=y CONFIG_COMEDI_ME_DAQ=m > > Patch is against 4.1-rc5 (localversion-next is -next-20150529) Minor niggle: you don't really need to say what version the patch is against in the commit message, as the version will have changed by the time the patch is committed. It can be mentioned after the "---" marker line if relevant, as the stuff after the "---" line does not end up in the commit message. > > Signed-off-by: Nicholas Mc Guire > --- > drivers/staging/comedi/drivers/me_daq.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/me_daq.c b/drivers/staging/comedi/drivers/me_daq.c > index d78e919..9ea1ba4 100644 > --- a/drivers/staging/comedi/drivers/me_daq.c > +++ b/drivers/staging/comedi/drivers/me_daq.c > @@ -173,8 +173,7 @@ struct me_private_data { > > static inline void sleep(unsigned sec) > { > - __set_current_state(TASK_INTERRUPTIBLE); > - schedule_timeout(sec * HZ); > + schedule_timeout_interruptible(sec * HZ); > } > > static int me_dio_insn_config(struct comedi_device *dev, > The patch itself looks fine! Reviewed-by: Ian Abbott -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-