From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756650AbbE2Qzg (ORCPT ); Fri, 29 May 2015 12:55:36 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:41417 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756347AbbE2Qz2 (ORCPT ); Fri, 29 May 2015 12:55:28 -0400 Message-ID: <556899FF.1040705@infradead.org> Date: Fri, 29 May 2015 09:55:27 -0700 From: Randy Dunlap User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Stephen Rothwell , linux-next@vger.kernel.org CC: linux-kernel@vger.kernel.org, Ignotas , Linux PM list Subject: Re: linux-next: Tree for May 29 (drivers/power/twl4030_charger) References: <20150529221804.2b8940f3@canb.auug.org.au> In-Reply-To: <20150529221804.2b8940f3@canb.auug.org.au> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/29/15 05:18, Stephen Rothwell wrote: > Hi all, > > Changes since 20150528: > on i386: when CONFIG_USB_SUPPORT is not enabled: ../drivers/power/twl4030_charger.c: In function 'twl4030_bci_probe': ../drivers/power/twl4030_charger.c:648:4: error: implicit declaration of function 'devm_usb_get_phy_by_node' [-Werror=implicit-function-declaration] bci->transceiver = devm_usb_get_phy_by_node( ^ ../drivers/power/twl4030_charger.c:648:21: warning: assignment makes pointer from integer without a cast [enabled by default] bci->transceiver = devm_usb_get_phy_by_node( ^ Should this driver depend on USB_SUPPORT? -- ~Randy