[PATCH] ideapad_laptop: Add Lenovo G50-30 to devices without radio switch

[PATCH] ideapad_laptop: Add Lenovo G50-30 to devices without radio switch

[Philippe Coval]

From: Dmitry Tunin <hanipouspilot@gmail.com>

Lenovo G50-30 rfkill always reports wireless blocked fix.

BugLink: https://bugs.launchpad.net/bugs/1397021
Cc: platform-driver-x86@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Dmitry Tunin <hanipouspilot@gmail.com>
Signed-off-by: Philippe Coval <philippe.coval@open.eurogiciel.org>
---
 drivers/platform/x86/ideapad-laptop.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
index b496db8..6e82520 100644
--- a/drivers/platform/x86/ideapad-laptop.c
+++ b/drivers/platform/x86/ideapad-laptop.c
@@ -837,6 +837,13 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
 		},
 	},
 	{
+		.ident = "Lenovo G50-30",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo G50-30"),
+		},
+	},
+	{
 		.ident = "Lenovo Yoga 2 11 / 13 / Pro",
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
-- 
1.9.1

Re: [PATCH] ideapad_laptop: Add Lenovo G50-30 to devices without radio switch

[Darren Hart]

On Fri, May 29, 2015 at 03:20:01PM +0200, Philippe Coval wrote:
> From: Dmitry Tunin <hanipouspilot@gmail.com>
> 
> Lenovo G50-30 rfkill always reports wireless blocked fix.

A little more detail in the future please, remember the bug link is a reference,
but this log is the official justification for the change. This barely makes it.

> BugLink: https://bugs.launchpad.net/bugs/1397021
> Cc: platform-driver-x86@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Dmitry Tunin <hanipouspilot@gmail.com>
> Signed-off-by: Philippe Coval <philippe.coval@open.eurogiciel.org>

Queued for next.

-- 
Darren Hart
Intel Open Source Technology Center

Re: [PATCH] ideapad_laptop: Add Lenovo G50-30 to devices without radio switch

[Dmitry Tunin]

Darren,

I sent this patch twice, second time with more detailed explanation.
But got no answer. So I asked Philippe to push it.

Regards,

Dmitry.

29.05.2015 19:49, Darren Hart пишет:
> On Fri, May 29, 2015 at 03:20:01PM +0200, Philippe Coval wrote:
>> From: Dmitry Tunin <hanipouspilot@gmail.com>
>>
>> Lenovo G50-30 rfkill always reports wireless blocked fix.
> 
> A little more detail in the future please, remember the bug link is a reference,
> but this log is the official justification for the change. This barely makes it.
> 
>> BugLink: https://bugs.launchpad.net/bugs/1397021
>> Cc: platform-driver-x86@vger.kernel.org
>> Cc: linux-kernel@vger.kernel.org
>> Signed-off-by: Dmitry Tunin <hanipouspilot@gmail.com>
>> Signed-off-by: Philippe Coval <philippe.coval@open.eurogiciel.org>
> 
> Queued for next.
> 

Re: [PATCH] ideapad_laptop: Add Lenovo G50-30 to devices without radio switch

[Darren Hart]

On Fri, May 29, 2015 at 08:02:46PM +0300, Dmitry Tunin wrote:
> Darren,
> 
> I sent this patch twice, second time with more detailed explanation.
> But got no answer. So I asked Philippe to push it.

Checked my Inbox, nothing from you on this one. Found it on the list. Please see
the MAINTAINERS file and Cc the maintainer per Documentation/SubmittingPatches:


    5) Select the recipients for your patch.
    ----------------------------------------

    You should always copy the appropriate subsystem maintainer(s) on any patch
    to code that they maintain; look through the MAINTAINERS file and the source
    code revision history to see who those maintainers are.  The ...


This is why your patches were ignored (not ever seen) and why Philippe's were
accepted.

> 
> Regards,
> 
> Dmitry.
> 
> 29.05.2015 19:49, Darren Hart пишет:
> > On Fri, May 29, 2015 at 03:20:01PM +0200, Philippe Coval wrote:
> >> From: Dmitry Tunin <hanipouspilot@gmail.com>
> >>
> >> Lenovo G50-30 rfkill always reports wireless blocked fix.
> > 
> > A little more detail in the future please, remember the bug link is a reference,
> > but this log is the official justification for the change. This barely makes it.
> > 
> >> BugLink: https://bugs.launchpad.net/bugs/1397021
> >> Cc: platform-driver-x86@vger.kernel.org
> >> Cc: linux-kernel@vger.kernel.org
> >> Signed-off-by: Dmitry Tunin <hanipouspilot@gmail.com>
> >> Signed-off-by: Philippe Coval <philippe.coval@open.eurogiciel.org>
> > 
> > Queued for next.
> > 
> 

-- 
Darren Hart
Intel Open Source Technology Center

Re: [PATCH] ideapad_laptop: Add Lenovo G50-30 to devices without radio switch

[Dmitry Tunin]

Darren,

And also I think it can be cc'ed to stable too.

Re: [PATCH] ideapad_laptop: Add Lenovo G50-30 to devices without radio switch

[Darren Hart]

On Fri, May 29, 2015 at 08:18:57PM +0300, Dmitry Tunin wrote:
> Darren,
> 
> And also I think it can be cc'ed to stable too.
> 

I mined your second version off the list, added Phillipe's Signed-off-by, and
sync'd it with his later version. This should connect it to the stable bot.
Please follow the guidelines in SubmittingPatches in the future, it really helps
keep things moving smoothly.

-- 
Darren Hart
Intel Open Source Technology Center

Re: [PATCH] ideapad_laptop: Add Lenovo G50-30 to devices without radio switch

[Dmitry Tunin]

OK. Thanks.

29.05.2015 22:30, Darren Hart пишет:
> On Fri, May 29, 2015 at 08:18:57PM +0300, Dmitry Tunin wrote:
>> Darren,
>>
>> And also I think it can be cc'ed to stable too.
>>
> 
> I mined your second version off the list, added Phillipe's Signed-off-by, and
> sync'd it with his later version. This should connect it to the stable bot.
> Please follow the guidelines in SubmittingPatches in the future, it really helps
> keep things moving smoothly.
>