Re: [PATCH 3/6] edac, mce_amd_inj: Modify flags attrigute to use string arguments

Borislav Petkov
2015-05-29T19:06:08Z

On Fri, May 29, 2015 at 01:20:31PM -0500, Aravind Gopalakrishnan wrote:
> Hmm. That should work. Will simplify it in the next version.
> I think I had a NULL in flags_options[] to denote the invalid option.

Still a good thing to have it as a terminator. But the loop I proposed
doesn't even touch it: i < N_INJ_TYPES. I'd leave the NULL array
terminator.

> Shall I make err = -EINVAL by default and return that here if the
> condition is not satisfied?

We have to make sure to not be overeager to error out - this'll make
using this facility a bit more cumbersome.

So I think your approach was correct to trim it to MAX_FLAG_OPT_SIZE.
__set_inj() will catch any string mismatches anyway.

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--