From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758537AbbEaVMw (ORCPT ); Sun, 31 May 2015 17:12:52 -0400 Received: from a.ns.miles-group.at ([95.130.255.143]:65275 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751272AbbEaVMp (ORCPT ); Sun, 31 May 2015 17:12:45 -0400 Message-ID: <556B7948.2020706@nod.at> Date: Sun, 31 May 2015 23:12:40 +0200 From: Richard Weinberger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Ross Zwisler CC: axboe@kernel.dk, dan.j.williams@intel.com, mingo@kernel.org, willy@linux.intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] block: pmem: Add dependency on HAS_IOMEM References: <1430765937-32694-1-git-send-email-richard@nod.at> <1430769649.19214.1.camel@theros.lm.intel.com> In-Reply-To: <1430769649.19214.1.camel@theros.lm.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 04.05.2015 um 22:00 schrieb Ross Zwisler: > On Mon, 2015-05-04 at 20:58 +0200, Richard Weinberger wrote: >> Not all architectures have io memory. >> >> Fixes: >> drivers/block/pmem.c: In function ‘pmem_alloc’: >> drivers/block/pmem.c:146:2: error: implicit declaration of function ‘ioremap_nocache’ [-Werror=implicit-function-declaration] >> pmem->virt_addr = ioremap_nocache(pmem->phys_addr, pmem->size); >> ^ >> drivers/block/pmem.c:146:18: warning: assignment makes pointer from integer without a cast [enabled by default] >> pmem->virt_addr = ioremap_nocache(pmem->phys_addr, pmem->size); >> ^ >> drivers/block/pmem.c:182:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration] >> iounmap(pmem->virt_addr); >> ^ >> >> Signed-off-by: Richard Weinberger >> --- >> drivers/block/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig >> index eb1fed5..3ccef9e 100644 >> --- a/drivers/block/Kconfig >> +++ b/drivers/block/Kconfig >> @@ -406,6 +406,7 @@ config BLK_DEV_RAM_DAX >> >> config BLK_DEV_PMEM >> tristate "Persistent memory block device support" >> + depends on HAS_IOMEM >> help >> Saying Y here will allow you to use a contiguous range of reserved >> memory as one or more persistent block devices. > > Reviewed-by: Ross Zwisler Ping? Thanks, //richard