Re: [PATCH] usb: isp1760: fix null dereference if kzalloc returns null

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 6/1/2015 1:41 AM, Colin Ian King wrote:

>>> From: Colin Ian King <colin.king@canonical.com>

>>> If kzalloc returns null then isp1760_ep_alloc_request performs
>>> a null pointer deference on req.

>>     Dereference, not "deference".

> Shall I send v2 for this stupid typo then?

    Definitely, especially as your change log doesn't adequately reflect 
reality anyway.

>>     No, it doesn't. It calculates the address of the
>> 'isp1760_request::req' instead, there's no dereference per se. I suppose
>> this is a first member of the structure, so this function should work
>> correctly in any case.

> Well, for now it's the first member, but can we assume that will apply
> forever?

    I guess so.

> As it stands, other *_alloc_request() functions in all the
> other usb drivers check for the NULL, so this fix just aligns the code
> with all of these other drivers.

    OK.

[...]

WBR, Sergei