From: Prarit Bhargava <prarit@redhat.com>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
Jan Kara <jack@suse.cz>, Jiri Bohac <jbohac@suse.cz>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [RFC][PATCH 0/4] Fixes for leapsecond expiring early ABS_TIME CLOCK_REALTIME timers
Date: Mon, 01 Jun 2015 07:57:49 -0400 [thread overview]
Message-ID: <556C48BD.9010201@redhat.com> (raw)
In-Reply-To: <1432931068-4980-1-git-send-email-john.stultz@linaro.org>
On 05/29/2015 04:24 PM, John Stultz wrote:
> As Prarit reported here:
> https://lkml.org/lkml/2015/5/27/458
>
> Since the leapsecond is applied at timer tick time, and not
> the actual second edge, ABS_TIME CLOCK_REALTIME timers set for
> right after the leapsecond could fire a second early, since
> some timers may be expired before we trigger the timekeeping
> timer, which then applies the leapsecond.
>
> Thus this patch series tries to address this isssue, including
> extending the leap-a-day test to catch this problem, as well
> as other relevant fixups I found while working on the code.
>
> This series has only had limited testing, so I wanted to send
> it out for initial review and comment. Folks can grab this tree
> via git for testing here:
> https://git.linaro.org/people/john.stultz/linux.git dev/early-leap-timer
>
John, native testing went well across many 32-bit and 64-bit AMD and Intel
boxes. However, virtual (specifically KVM) guests failed with some sort of
corruption:
[ 1546.038479] Clock: inserting leap second 23:59:60 UTC
[ 1559.774700] Clock: inserting leap second 23:59:60 UTC
[ 1573.502989] Clock: inserting leap second 23:59:60 UTC
[ 1587.235917] Clock: inserting leap second 23:59:60 UTC
[ 7. X] Clock: inserting leap second 23:59:60 UTC
[ 7. X] Clock: inserting leap second 23:59:60 UTC
[ 7. X] Clock: inserting leap second 23:59:60 UTC
[ 7. X] Clock: inserting leap second 23:59:60 UTC
I'm going to see if I can figure out a way to kdump a guest with this problem.
The issue is that it seems like all input to the console is ignored when this
happens.
P.
next prev parent reply other threads:[~2015-06-01 11:58 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 20:24 [RFC][PATCH 0/4] Fixes for leapsecond expiring early ABS_TIME CLOCK_REALTIME timers John Stultz
2015-05-29 20:24 ` [RFC][PATCH 1/4] selftests: timers: Add leap-second timer edge testing to leap-a-day.c John Stultz
2015-05-29 20:24 ` [RFC][PATCH 2/4] timer_list: Add the base offset so remaining nsecs are accurate for non monotonic timers John Stultz
2015-05-29 20:24 ` [RFC][PATCH 3/4] ntp: Use printk_deferred in leapsecond path John Stultz
2015-06-02 10:31 ` Jiri Bohac
2015-06-02 10:43 ` Jiri Kosina
2015-06-02 16:14 ` John Stultz
2015-06-02 16:04 ` John Stultz
2015-05-29 20:24 ` [RFC][PATCH 4/4] time: Do leapsecond adjustment in gettime fastpaths John Stultz
2015-05-31 16:05 ` Richard Cochran
2015-06-02 9:01 ` Ingo Molnar
2015-06-02 9:21 ` Peter Zijlstra
2015-06-02 14:09 ` John Stultz
2015-06-02 15:52 ` John Stultz
2015-06-03 9:04 ` Ingo Molnar
2015-06-03 17:44 ` John Stultz
2015-06-04 6:48 ` Ingo Molnar
2015-06-05 0:08 ` John Stultz
2015-06-05 7:29 ` Peter Zijlstra
2015-06-05 9:04 ` Richard Cochran
2015-06-05 9:10 ` Peter Zijlstra
2015-06-05 14:12 ` Richard Cochran
2015-06-05 17:28 ` John Stultz
2015-06-06 9:44 ` Thomas Gleixner
2015-06-08 17:55 ` John Stultz
2015-06-08 19:05 ` Thomas Gleixner
2015-06-08 20:02 ` Thomas Gleixner
2015-06-05 11:37 ` Prarit Bhargava
2015-06-05 12:07 ` Thomas Gleixner
2015-06-05 14:22 ` Richard Cochran
2015-06-05 17:24 ` John Stultz
2015-05-31 13:55 ` [RFC][PATCH 0/4] Fixes for leapsecond expiring early ABS_TIME CLOCK_REALTIME timers Prarit Bhargava
2015-06-01 11:57 ` Prarit Bhargava [this message]
2015-06-01 17:02 ` John Stultz
2015-06-01 17:43 ` Prarit Bhargava
2015-06-01 20:18 ` Daniel Bristot de Oliveira
2015-06-01 20:32 ` John Stultz
2015-06-01 21:42 ` Prarit Bhargava
2015-06-01 22:29 ` Daniel Bristot de Oliveira
2015-06-02 6:19 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556C48BD.9010201@redhat.com \
--to=prarit@redhat.com \
--cc=bristot@redhat.com \
--cc=jack@suse.cz \
--cc=jbohac@suse.cz \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=richardcochran@gmail.com \
--cc=shuahkh@osg.samsung.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).