From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753140AbbFANvo (ORCPT ); Mon, 1 Jun 2015 09:51:44 -0400 Received: from mail-la0-f41.google.com ([209.85.215.41]:35329 "EHLO mail-la0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753011AbbFANvg (ORCPT ); Mon, 1 Jun 2015 09:51:36 -0400 Message-ID: <556C6362.1010700@cogentembedded.com> Date: Mon, 01 Jun 2015 16:51:30 +0300 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Colin King , Greg Kroah-Hartman , Laurent Pinchart , Felipe Balbi , Sudeep Holla , linux-usb@vger.kernel.org CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH][V2] usb: isp1760: fix null dereference if kzalloc returns null References: <1433112223-4651-1-git-send-email-colin.king@canonical.com> In-Reply-To: <1433112223-4651-1-git-send-email-colin.king@canonical.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 6/1/2015 1:43 AM, Colin King wrote: > From: Colin Ian King > If kzalloc returns null then isp1760_ep_alloc_request performs > a null pointer dereference on req. Check for null to avoid this. I told you there's no dereference and yet you're repeating it again. :-( > Detected with smatch static analysis: > drivers/usb/isp1760/isp1760-udc.c:816 isp1760_ep_alloc_request() > error: potential null dereference 'req'. (kzalloc returns null) > Signed-off-by: Colin Ian King WBR, Sergei