From: "Martin Liška" <mliska@suse.cz>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: David Ahern <dsahern@gmail.com>,
a.p.zijlstra@chello.nl, paulus@samba.org, mingo@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf: introduce new two options for objdump.
Date: Mon, 01 Jun 2015 15:58:16 +0200 [thread overview]
Message-ID: <556C64F8.4000104@suse.cz> (raw)
In-Reply-To: <20150601125432.GE624@kernel.org>
On 06/01/2015 02:54 PM, Arnaldo Carvalho de Melo wrote:
> Em Mon, Jun 01, 2015 at 01:10:06PM +0200, Martin Liška escreveu:
>> On 05/20/2015 03:05 PM, Arnaldo Carvalho de Melo wrote:
>>> Em Wed, May 20, 2015 at 03:02:01PM +0200, Martin Liška escreveu:
>>>> On 05/19/2015 04:33 PM, Arnaldo Carvalho de Melo wrote:
>>>>> Em Tue, May 19, 2015 at 08:29:58AM -0600, David Ahern escreveu:
>
> <SNIP>
>
>>>>>> Perhaps it should be generalized a bit? Right now we have symfs for the
>>>>>> location of the tree for binaries. What about a srcfs for a source tree?
>>>>>
>>>>> That is a good idea indeed.
>>>>
>>>> I was motivated to be able to annotate source code, realized out-of-box. More precisely, on a machine A
>>>> I run perf record, I moved the report file to machine B and I use these options to annotate source code.
>
> <SNIP>
>
>>> I guess so, and yeah, the feature implemented in your patch has value,
>>> thanks for collaborating! It is just that it may fit better as a
>>> complement to the --symfs stuff, that is also for off-box analysis:
>
>>> --symfs=<directory>::
>>> Look for files with symbols relative to this directory.
>
>>> Thanks, will wait for further discussion before applying,
>
>> Are we going to wait any longer? It looks there's no discussion effort in this thread ;)
>
> I was waiting for you to follow thru on David's suggestion.
>
> - Arnaldo
>
Ah, I see.
My answer what kind of that a single new option is no going to enough. As explained in my previous
post, one needs to cut N components of a path and append a different path.
I would follow option names starting with --objdump prefix.
Thanks,
Martin
next prev parent reply other threads:[~2015-06-01 13:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 13:03 [PATCH] perf: introduce new two options for objdump Martin Liška
2015-05-19 14:08 ` Arnaldo Carvalho de Melo
2015-05-19 14:29 ` David Ahern
2015-05-19 14:33 ` Arnaldo Carvalho de Melo
2015-05-20 13:02 ` Martin Liška
2015-05-20 13:05 ` Arnaldo Carvalho de Melo
2015-06-01 11:10 ` Martin Liška
2015-06-01 12:54 ` Arnaldo Carvalho de Melo
2015-06-01 13:58 ` Martin Liška [this message]
2015-06-01 14:17 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556C64F8.4000104@suse.cz \
--to=mliska@suse.cz \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).