From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754298AbbFAXxd (ORCPT <rfc822;w@1wt.eu>);
	Mon, 1 Jun 2015 19:53:33 -0400
Received: from mail-gw1-out.broadcom.com ([216.31.210.62]:2198 "EHLO
	mail-gw1-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752249AbbFAXxW (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 1 Jun 2015 19:53:22 -0400
X-IronPort-AV: E=Sophos;i="5.13,536,1427785200"; 
   d="scan'208";a="66492622"
Message-ID: <556CF06F.7040402@broadcom.com>
Date: Mon, 1 Jun 2015 16:53:19 -0700
From: Arun Parameswaran <aparames@broadcom.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: David Miller <davem@davemloft.net>
CC: <ben@decadent.org.uk>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        <bcm-kernel-feedback-list@broadcom.com>, <rjui@broadcom.com>,
        <sbranden@broadcom.com>, <jdzheng@broadcom.com>
Subject: Re: [PATCH 1/1] net: core: 'ethtool' issue with querying phy settings
References: <20150531.171940.1635713770956335110.davem@davemloft.net>	<1433181931.6319.176.camel@decadent.org.uk>	<556CD197.8070401@broadcom.com> <20150601.144635.1116373189875340733.davem@davemloft.net>
In-Reply-To: <20150601.144635.1116373189875340733.davem@davemloft.net>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 15-06-01 02:46 PM, David Miller wrote:
> From: Arun Parameswaran <aparames@broadcom.com>
> Date: Mon, 1 Jun 2015 14:41:43 -0700
> 
>> It would be nice for the 'ethtool' to be flexible to support querying
>> specific PHY irrespective of the net implementation, but that is being
>> discussed in the other thread.
> 
> Please stop arguing about this, it isn't valid.
> 
> Your device is a switch, and therefore needs to be represented properly
> with the proper number of net_device objects.
> 
> Even more importantly, the ethtool API is established and you cannot
> change these semantics without potentially breaking lots of applications
> and libraries out there.
> 
> Your change is reverted, and I will absolutely not entertain any
> attempt to again change the semantics of this ethtool operation.
> 
> Thanks.
> 
I apologize if the patch broke any conventions, it was not my intend. I
understand the implications on other programs that use the interface.

Just so that I don’t make this mistake in the future and to understand this
better, does this mean that the 'phyad' parameter specified in the
'ethtool' command line is ignored ?

Thanks
Arun