From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754648AbbFBIH6 (ORCPT ); Tue, 2 Jun 2015 04:07:58 -0400 Received: from [185.25.241.215] ([185.25.241.215]:57996 "EHLO ducie-dc1.codethink.co.uk" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751394AbbFBIHx (ORCPT ); Tue, 2 Jun 2015 04:07:53 -0400 Message-ID: <556D643E.20903@codethink.co.uk> Date: Tue, 02 Jun 2015 11:07:26 +0300 From: Ben Dooks Organization: Codethink Limited. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Alexey Sokolov , oliver@neukum.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] cdc-acm: Add support of ATOL FPrint fiscal printers References: <20150602080526.GC6379@user-VirtualBox> In-Reply-To: <20150602080526.GC6379@user-VirtualBox> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/06/15 11:05, Alexey Sokolov wrote: > ATOL FPrint fiscal printers require usb_clear_halt to be executed > to work properly. Add quirk to fix the issue. > > Signed-off-by: Alexey Sokolov > --- > drivers/usb/class/cdc-acm.c | 9 +++++++++ > drivers/usb/class/cdc-acm.h | 1 + > 2 files changed, 10 insertions(+) > > diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c > index 5c8f581..9d8a321 100644 > --- a/drivers/usb/class/cdc-acm.c > +++ b/drivers/usb/class/cdc-acm.c > @@ -1477,6 +1477,11 @@ skip_countries: > goto alloc_fail8; > } > > + if (quirks == CLEAR_HALT_CONDITIONS) { > + usb_clear_halt(usb_dev, usb_rcvbulkpipe(usb_dev, epread->bEndpointAddress)); > + usb_clear_halt(usb_dev, usb_sndbulkpipe(usb_dev, epwrite->bEndpointAddress)); > + } > + Given quirks looks like a bitfield, it would be better if this is if (quirks & CLEAR_HALT_CONDITIONS) { -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius