From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757476AbbFBJoN (ORCPT ); Tue, 2 Jun 2015 05:44:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44562 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755750AbbFBJoB (ORCPT ); Tue, 2 Jun 2015 05:44:01 -0400 Message-ID: <556D7AE0.5010402@redhat.com> Date: Tue, 02 Jun 2015 05:44:00 -0400 From: Prarit Bhargava User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131028 Thunderbird/17.0.10 MIME-Version: 1.0 To: Viresh Kumar CC: linux-kernel@vger.kernel.org, Jonathan Corbet , "Rafael J. Wysocki" , Kristen Carlson Accardi , Dirk Brandewie , linux-doc@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH] Documentation, intel_pstate: Add a better description of the intel_pstate legacy mode internal governors References: <1433165764-4734-1-git-send-email-prarit@redhat.com> <20150602040249.GB10443@linux> In-Reply-To: <20150602040249.GB10443@linux> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/02/2015 12:02 AM, Viresh Kumar wrote: > On 01-06-15, 09:36, Prarit Bhargava wrote: >> This patchset was originally submitted and acked here >> >> http://marc.info/?l=linux-kernel&m=140203008832333&w=2 >> >> but lost at some point. >> >> P. >> >> ----8<---- > > I don't think this is the right place to have this information, you > should have added it after the three dashes below. (---). AFAIK "scissors" works for comments not to be included in the commit. > >> The current documentation is incomplete wrt the intel_pstate legacy >> internal governors. The confusion comes from the general cpufreq >> governors which also use the names performance and powersave. This patch >> better differentiates between the two sets of governors and gives an >> explanation of how the internal P-state governors behave differently from >> one another. >> >> Also fix two minor typos. >> >> Cc: Jonathan Corbet >> Cc: Prarit Bhargava >> Cc: "Rafael J. Wysocki" >> Cc: Kristen Carlson Accardi >> Cc: Dirk Brandewie >> Cc: linux-doc@vger.kernel.org >> Cc: Viresh Kumar >> Cc: x86@kernel.org >> Signed-off-by: Prarit Bhargava > > You could have carried my Ack :) :) I was uncomfortable carrying it TBH because I had changed the patch. P. > > Acked-by: Viresh Kumar >