Re: [PATCH] power: reset: gpio-restart: increase priority slightly

[Guenter Roeck <linux@roeck-us.net>]

On 06/02/2015 07:48 AM, Heiko Stübner wrote:
> gpio-restart uses a priority of 128 and currently most soc-level restart
> mechanisms use the same - with some exceptions even using 192.
> But while the soc-level restarts are provided by the soc itself,
> gpio-restarts will most of the time be board-specfic and be used
> when some special board condition makes the soc-level restart
> only a second choice.
>
> The problem at hand manifested itself on the rk3288-veyron devices.
> While the soc-level restart can sucessfully restart all other rockchip
> boards I have, the veyron devices use an external restart mechanism that
> seems to not only reset the soc but also some external needed components.
>
> With both restart handlers having priority 128 in my tests the soc-specific
> variant took precedent in all cases. While it could restart the soc
> sucessfully in all cases, firmware then got an issue when talking to an
> external component, resulting in the device being put into recovery mode.
>
> So, give the board-specific restart handler a slight push and move it
> to priority 129 to make it more important than the generic soc-specific
> restart-handler.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>

Makes sense.

Reviewed-by: Guenter Roeck <linux@roeck-us.net>