From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759425AbbFBP0D (ORCPT ); Tue, 2 Jun 2015 11:26:03 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:55174 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759283AbbFBPZy (ORCPT ); Tue, 2 Jun 2015 11:25:54 -0400 Message-ID: <556DCAFE.5050304@roeck-us.net> Date: Tue, 02 Jun 2015 08:25:50 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: =?windows-1252?Q?Heiko_St=FCbner?= , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse CC: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] power: reset: gpio-restart: increase priority slightly References: <4893951.aWdOo6F7tl@diego> In-Reply-To: <4893951.aWdOo6F7tl@diego> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/02/2015 07:48 AM, Heiko Stübner wrote: > gpio-restart uses a priority of 128 and currently most soc-level restart > mechanisms use the same - with some exceptions even using 192. > But while the soc-level restarts are provided by the soc itself, > gpio-restarts will most of the time be board-specfic and be used > when some special board condition makes the soc-level restart > only a second choice. > > The problem at hand manifested itself on the rk3288-veyron devices. > While the soc-level restart can sucessfully restart all other rockchip > boards I have, the veyron devices use an external restart mechanism that > seems to not only reset the soc but also some external needed components. > > With both restart handlers having priority 128 in my tests the soc-specific > variant took precedent in all cases. While it could restart the soc > sucessfully in all cases, firmware then got an issue when talking to an > external component, resulting in the device being put into recovery mode. > > So, give the board-specific restart handler a slight push and move it > to priority 129 to make it more important than the generic soc-specific > restart-handler. > > Signed-off-by: Heiko Stuebner Makes sense. Reviewed-by: Guenter Roeck