From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752423AbbFBX4J (ORCPT <rfc822;w@1wt.eu>);
	Tue, 2 Jun 2015 19:56:09 -0400
Received: from mailout1.w1.samsung.com ([210.118.77.11]:35130 "EHLO
	mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750704AbbFBXz7 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 2 Jun 2015 19:55:59 -0400
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
X-AuditID: cbfec7f5-f794b6d000001495-51-556e428ce005
Content-transfer-encoding: 8BIT
Message-id: <556E428B.8070008@samsung.com>
Date: Wed, 03 Jun 2015 08:55:55 +0900
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101
 Thunderbird/31.7.0
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>,
        linux-samsung-soc@vger.kernel.org
Cc: Kukjin Kim <kgene@kernel.org>,
        =?UTF-8?B?6rmA7ZWZ7KO8?= <ruppi.kim@hardkernel.com>,
        Tomasz Figa <tomasz.figa@gmail.com>,
        Humberto Naves <hsnaves@gmail.com>,
        Jan Kiszka <jan.kiszka@siemens.com>,
        Johann Pfefferl <johann.pfefferl@siemens.com>,
        Ben Gamari <bgamari.foss@gmail.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 5/5] ARM: dts: Add LEDs to exynos5410-odroidxu
References: <1426456834-6308-1-git-send-email-afaerber@suse.de>
 <1426456834-6308-6-git-send-email-afaerber@suse.de>
 <556DA96A.90800@samsung.com> <556DB1E2.5080607@suse.de>
In-reply-to: <556DB1E2.5080607@suse.de>
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrLLMWRmVeSWpSXmKPExsVy+t/xa7o9TnmhBn2TBCyaNxVbLF8lZfH/
	0zM2i3s3bzJbrPk9gcXi9QtDi/7Hr5ktNj2+xmpxedccNosZ5/cxWbyYcY/dYtWuP4wOPB47
	Z91l9zh98x2Tx6ZVnWwem5fUe/RtWcXosf3kJCaPzaerPT5vkgvgiOKySUnNySxLLdK3S+DK
	uH12NlPBf46KTQ0fmRoYZ7B3MXJySAiYSLw7No0RwhaTuHBvPVsXIxeHkMBSRokbSz4ygSR4
	BQQlfky+x9LFyMHBLCAvceRSNoSpLjFlSi5E+VNGiXMfVjBClGtJLPpzgxnEZhFQlXh78iMb
	iM0mYCyxefkSMFtUIELi7eWTYONFBGIkfk36zwQyiFngBZPE8UnHWUESwgKuEtsnbmaC2LCe
	UeLfvI8sIAlOoM3/9hxlnMAoMAvJfbMQ7puFcN8CRuZVjKKppckFxUnpuUZ6xYm5xaV56XrJ
	+bmbGCGR8nUH49JjVocYBTgYlXh4GT7lhAqxJpYVV+YeYpTgYFYS4fURywsV4k1JrKxKLcqP
	LyrNSS0+xCjNwaIkzjtz1/sQIYH0xJLU7NTUgtQimCwTB6dUA+O5a7u6v6ozf7dZ4VkQtCej
	tWvC+naN7qcX7weH7lx9lWuHym2FebdyGvJlTpnsexCro/1QoP1QX5j9NZ5ZM9Q7omyyGnfs
	fKj75KXLj6qO6R+ZjstcEtn65HRWl8+fc8+11KR4b7cV889IOMF9WqJDJK+a2WH+QdVN76aW
	pic/83gfohHqNU+JpTgj0VCLuag4EQCHho+OkAIAAA==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 02.06.2015 22:38, Andreas Färber wrote:
> Am 02.06.2015 um 22:02 schrieb Krzysztof Kozlowski:
>> W dniu 16.03.2015 o 07:00, Andreas Färber pisze:
>>> Signed-off-by: Hakjoo Kim <ruppi.kim@hardkernel.com>
>>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>>> ---
>>>  v2 -> v3: Unchanged
>>>  
>>>  v1 -> v2:
>>>  * Filled in Sob from Hakjoo Kim
>>>  
>>>  arch/arm/boot/dts/exynos5410-odroidxu.dts | 25 +++++++++++++++++++++++++
>>>  1 file changed, 25 insertions(+)
>>
>> What is the rationale behind doing this in separate patch, not as part
>> of 2/5? You can just add new board DTS with all of its features at once,
>> but maybe I am missing something?
> 
> This patch depends on the pinctrl driver, 2/5 on nothing.
> 
> By keeping it a separate patch it was intended to go in more quickly
> (clear fail there ;)) and it's easier to review the actual changes -
> squashing is always easier than picking apart.

OK, I'm fine with it.

The patch looks good:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Can you resend everything with the change in chosen/console?

Best regards,
Krzysztof