From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753204AbbFCGpu (ORCPT ); Wed, 3 Jun 2015 02:45:50 -0400 Received: from bhuna.collabora.co.uk ([93.93.135.160]:41981 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750774AbbFCGpl (ORCPT ); Wed, 3 Jun 2015 02:45:41 -0400 Message-ID: <556EA28C.2080200@collabora.co.uk> Date: Wed, 03 Jun 2015 08:45:32 +0200 From: Javier Martinez Canillas User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.2.0 MIME-Version: 1.0 To: =?windows-1252?Q?Heiko_St=FCbner?= CC: Lee Jones , Samuel Ortiz , Olof Johansson , Doug Anderson , Bill Richardson , Simon Glass , Gwendal Grignou , Stephen Barber , Filipe Brandenburger , Todd Broch , Alexandru M Stan , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v4 0/8] mfd: cros_ec: Add multi EC and proto v3 support References: <1433232671-27679-1-git-send-email-javier.martinez@collabora.co.uk> <2123062.dmIBPlf795@diego> In-Reply-To: <2123062.dmIBPlf795@diego> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Heiko, On 06/02/2015 11:15 PM, Heiko Stübner wrote: > Am Dienstag, 2. Juni 2015, 10:11:03 schrieb Javier Martinez Canillas: >> Hello, >> >> Newer Chromebooks have more than one Embedded Controller (EC) in the >> system. These additional ECs are connected through I2C with a host EC >> which is the one that is connected to the Application Processor (AP) >> through different transports (I2C, SPI or LPC). >> >> So on these platforms, sub-processors are chained to each other: >> >> AP <--> Host EC <--> Power Delivery (PD) EC >> >> The AP sends commands to the additional EC through the host EC using >> a set of passthru commands and the host redirects to the correct EC. >> >> This is a v4 of a series that adds support for multiple EC in a system >> and also for the protocol version 3 that is used on newer ECs. >> >> Most patches were taken from the downstream ChromiumOS v3.14 tree with >> fixes squashed, split to minimise the cross subsystem churn and changes >> for mainline inclusion but were not modified functionality wise. >> >> This version addresses a lot of issues pointed out by Lee Jones on the v3 >> posted before [0]. >> >> The patches are based on top of "[PATCH 0/2] mfd: cros_ec: Small cleanups" >> [1] that were posted before and was already picked by Lee Jones. >> >> Testing was done on some Chromebooks that have a single EC and support >> protocol v2 such as the Exynos5250 Snow, Exynos5420 Peach Pit and Exynos5800 >> Peach Pi to be sure that no regressions were introduced for these machines. > > I just gave this a try on veyron and everything still works as expected. > > All patches except "[PATCH v4 6/8] mfd: cros_ec: Support multiple EC in a > system" already have Tested-by tags, so this patch now is also > > Tested-by: Heiko Stuebner > Thanks a lot for testing the series again. Now let's wait for Olof to review/ack/provide feedback on patches #1-#6 that touches drivers/platform/chrome, so Lee can merge through his tree. > > Heiko > Best regards, Javier