From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932092AbbFCSDL (ORCPT <rfc822;w@1wt.eu>);
	Wed, 3 Jun 2015 14:03:11 -0400
Received: from terminus.zytor.com ([198.137.202.10]:36331 "EHLO mail.zytor.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752967AbbFCSDF (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 3 Jun 2015 14:03:05 -0400
Message-ID: <556F411A.1050409@zytor.com>
Date: Wed, 03 Jun 2015 11:02:02 -0700
From: "H. Peter Anvin" <hpa@zytor.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Ingo Molnar <mingo@kernel.org>, Andy Lutomirski <luto@amacapital.net>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Denys Vlasenko <dvlasenk@redhat.com>, Brian Gerst <brgerst@gmail.com>,
        Peter Zijlstra <peterz@infradead.org>, Borislav Petkov <bp@alien8.de>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Oleg Nesterov <oleg@redhat.com>, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC PATCH 0/7] x86/entry: Create a home for the x86 entry code
 in arch/x86/entry/
References: <1433350757-14247-1-git-send-email-mingo@kernel.org> <CALCETrXCjbmSyHd_wpzjOPBFS5WYbujC84cChQbU+Cq4F8uxRw@mail.gmail.com> <CALCETrWOPx=Vhe8bC6a-OfH3VBP9xtETNWBP5ERuy3Yif+8sFA@mail.gmail.com> <20150603171332.GD14389@gmail.com>
In-Reply-To: <20150603171332.GD14389@gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/03/2015 10:13 AM, Ingo Molnar wrote:
>>>
>>> Anyway, I like this series except patch 7.
>>>
>> I can't count.  I mean all except patch 3 (the vdso one), not 7.
>>

Same here... erk.

>> Although arch/x86/entry might be less of a mouthful.
> 
> So see my reply to hpa: it makes sense to collect all things system calls and 
> other entry code in a single place, instead of having it scattered all around.
> 
> Its internal organization is kept intact, so the vDSO code isn't mixed with other 
> bits.

That really doesn't change the fact that it is a completely different
beast, and putting it under entry/ is actively misleading.  Having vdso/
as a separate top level is a good thing, I believe.

I really dislike deep hierarchies, as I said, because my experience has
been that they are more confusing than they are helpful, especially over
time.  The arch-example of badness is of course arch/x86/kernel, which
is a total catch-all, but

	-hpa