From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751910AbbFDCEe (ORCPT ); Wed, 3 Jun 2015 22:04:34 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:30110 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750856AbbFDCEZ (ORCPT ); Wed, 3 Jun 2015 22:04:25 -0400 X-AuditID: cbfec7f5-f794b6d000001495-c0-556fb2258ce4 Message-id: <556FB222.2070406@samsung.com> Date: Thu, 04 Jun 2015 11:04:18 +0900 From: Krzysztof Kozlowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-version: 1.0 To: Michal Suchanek , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Kukjin Kim , Vinod Koul , Dan Williams , David Woodhouse , Brian Norris , Han Xu , Mark Brown , Geert Uytterhoeven , Marek Vasut , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Alison Chaiken , Huang Shijie , Ben Hutchings , Knut Wohlrab , =?UTF-8?B?IkJlYW4gSHVvIOmcjeaWjOaWjCAoYmVhbmh1byki?= , "grmoore@altera.com" , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, dmaengine@vger.kernel.org, linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org Subject: Re: [PATCH 11/11] dt: Exynos: add Snow SPI NOR node. References: <3234c12c90eabbeeb6d33604a324231937e309ec.1433364398.git.hramrach@gmail.com> In-reply-to: <3234c12c90eabbeeb6d33604a324231937e309ec.1433364398.git.hramrach@gmail.com> Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02Sf0yMcRzHfZ/nuefu4ubprvJdDLvWTHQVmc+EmX88Y4xNtPyhqx4VXZe7 aq6NfihWc/1UcnKlH1Ku4m7WL6dVpzTkaCISraJcMVZptcIVW/+9Pnv/+ucjIMW/KFdBRFQM p4qSR0ppB+rpfMdrT3ej0t87/ZkvdFmOgVW3BloG0igozn+JIG9giAaLtZqEa3lWBEWWLh7c zZvjQXZlLgmZY7d4cPNGDoKCuhEapq628KCuhoKur5UIbCM+kDloI6HG2ECDcbCHB92NhTQ0 Jd/mQ8GLRwQk/ejlw/tuEYxdSkJQ/uYlAVnXqilINVv4MJrRTIGhk9uzjk01Z9GsQW9AbMrF KzTbnaEl2KL6CcRa23sIVq97QrHzbZkEm/3ck23QfeCzlRUTNGu648GWPhwlWGNV2t+rLIFt mkxGhyWBDjtDuciIOE7ltTvIIfzyvSYiel54bm7qLZ2IZvnpSCjAjC9ONAz/Yxds7a+l7Sxm yhHO1O5KRw5/eRhhW8oXnl0QMR749++xhQDFuGNt+bcFppmt2FRRthB2ZgLweHcnseh3xNO5 /ZS9yIkpEOIMax5pFyTMLvzkcd+/tRSEZ3ou2FnInMCD5p6FMZLZgHP0JeQir8MmwziZhVbq lvTqlth0S2zFiKxCzlxsSLQ6OEyxRaaWK9SxUWGyEKXCiBbfYbIelbfvaEWMAElXiAoCovzF PHmcWqNoRVhASp1Eti1Kf7EoVK6J51TKk6rYSE7dilYLKOkq0fXG70fFTJg8hjvDcdGc6r9K CISuiSjHpUT/c5lkJpzepPHSf76y3T2td99w37ukj4Tz/gcJzKe4wleyipXHD21zFgEZ3ZLm IzvgNhuYMGbTcBLFxjORejdNsrl0bUviXJAp3ntoOL5Mdv6sygL3vfyC2yTTqGpzvvKZljy1 V197sNkl/0jHae3y6bOtzY5Bfub1pnQppQ6X+3iQKrX8DxNb47gKAwAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04.06.2015 06:26, Michal Suchanek wrote: > The Snow has onboard SPI NOR flash which contains the bootloader. > > Add DT node for this flash chip. The flash is rated 133MHz but the pl330 > controller can transfer only up to 128 bytes at this speed so use more > conservative settings. Even at 40MHz pl330 can transfer at most 64k with > the current driver. > > Signed-off-by: Michal Suchanek > --- > arch/arm/boot/dts/exynos5250-snow.dts | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts > index 1fa72cf..38e4cda 100644 > --- a/arch/arm/boot/dts/exynos5250-snow.dts > +++ b/arch/arm/boot/dts/exynos5250-snow.dts > @@ -691,6 +691,18 @@ > num-cs = <1>; > cs-gpios = <&gpa2 5 0>; > status = "okay"; > + flash: m25p80@0 { The indentation looks odd. This should be at the same level as "status". > + #address-cells = <1>; > + #size-cells = <1>; > + compatible = "jedec,spi-nor"; > + reg = <0>; > + spi-max-frequency = <40000000>; So actually you wanted 133 MHz but as a workaround for DMA issue you use 40 MHz, right? Could you add here a small TODO note in comment about it? Best regards, Krzysztof