From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4176129E10F; Wed, 28 Jan 2026 10:01:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769594505; cv=none; b=bIS3UqIQU14G0eykoPi1rkbEI4tDepAGcv4nxFwtBeMy3XP1gb3GTQJ/4UjGVw30AjE36B7DFBxOl0XAXOwRWvlDTBDj90xIC9FGmysmWric8qNrGc8DfkWtDnSRz7IT4WCM7QLSPViG34lJYFQTaHoWJJlxnhohxQNSCmSBNFU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769594505; c=relaxed/simple; bh=huqBKPmdl/GVuwuvQQaYj2vAnPUUV2fdFitGPsGL5rc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SgM8ym3oZm345mMbTRWEWEAzJfxwPNSAbaAmjFbEBYN14zk4L7TBelvDvwfc0fLvyzGsKWPQMDmVbXoKwwtRTm3zDVVYEQOwzAzU7K5fBJS2B37yxzkHPJ7NzsuOBH8jJU4Nus3BOgQLAaGaTqVSzzR51aJGEVEdQghe2honCwU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UsFdmFQK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UsFdmFQK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75251C4CEF1; Wed, 28 Jan 2026 10:01:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769594504; bh=huqBKPmdl/GVuwuvQQaYj2vAnPUUV2fdFitGPsGL5rc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=UsFdmFQKnqzBxotq9pxKSI0+GDJWmu4+WszT+rFwLRwl70XrqWN79LKZPahCdABGN zZO+g+bYSdnTn+GZhMwNYu4kPCBJcXaXq0tsTjJyNmIBbF4zVeuO+49i2HwDQJ2euf GDkgrMiFGwkjjDnap1AV6xWA6tTdOh26jmm7MS9PyCovrHIka0VGwJwu9ZaxxS0Vxp XUnyOg7gUMaUFJG1nV9fEklSpS02GCJfWjsLSUTiHWYcuNshuHjqkSq87vBajJMBUI 7BB9cAMbVlOKVrEvM4O8l7QrBnck34qPo9mI/1Ljb+A+02hRyxv9FYSW+f3Wj2ZQ9v wyTLeL8eftDvA== Message-ID: <556bf15b-727a-4eff-92c7-9fc6c744047b@kernel.org> Date: Wed, 28 Jan 2026 11:01:40 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/3] dt-bindings: reset: add sky1 reset controller To: Gary Yang , lee@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, p.zabel@pengutronix.de, peter.chen@cixtech.com Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, cix-kernel-upstream@cixtech.com References: <20260128093611.1932770-1-gary.yang@cixtech.com> <20260128093611.1932770-2-gary.yang@cixtech.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <20260128093611.1932770-2-gary.yang@cixtech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 28/01/2026 10:36, Gary Yang wrote: > There are two reset controllers on Cix sky1 Soc. > One is located in S0 domain, and the other is located > in S0 and S5 domain. Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 > > Signed-off-by: Gary Yang > Link: https://lore.kernel.org/r/20251124063235.952136-2-gary.yang@cixtech.com > Signed-off-by: Peter Chen > --- > .../devicetree/bindings/mfd/syscon.yaml | 7 + > .../bindings/reset/cix,sky1-rst.yaml | 46 +++++ > .../soc/cix/cix,sky1-system-controller.yaml | 48 +++++ > include/dt-bindings/reset/cix,sky1-rst-fch.h | 42 +++++ > include/dt-bindings/reset/cix,sky1-rst.h | 164 ++++++++++++++++++ > 5 files changed, 307 insertions(+) > create mode 100644 Documentation/devicetree/bindings/reset/cix,sky1-rst.yaml > create mode 100644 Documentation/devicetree/bindings/soc/cix/cix,sky1-system-controller.yaml > create mode 100644 include/dt-bindings/reset/cix,sky1-rst-fch.h > create mode 100644 include/dt-bindings/reset/cix,sky1-rst.h > > diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml > index 55efb83b1495..be864a6b8efb 100644 > --- a/Documentation/devicetree/bindings/mfd/syscon.yaml > +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml > @@ -170,6 +170,8 @@ properties: > - cirrus,ep7209-syscon1 > - cirrus,ep7209-syscon2 > - cirrus,ep7209-syscon3 > + - cix,sky1-system-controller > + - cix,sky1-s5-system-controller > - cnxt,cx92755-uc > - freecom,fsg-cs2-system-controller > - fsl,imx93-aonmix-ns-syscfg > @@ -254,6 +256,11 @@ properties: > - const: microchip,pic64gx-sysreg-scb > - const: microchip,mpfs-sysreg-scb > - const: syscon > + - items: > + - enum: > + - cix,sky1-system-controller > + - cix,sky1-s5-system-controller > + - const: syscon Do not create your own style. Cix is not special. There is already an enum for EVERYONE. > > reg: > maxItems: 1 Independent patch. Please do not combine unrelated patches into one. > diff --git a/Documentation/devicetree/bindings/reset/cix,sky1-rst.yaml b/Documentation/devicetree/bindings/reset/cix,sky1-rst.yaml > new file mode 100644 > index 000000000000..4323acdc2c45 > --- /dev/null > +++ b/Documentation/devicetree/bindings/reset/cix,sky1-rst.yaml > @@ -0,0 +1,46 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/reset/cix,sky1-rst.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: CIX Sky1 Reset Controller > + > +maintainers: > + - Gary Yang > + > +description: | > + CIX Sky1 reset controller can be used to reset various set of peripherals. > + There are two reset controllers, one is located in S0 domain, the other > + is located in S0 and S5 domain. > + > + See also: > + - include/dt-bindings/reset/cix,sky1-rst.h > + > +properties: > + compatible: > + items: > + - enum: > + - cix,sky1-rst > + - cix,sky1-rst-fch > + > + '#reset-cells': > + const: 1 No resources? Then not a dedicated child node, but part of the syscon. Fold this entire binding into the parent node. > + > +required: > + - compatible > + - '#reset-cells' > + > +additionalProperties: false > + > +examples: > + - | > + syscon@16000000 { > + compatible = "cix,sky1-s5-system-controller", "syscon", > + "simple-mfd"; Mess alignment. > + reg = <0x0 0x16000000 0x0 0x1000>; Does not belong here. > + src: reset-controller { > + compatible = "cix,sky1-rst"; > + #reset-cells = <1>; > + }; > + }; > diff --git a/Documentation/devicetree/bindings/soc/cix/cix,sky1-system-controller.yaml b/Documentation/devicetree/bindings/soc/cix/cix,sky1-system-controller.yaml > new file mode 100644 > index 000000000000..f6e2776e3f53 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/cix/cix,sky1-system-controller.yaml > @@ -0,0 +1,48 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/cix/cix,sky1-system-controller.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cix Sky1 SoC system controller register region > + > +maintainers: > + - Gary Yang > + > +description: > + An wide assortment of registers of the system controller on Sky1 SoC, > + including resets and usb. > + > +allOf: > + - $ref: /schemas/mfd/syscon.yaml# > + > +properties: > + compatible: > + oneOf: > + - contains: What? No, don't come with random code. There is no single code like this. > + - enum: > + - cix,sky1-system-controller > + - cix,sky1-s5-system-controller > + - const: syscon > + - const: simple-mfd Huh? You already documented this. NAK, you are making random changes without any concept. Read previous feedback. Really carefully. Best regards, Krzysztof