From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753644AbbFDPcZ (ORCPT ); Thu, 4 Jun 2015 11:32:25 -0400 Received: from mail-bn1on0077.outbound.protection.outlook.com ([157.56.110.77]:56288 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751306AbbFDPcV (ORCPT ); Thu, 4 Jun 2015 11:32:21 -0400 Authentication-Results: spf=fail (sender IP is 66.35.236.227) smtp.mailfrom=opensource.altera.com; gmail.com; dkim=none (message not signed) header.d=none; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=dinguyen@opensource.altera.com; Message-ID: <55706E25.8050105@opensource.altera.com> Date: Thu, 4 Jun 2015 10:26:29 -0500 From: Dinh Nguyen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: , , , , , , , , , , CC: , , , , , Subject: Re: [PATCHv2 2/4] edac, altera: Refactor EDAC for Altera CycloneV SoC. References: <1433428128-7292-1-git-send-email-tthayer@opensource.altera.com> <1433428128-7292-3-git-send-email-tthayer@opensource.altera.com> In-Reply-To: <1433428128-7292-3-git-send-email-tthayer@opensource.altera.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: BN1PR08CA0048.namprd08.prod.outlook.com (10.242.217.176) To BY1PR03MB1370.namprd03.prod.outlook.com (25.162.109.28) X-Microsoft-Exchange-Diagnostics-untrusted: 1;BY1PR03MB1370;2:B9xu0c9tw5O1nQmkTDiVTjs65ciK6k2x7axqRuc843KyvLLDnCwhuQWhDUZCGBnD;2:51ZhCiZh/ikKqHo+s0talS69mOlQTOHeB6AtLQEniPiZCkNzSzh4lO6ALSoP+QGGYN37voits1A0h2hSlQjxgliWPx5goqSDnc7lpbGPiUdkriky4IQvcw8wkCwGmjc6hOf3ZoAGoE0Njp+9cq6Oqg==;6:sgPjGeHyUHT9aqpX7MKDuvSiWyju+epFqDvR/NdzdiKk7ckFqD2VFUDlLgS5093wFZsYv3DzHO5ixQS2KrvfPBXrldeLrSEapfznIoOsClCgA7SC1dn+X6TOCa1yVFY919h+GPXco20+2LLx9b6xew==;3:XXnvoDUx3CTy1nzeTsecz3ehJ2JgjQCbNWUKcj4Te3XHOKQvDH8FLppv5Xl/iHnAZwxJdyPohdjcyS/xIxxHgp9z4Ic4/6wiC+cHsNRjVKdv9vzvO+9qI0EJJ1mdjIj+LZ9gvBRs8oygM36X2lyKTBTa4aP5d5bB3QToG1W3X23+Oi0X1v3sYAugI1yu39ijtYW2rqWfiBgyISFttu1x8K247eJJW2f6QjQT5yoNCmQwoNh+6EcVjZpwxMlM+k1P5cXWiRd3u1mSUwThyigMNmQUZyl/J+UpXJLiL+4gkaoB9T6J3j20u6PN+ub+Ye4E X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1370;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR03MB238; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:;UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(520003)(3002001);SRVR:BY1PR03MB1370;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1370;BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:BY2PR03MB238;BCL:0;PCL:0;RULEID:;SRVR:BY2PR03MB238; X-Forefront-PRVS: 0597911EE1 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(6009001)(6049001)(24454002)(199003)(189002)(377454003)(51704005)(479174004)(65816999)(50466002)(50986999)(2201001)(23746002)(105586002)(54356999)(87266999)(68736005)(76176999)(46102003)(101416001)(99136001)(77096005)(64126003)(83506001)(86362001)(47776003)(87976001)(59896002)(2950100001)(5001920100001)(19580405001)(65956001)(19580395003)(64706001)(5001960100002)(5001860100001)(97736004)(92566002)(33656002)(42186005)(122386002)(106356001)(80316001)(4001540100001)(77156002)(40100003)(189998001)(5001830100001)(4001350100001)(66066001)(81156007)(5001770100001)(65806001)(62966003)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR03MB1370;H:[137.57.160.210];FPR:;SPF:None;PTR:InfoNoRecords;A:0;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?Windows-1252?Q?1;BY1PR03MB1370;9:n0UYVv2D/fzt7UdKXKxRN2HhhpD6IkxgaHvrZy?= =?Windows-1252?Q?KiunBvjk4h7Xd4+v+XtQzEw4PnLiVFggfPW6HrDa2462fF0RXsw7U1+p?= =?Windows-1252?Q?Vj/teA9nfJD1WKIUT3vsj+bM9yqHWs6p2fbzR4kKfiAFVvhSFZwPqTV/?= =?Windows-1252?Q?EOlk6pDaugmZQ/dkRu3u6oZYFfdKY4+ozlNPH0qj41rspyZSYMrT5sEA?= =?Windows-1252?Q?8r1yiqGUiAGAOlg+qxyRPVuzP0qAY6L+PQPH2IOToogAH8O8dko8hh6H?= =?Windows-1252?Q?znBEanr85QvJI9aJSOA1ThJ4qfFjsrYeWqOSiXmTgfmFRQUpqt1JsC/X?= =?Windows-1252?Q?XDts8bv2LfA/Cauju+p1Hzlphe4+ttfsrITI6wsikWmkDE6EZpK7yNIO?= =?Windows-1252?Q?/tgzsrMOEvjXsLxkvODbnMk2KNeTB5LgTxLu5BLGM8M0UzVLVQmuGkA7?= =?Windows-1252?Q?LnAC7HKwiIr+7UDluUNfi0JPN/k9fnRdULPq7GGBrzgDybUwgbQWR+yh?= =?Windows-1252?Q?vGY4zwwIWj91wDzsednXe29z+akxD+4nuHfocS7+nKfiS/OXicJcxj+G?= =?Windows-1252?Q?fF39XgQB7quyfKbx7v8afBt+UtRCyKIitE2r2abhUWfAGN3SpU+NBAlk?= =?Windows-1252?Q?co5kpmKGdFzfF3kzlhmZOxX3TMxDhqH4eC7JqZke4vPgj6T7IEoS6Gtm?= =?Windows-1252?Q?404MM+AnutsqLyhudS4kvDivlRqqSS39h7K2MnS4SMhbz1ajFzxmreE5?= =?Windows-1252?Q?QtJ4zj53S4qWjLyU5BMdb0zTHgQHkI9i9CtuD4988Akijuy1WoUpKa90?= =?Windows-1252?Q?uZ335vXmJeruMXVuRKaxRpNFSFu9qg/7HafCahgOf7wzfXae/+CzVqYi?= =?Windows-1252?Q?+LsNIDJ1HCgqLaGXZdbqrgV7nifjvMArWgZjK3BJdriQ9wHwfNWZ0r7B?= =?Windows-1252?Q?gVuc+EWygG655GIVmG/ek73el+gegF47BzWIliE+8ceUr18MQiPkNPS2?= =?Windows-1252?Q?0yXRJqjh1YEaYDonJsdv1k/FjfgYNJA9fAhckr+j/BUngoRh0n/JL4do?= =?Windows-1252?Q?p9FIBlus39gRwMTupWvvrXRSvqiCa8Y3aKXmkO3/FP/DQkJ1aqrzV+zz?= =?Windows-1252?Q?f8F0hPTCV/xXKuIlvAZJnINwLqLxSZZjLzjdPR9Ksr3HRDG+srPGyBx5?= =?Windows-1252?Q?pz1M3K8bVMbQNhuzfWcUlqDGCkkvT3n5iaunD/TgI9fLY4EIZr+9OsZ5?= =?Windows-1252?Q?JcyiiQfAq8EDYlL4aYMINrKEUlcEYoBSBqRSoKMvrkjcapPja/xRQx7+?= =?Windows-1252?Q?RCXlRNZa2s45WrU5MrsABZPBIT//52fvtXsCDR8c/b8tHmBi8ssK36+7?= =?Windows-1252?Q?rF+DTTOmbgNbXiH6jLj/2am541fJXqAqfeKcThbD1r6NZWZfxYAFmHLh?= =?Windows-1252?Q?Vl/LTuaheJUm0tL7XsFEXTXB9CjUoiaDYtXvTedbrTOMCApnEj62cjUB?= =?Windows-1252?Q?YLbvD3QSLxUF2+/X28MJ9eqMP/u/pWbOiWjRm17tJJ3Y0hpQ=3D=3D?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;BY1PR03MB1370;3:7n35Xr0ONjbWEbHbNHgyvQwQ1Sl1VAidC4HO4fK76f0V9oZJ+957cA8zTijMc7IMQZzI4TKlGdg9J2JvCsxckIel7QxqwGMS3dbjJ6g70QotJEh3cJ5ejWgS69SjfwX71L8ZIKDkUEj9PZezozGgQQ==;10:n/Sw3f2K8UfDvdkAlXPUtyMOqLeuJDZInW+XXcTTHtTCr7H7BpWgSHi/LLOslRVLrf2YWInphqAmwVCc2PECMwW8Mv+ibutQDiqCicevWGs=;6:HG5F9Lm0WTTIetNRn3DJvk0w5I9RCAlgh1iLHhwEyMxYU1OgyBFNRHi40ew7AJKZo48nE57Yfc6VwvwxKXioGnk4o9o9G6e6woKezEDQJp910kUj895lgLts9tSGZ3jjxDtWeY63480kChuI77fyEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1370 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BL2FFO11FD041.protection.gbl X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD041;1:2pUL1XrUJagx+qs4rBgEzkvmUwxqLbrgtafZc/nHwZ3hz8YKMYWn678UxeCh9Dj46UoTtIsU6yDEEctFRu1C/AKLhbp5moxO+8fsMx/2EaS98HiYcDq68b6v5JHOJJzQ2b6HQJDybjv0IjU9CFd4xoM3CHFOZdf5PrZrWwR1b5P+LnieREveuiHXd3rIvld9gfjqF9a/DEBq1MJIPsTsRvRO5lgFgMMpZXGlBd0qewoUGulTu9rntSKmvdsuef5l0uPZ7CeXiK1RGbZ/xQzZ6boNkh1+V5e9oWsNqP+6iiNC6ZWujoD+73SRTQpbJ+6Nh7M2hupDepqkv3jjksBo1w== X-Forefront-Antispam-Report: CIP:66.35.236.227;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(339900001)(189002)(199003)(377454003)(51704005)(24454002)(479174004)(189998001)(76176999)(54356999)(77156002)(62966003)(46102003)(50986999)(87266999)(77096005)(59896002)(2201001)(16796002)(64126003)(85426001)(5001770100001)(6070500001)(99136001)(19580405001)(97736004)(90366008)(68736005)(4001350100001)(4001540100001)(5001960100002)(81156007)(87936001)(105606002)(80316001)(83506001)(5001830100001)(5001860100001)(2950100001)(122386002)(5001920100001)(40100003)(50466002)(33656002)(6806004)(47776003)(106466001)(23746002)(65816999)(86362001)(66066001)(65956001)(92566002)(19580395003)(64706001)(65806001)(7099028)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR03MB238;H:sj-itexedge03.altera.priv.altera.com;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;MX:1;A:0;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB238;2:BBWXl1o3och9E6g28g6zjvtcB4ZbRuKREMyKhqiww1eQlVGiPbbjg0JV1s3Jm9nW;2:88uRVQk8fxdjCfOUZi2TfAFmTIRNb30eu6kCbg8yD8Tnals+Wqzky8D7vhWfR/wpvDgVrNXMWR/2qGFGyCP2LOiR8eB5M9kBHJ/kKw895hvBTwW4x7KJ81j7P0aAtmLnUY42UOQm7jcro+dNxpJBHFP/1Ix3wKdnh81HFxv9YhPL6KH4hdFqGz/v7Tf1yuk8vUktwURtweg9Bv2nBNcNKRlUq67HuOPOrXHIdGWl1nI=;6:cspMU2+m5KHZNyI3kHtyLkW7qW6V527nIBAWNA7NXTT0sxEDD1DkeAMzNs05RZMrEflGxGNRVi6XAkDwLH+w7LQbexCUHtQ99yYdiOaEmVPIRJ5RAGDaQXzl0t0JgWgIyhwr2lu09njT+o6krdUNRw==;3:raJrPD5MEtw66O0XOLYU614b4Yh89y8BYelXt9vfZejmZ2m6jo/3Q/KS4J7/TJ2Gb862Rd3AZ0Q5Euq3tkrcI+01+/yGLCBsc2NcKyAxpYq0+BQ4TGHrFL7gY41d2Z1m7noOnC3YmV6qsEiduHwXW6F9tn4pqwezF9FvRl1rwQYPAdeimoxupzsKuPEHMGJWXQMZZL8nxuzI1JXS18dfoFMCO8PNkqXelMLOnrRJtKsoVLLKDjPceh6sgj//O0y6YpaPfHm9jkcmthnIZ3xLNfU58nGMlsTNZpirS6PIYSQ2at3AK3y9LpHN/88u5+pn X-Forefront-PRVS: 0597911EE1 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BY2PR03MB238;9:HnN8lsP3Qe2MuOTZnwhPo33OvhhmwCt/unahlFc?= =?Windows-1252?Q?G1fE3l6Qw/A/kgQ4awFtMKCbcIIHCywk00KpPpTO4wg7ZQCgzzv6UjcK?= =?Windows-1252?Q?5PWRpqllcXndHBEWWSHHiWj/Gdos4r3PA8vtoazwSgP06Nsnk9Ds3+io?= =?Windows-1252?Q?Xhv3JMRi+l0RFGXeqjCv/yj/CtkTKZcQr0P2WFE+Ejat6CqlkYQsHcYY?= =?Windows-1252?Q?tPoRuCVvvs0omJmZCeisUVL7t9JwF5h20zkqtwYebXQNuRbMuTFp01Ft?= =?Windows-1252?Q?jjzZtO1oh1bwFrgZswbjwn/ibZIAHA9ALL1ui5V85DsRNul9YaWfGs7S?= =?Windows-1252?Q?gHcddgc30F0L1GtycfMxm9ya2E1BqcIs+8SfXi+bUAmjeyctE5L9UGbT?= =?Windows-1252?Q?UmOAs0NT/9DNitPRd4Os+ZNXFt4DO1u9E4mQHsS+XbtWLIwOtasR/DQu?= =?Windows-1252?Q?CSbGh18MPZ3pZpgNGQWLVajn5MorL24ODL1PLcTQZB44YFvWHOOSMB5L?= =?Windows-1252?Q?z+g9Bw0Z19OZ3H5gJsc2gGb13ZRA7bt4N+0gU/JLwswgmQndsYL3Es3O?= =?Windows-1252?Q?NaMLWRiK82JGZ6xJgLqS7Tj4zLQrh9nJ9ScVmSIazBEeHLr59/a63eJR?= =?Windows-1252?Q?zzs8GmmZ6fWxdhvmL3FHk2LUzsI9v6mrr0VItqwz3v+bZpCt/qQ/r4e/?= =?Windows-1252?Q?7YpXUKxyGq2g8Ip/wmRkLyiWihNraGMPdh/b45iJT5d70Iet5C+QWkq2?= =?Windows-1252?Q?8uEIRJCUHY5IArQ0PRR04R8TysmLnpPWm7GQRgqxQyBtGqXP0jnEtVDQ?= =?Windows-1252?Q?/pGkbZNf75P5otkahD4RIVHMddV+tUhytHgNky9kkOaEQSUTGq2x4pT8?= =?Windows-1252?Q?H4btVDp6rDl6unsUmZbNkeW0XoyokDRp6ihljQ5XCSeH/khdANt+EiIl?= =?Windows-1252?Q?7BB2CmL8n4ikbASJgatjvpKuobaCNV49lNaXXL0wPnTE0awCLcb4wJiF?= =?Windows-1252?Q?KC5lggdmkiyZCOddYWOf0rFp7p/3yrvN9OlVcB5CJ1015nmEsmC7TfYF?= =?Windows-1252?Q?zGX4NZ7rAJ01vRAahiHr1zwe+SSa1E/7fpblUZY8Z7W/GpFk9K0NdWCR?= =?Windows-1252?Q?LU+3OxzyFslOv2hYMXOhorRQ741Bl3aPunho+yUM3h33NjmDbYHpamow?= =?Windows-1252?Q?dIssUiGQRNfRftZq7ZcIDvJCrHkfVNaYCJAZNXTkKsYjU4KUZf+sPPLe?= =?Windows-1252?Q?On6lhFlx6euFuAxEyKsnJ3FDFXu9poGjvFJNdRTbM/+GZgY1GUZ89iPr?= =?Windows-1252?Q?e1tUsnXAwbQG4R1AnPUdHjoX+ugIzgvI5XtV+6WNbBbqMKX9sweeOout?= =?Windows-1252?Q?QETHCsDKsCXlTD2xPHUWlaSGjFMCixlm8TNfNwfkdOhuwWp5gkUFZnfM?= =?Windows-1252?Q?kPWAQb8ML1ZOFy/eJn6GYs+7NjW6BoLbsa3MDkkfXdzkE0aNo1U045Ie?= =?Windows-1252?Q?SblIIdlIHFbvTwomu4mI8SrMYBnl8QtIXKfb1EonWzQ2fcdlgn6siojn?= =?Windows-1252?Q?NiRx1QNm/1k6CT/e5VzGZMc/IEZm74IVUdQ+BbrGMzNH7tWUe52GrkBt?= =?Windows-1252?Q?VEkv0MeDBglY05Ypb+L0MJEzYvbRQZZxkIpkNhjUF?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB238;3:LgDnp6xzhFzxnXaH4+aMV+6n3Ftz10Ju4fv4VuSSo3G2fccVrcH8l+SW8yzoLC566ZD+pmRLRwOrnAeGwzasV0mMm/N6KjSeZTqwdyHF0ujQvE9AAE4Zcqq6lOiO+/f7VCHHwBeA3k5GXqXIuEgyKw==;10:i3JVNTUgCpTMpMmHKFIdYiAVfZrGByr5s4khEX4lhCHvEucjALONdIO8G3BC/Dh2qtLcfuLbHpmFjO2gT93sMOIo4Nk3ZGxbGStKzVQwgcg=;6:blwxfE1UTwyeki2w3Jmfo0eHKwT9r/bL2Jw6fC3KWIBuA2b5J49rBLs3I9gdQLqfGyfyGB0fAMknqOmhas6WRz3bSRqwmBW+5PXyXLVXYxLGCYlqMPteigYrlKn+8kf7VQJVzKYxv75baPmkSg/6jw== X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2015 15:32:15.2529 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR03MB238 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/04/2015 09:28 AM, tthayer@opensource.altera.com wrote: > From: Thor Thayer > > The Arria10 SOC uses a completely different SDRAM controller from the > earlier CycloneV and ArriaV SoCs. This patch abstracts the SDRAM bits > for the CycloneV/ArriaV SoCs in preparation for the Arria10 support. > > Signed-off-by: Thor Thayer > --- > v2: Make c5_data static. > --- > drivers/edac/altera_edac.c | 194 ++++++++++++++++++++------------------------ > drivers/edac/altera_edac.h | 116 ++++++++++++++++++++++++++ > 2 files changed, 206 insertions(+), 104 deletions(-) > create mode 100644 drivers/edac/altera_edac.h > > diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c > index a9e7c69..a8350f6 100644 > --- a/drivers/edac/altera_edac.c > +++ b/drivers/edac/altera_edac.c What branch are you basing this patch on? I get the following error when applied to both v4.1-rc6, linux-next, and linux-edac/linux-next. Applying: edac, altera: Refactor EDAC for Altera CycloneV SoC. error: patch failed: drivers/edac/altera_edac.c:400 error: drivers/edac/altera_edac.c: patch does not apply Patch failed at 0001 edac, altera: Refactor EDAC for Altera CycloneV SoC. Dinh