From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754175AbbFEC7z (ORCPT ); Thu, 4 Jun 2015 22:59:55 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:33863 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752335AbbFEC7x (ORCPT ); Thu, 4 Jun 2015 22:59:53 -0400 Message-ID: <557110A7.8070705@wwwdotorg.org> Date: Thu, 04 Jun 2015 20:59:51 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Eric Anholt , Ulf Hansson CC: linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , linux-mmc@vger.kernel.org Subject: Re: [PATCH v2 2/2] mmc: sdhci-bcm2835: Actually enable the clock References: <1432933572-8695-1-git-send-email-eric@anholt.net> <1432933572-8695-2-git-send-email-eric@anholt.net> In-Reply-To: <1432933572-8695-2-git-send-email-eric@anholt.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/29/2015 03:06 PM, Eric Anholt wrote: > We're currently using a fixed frequency clock specified in the DT, so > enabling is a no-op. However, the RPi firmware-based clocks driver > can actually disable unused clocks, so when switching to use it we > ended up losing our MMC clock once all devices were probed. > diff --git a/drivers/mmc/host/sdhci-bcm2835.c b/drivers/mmc/host/sdhci-bcm2835.c > + ret = clk_prepare_enable(pltfm_host->clk); > + if (ret) { > + dev_err(&pdev->dev, "failed to enable host clk\n"); > + goto err; > + } Given that pltfm_host is a "struct sdhci_pltfm_host" i.e. a type defined/handled by sdhci-pltfm.c , I'm rather surprised that sdhci-pltfm.c doesn't do this itself. Wouldn't it make sense for it to do so?