From: Chanwoo Choi <cw00.choi@samsung.com>
To: Jaewon Kim <jaewon02.kim@samsung.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH] extcon: max77843: Clear IRQ bits state before request IRQ
Date: Fri, 05 Jun 2015 13:53:56 +0900 [thread overview]
Message-ID: <55712B64.3090205@samsung.com> (raw)
In-Reply-To: <1433478747-12254-1-git-send-email-jaewon02.kim@samsung.com>
Hi Jaewon,
On 06/05/2015 01:32 PM, Jaewon Kim wrote:
> IRQ signal before driver probe is needless because driver sends
> current state after platform booting done.
> So, this patch clears MUIC IRQ bits before request IRQ.
>
> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
> ---
> drivers/extcon/extcon-max77843.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c
> index d78a64d..11e09d1 100644
> --- a/drivers/extcon/extcon-max77843.c
> +++ b/drivers/extcon/extcon-max77843.c
> @@ -781,6 +781,15 @@ static int max77843_muic_probe(struct platform_device *pdev)
> /* Support virtual irq domain for max77843 MUIC device */
> INIT_WORK(&info->irq_work, max77843_muic_irq_work);
>
> + /* Clear IRQ bits before request IRQs */
> + ret = regmap_bulk_read(max77843->regmap_muic,
> + MAX77843_MUIC_REG_INT1, info->status,
> + MAX77843_MUIC_IRQ_NUM);
> + if (ret) {
> + dev_err(&pdev->dev, "Failed to Clear IRQ bits\n");
> + goto err_muic_irq;
> + }
> +
> for (i = 0; i < ARRAY_SIZE(max77843_muic_irqs); i++) {
> struct max77843_muic_irq *muic_irq = &max77843_muic_irqs[i];
> unsigned int virq = 0;
>
Applied it.
Thanks,
Chanwoo Choi
next prev parent reply other threads:[~2015-06-05 4:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 4:32 [PATCH] extcon: max77843: Clear IRQ bits state before request IRQ Jaewon Kim
2015-06-05 4:53 ` Chanwoo Choi [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-06-05 4:54 MyungJoo Ham
2015-06-05 5:13 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55712B64.3090205@samsung.com \
--to=cw00.choi@samsung.com \
--cc=jaewon02.kim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox